From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from madras.collabora.co.uk (madras.collabora.co.uk [46.235.227.172]) by gabe.freedesktop.org (Postfix) with ESMTPS id 9E97610E104 for ; Tue, 8 Aug 2023 21:04:48 +0000 (UTC) From: =?UTF-8?q?Adri=C3=A1n=20Larumbe?= To: tvrtko.ursulin@intel.com, robdclark@chromium.org, kamil.konieczny@linux.intel.com, igt-dev@lists.freedesktop.org Date: Tue, 8 Aug 2023 22:03:30 +0100 Message-ID: <20230808210437.977482-1-adrian.larumbe@collabora.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Subject: [igt-dev] [PATCH 1/2] gputop: fix region array max iteration index loop bug List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: adrian.larumbe@collabora.com, kernel@collabora.com Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" List-ID: If c->regions->num_regions equals 1, then c->regions->max_region_id equals 0, so neither of the cumulative memory region size loops will be executed. Fix it by adjusting loop termination condition. Signed-off-by: Adrián Larumbe --- tools/gputop.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tools/gputop.c b/tools/gputop.c index ac106abea2ee..ea95e0333dd2 100644 --- a/tools/gputop.c +++ b/tools/gputop.c @@ -166,11 +166,11 @@ print_client(struct igt_drm_client *c, struct igt_drm_client **prevc, len = printf("%*s ", c->clients->max_pid_len, c->pid_str); if (c->regions->num_regions) { - for (sz = 0, i = 0; i < c->regions->max_region_id; i++) + for (sz = 0, i = 0; i <= c->regions->max_region_id; i++) sz += c->memory[i].total; len += print_size(sz); - for (sz = 0, i = 0; i < c->regions->max_region_id; i++) + for (sz = 0, i = 0; i <= c->regions->max_region_id; i++) sz += c->memory[i].resident; len += print_size(sz); } -- 2.41.0