From: Swati Sharma <swati2.sharma@intel.com>
To: igt-dev@lists.freedesktop.org
Subject: [igt-dev] [v2 4/4] tests/kms_color: skip deep-color test for mst
Date: Thu, 10 Aug 2023 13:47:43 +0530 [thread overview]
Message-ID: <20230810081743.1065566-5-swati2.sharma@intel.com> (raw)
In-Reply-To: <20230810081743.1065566-1-swati2.sharma@intel.com>
In intel driver, for MST streams pipe_bpp is restricted to 8bpc.
So, deep-color >= 10bpc will never work for DP-MST even if panel
supports 10bpc.
Test checks panel supports 10bpc and tries to find such a
combination of mode that can really work with 10bpc. So, with
n1 modes in MST1 and n2 modes in MST2, test will try n1xn2 times
and eventually SKIP. However, trying with these many combinations
it is leading to excessive logging ultimately killing the test.
Once KMD FIXME, is resolved this MST constraint can be removed.
Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/8615
Signed-off-by: Swati Sharma <swati2.sharma@intel.com>
---
tests/kms_color.c | 13 +++++++++++--
1 file changed, 11 insertions(+), 2 deletions(-)
diff --git a/tests/kms_color.c b/tests/kms_color.c
index b15b9572c..4a410c039 100644
--- a/tests/kms_color.c
+++ b/tests/kms_color.c
@@ -847,8 +847,17 @@ run_deep_color_tests_for_pipe(data_t *data, enum pipe p)
igt_output_set_prop_value(output, IGT_CONNECTOR_MAX_BPC, 10);
igt_output_set_pipe(output, p);
- if (is_intel_device(data->drm_fd) &&
- !igt_max_bpc_constraint(&data->display, p, output, 10))
+ /*
+ * In intel driver, for MST streams pipe_bpp is
+ * restricted to 8bpc. So, deep-color >= 10bpc
+ * will never work for DP-MST even if the panel
+ * supports 10bpc. Once KMD FIXME, is resolved
+ * this MST constraint can be removed.
+ */
+ if (is_intel_device(data->drm_fd) && igt_check_output_is_dp_mst(data->drm_fd, output))
+ continue;
+
+ if (is_intel_device(data->drm_fd) && !igt_max_bpc_constraint(&data->display, p, output, 10))
continue;
data->color_depth = 10;
--
2.25.1
next prev parent reply other threads:[~2023-08-10 8:17 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-10 8:17 [igt-dev] [v2 0/4] dp-mst helpers Swati Sharma
2023-08-10 8:17 ` [igt-dev] [v2 1/4] lib/igt_kms: add helper to check if output is mst Swati Sharma
2023-08-17 18:20 ` Modem, Bhanuprakash
2023-08-10 8:17 ` [igt-dev] [v2 2/4] lib/igt_kms: add helper for dp-mst connector id Swati Sharma
2023-08-17 18:29 ` Modem, Bhanuprakash
2023-08-10 8:17 ` [igt-dev] [v2 3/4] tests/kms: use dp-mst helpers Swati Sharma
2023-08-17 18:33 ` Modem, Bhanuprakash
2023-08-10 8:17 ` Swati Sharma [this message]
2023-08-17 18:44 ` [igt-dev] [v2 4/4] tests/kms_color: skip deep-color test for mst Modem, Bhanuprakash
2023-08-10 10:45 ` [igt-dev] ○ CI.xeBAT: info for dp-mst helpers (rev3) Patchwork
2023-08-10 10:46 ` [igt-dev] ✗ Fi.CI.BAT: failure " Patchwork
2023-08-10 11:21 ` [igt-dev] ✗ GitLab.Pipeline: warning " Patchwork
2023-08-17 19:46 ` [igt-dev] ○ CI.xeBAT: info for dp-mst helpers (rev4) Patchwork
2023-08-17 19:58 ` [igt-dev] ✓ Fi.CI.BAT: success " Patchwork
2023-08-18 14:31 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230810081743.1065566-5-swati2.sharma@intel.com \
--to=swati2.sharma@intel.com \
--cc=igt-dev@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox