From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.136]) by gabe.freedesktop.org (Postfix) with ESMTPS id E766810E515 for ; Thu, 10 Aug 2023 12:34:07 +0000 (UTC) Received: from linux.intel.com (maurocar-mobl2.ger.corp.intel.com [10.252.17.210]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by linux.intel.com (Postfix) with ESMTPS id 88790580CD0 for ; Thu, 10 Aug 2023 05:34:06 -0700 (PDT) Received: from maurocar by linux.intel.com with local (Exim 4.96) (envelope-from ) id 1qU4rc-0044FL-1y for igt-dev@lists.freedesktop.org; Thu, 10 Aug 2023 14:34:04 +0200 From: Mauro Carvalho Chehab To: igt-dev@lists.freedesktop.org Date: Thu, 10 Aug 2023 14:32:30 +0200 Message-ID: <20230810123402.969597-3-mauro.chehab@linux.intel.com> In-Reply-To: <20230810123402.969597-1-mauro.chehab@linux.intel.com> References: <20230810123402.969597-1-mauro.chehab@linux.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [igt-dev] [PATCH i-g-t 2/3] scripts/test_list.py: add a check for missing features List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" List-ID: From: Mauro Carvalho Chehab Some fields shall always be present at the documentation. Add a check for it. Signed-off-by: Mauro Carvalho Chehab --- scripts/test_list.py | 16 +++++++++++++++- 1 file changed, 15 insertions(+), 1 deletion(-) diff --git a/scripts/test_list.py b/scripts/test_list.py index 4f580fb3de58..c23d6d735edf 100755 --- a/scripts/test_list.py +++ b/scripts/test_list.py @@ -936,13 +936,27 @@ class TestList: if self.filters: print("NOTE: test checks are affected by filters") + mandatory_fields = set() + for field, item in self.props.items(): + if item["_properties_"].get("mandatory"): + mandatory_fields.add(field) + doc_subtests = set() args_regex = re.compile(r'\<[^\>]+\>') - for subtest in self.get_subtests()[""]: + missing_mandatory_fields = False + + subtests = self.expand_dictionary(True) + for subtest, data in sorted(subtests.items()): subtest = "@".join(subtest.split("@")[:3]) subtest = args_regex.sub(r'\\d+', subtest) + + for field in mandatory_fields: + if field not in data: + print(f"Warning: {subtest} {field} documentation is missing") + missing_mandatory_fields = True + doc_subtests.add(subtest) doc_subtests = list(sorted(doc_subtests)) -- 2.41.0