Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Jeevan B <jeevan.b@intel.com>
To: igt-dev@lists.freedesktop.org
Subject: [igt-dev] [PATCH] RFC: tests/kms_setmode: rename subtest to simplify test combinations
Date: Mon, 14 Aug 2023 13:35:27 +0530	[thread overview]
Message-ID: <20230814080527.3017102-1-jeevan.b@intel.com> (raw)

Both 'basic-clone-single-crtc' and 'invalid-clone-single-crtc' tests aim to
assess a scenario where two connectors are attempted to be run with a single
CRTC, which is not feasible.  Consequently, the  'basic-clone-single-crtc'
test is marked as invalid and skipped due to the impractical scenario. On the
other hand, the 'invalid-clone-single-crtc' test serves as a negative scenario,
confirming the failure of the 'ioctl' and indicating a successful test.

similarly, the 'invalid-clone-exclusive-crtc' test attempts to run two connectors
with two CRTCs, which is indeed possible, rendering the test nonsensical.
Consequently, the 'clone-exclusive-crtc' test runs and passes as expected.

Signed-off-by: Jeevan B <jeevan.b@intel.com>
Cc: Imre Deak <imre.deak@intel.com>
---
 tests/kms_setmode.c | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)

diff --git a/tests/kms_setmode.c b/tests/kms_setmode.c
index 035bbd0b0..0c65e3937 100644
--- a/tests/kms_setmode.c
+++ b/tests/kms_setmode.c
@@ -932,12 +932,8 @@ igt_main_args("det:", NULL, help_str, opt_handler, NULL)
 		const char *name;
 	} tests[] = {
 		{ TEST_TIMINGS, "basic" },
-		{ TEST_CLONE | TEST_SINGLE_CRTC_CLONE,
-					"basic-clone-single-crtc" },
 		{ TEST_INVALID | TEST_CLONE | TEST_SINGLE_CRTC_CLONE,
-					"invalid-clone-single-crtc" },
-		{ TEST_INVALID | TEST_CLONE | TEST_EXCLUSIVE_CRTC_CLONE,
-					"invalid-clone-exclusive-crtc" },
+					"clone-single-crtc-negative" },
 		{ TEST_CLONE | TEST_EXCLUSIVE_CRTC_CLONE,
 					"clone-exclusive-crtc" },
 		{ TEST_INVALID | TEST_CLONE | TEST_SINGLE_CRTC_CLONE | TEST_STEALING,
-- 
2.25.1

             reply	other threads:[~2023-08-14  8:01 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-14  8:05 Jeevan B [this message]
2023-08-14  9:41 ` [igt-dev] ✗ Fi.CI.BAT: failure for RFC: tests/kms_setmode: rename subtest to simplify test combinations Patchwork
2023-08-14 10:26 ` [igt-dev] ○ CI.xeBAT: info " Patchwork
2023-08-27 18:02 ` [igt-dev] [PATCH] " Imre Deak
2023-08-28  5:29   ` B, Jeevan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230814080527.3017102-1-jeevan.b@intel.com \
    --to=jeevan.b@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox