Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
To: igt-dev@lists.freedesktop.org
Subject: [igt-dev] [i-g-t V4 09/20] tests/i915/kms_big_fb: Add tiling support for XE
Date: Wed, 16 Aug 2023 22:01:55 +0530	[thread overview]
Message-ID: <20230816163206.402705-10-bhanuprakash.modem@intel.com> (raw)
In-Reply-To: <20230816163206.402705-1-bhanuprakash.modem@intel.com>

Remove the tiling restrictions in Xe specific tests

V2: - Update XE blocklist

Fixes: 34168d915 (tests/i915/kms_big_fb: Add XE support)
Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
---
 tests/i915/kms_big_fb.c         | 23 +----------------------
 tests/intel-ci/xe.blocklist.txt |  1 -
 2 files changed, 1 insertion(+), 23 deletions(-)

diff --git a/tests/i915/kms_big_fb.c b/tests/i915/kms_big_fb.c
index 33008c40a..4f39a65f4 100644
--- a/tests/i915/kms_big_fb.c
+++ b/tests/i915/kms_big_fb.c
@@ -1111,10 +1111,6 @@ igt_main
 	for (int i = 1; i < ARRAY_SIZE(modifiers); i++) {
 		igt_subtest_f("%s-addfb-size-overflow",
 			      modifiers[i].name) {
-			/* No tiling support in XE. */
-			igt_skip_on(is_xe_device(data.drm_fd) &&
-				    modifiers[i].modifier != DRM_FORMAT_MOD_LINEAR);
-
 			data.modifier = modifiers[i].modifier;
 			test_size_overflow(&data);
 		}
@@ -1124,10 +1120,6 @@ igt_main
 	for (int i = 1; i < ARRAY_SIZE(modifiers); i++) {
 		igt_subtest_f("%s-addfb-size-offset-overflow",
 			      modifiers[i].name) {
-			/* No tiling support in XE. */
-			igt_skip_on(is_xe_device(data.drm_fd) &&
-				    modifiers[i].modifier != DRM_FORMAT_MOD_LINEAR);
-
 			data.modifier = modifiers[i].modifier;
 			test_size_offset_overflow(&data);
 		}
@@ -1136,10 +1128,6 @@ igt_main
 	igt_describe("Sanity check if addfb ioctl works correctly for given size and strides of fb");
 	for (int i = 0; i < ARRAY_SIZE(modifiers); i++) {
 		igt_subtest_f("%s-addfb", modifiers[i].name) {
-			/* No tiling support in XE. */
-			igt_skip_on(is_xe_device(data.drm_fd) &&
-				    modifiers[i].modifier != DRM_FORMAT_MOD_LINEAR);
-
 			data.modifier = modifiers[i].modifier;
 			test_addfb(&data);
 		}
@@ -1157,13 +1145,8 @@ igt_main
 				igt_describe("Sanity check if addfb ioctl works correctly for given "
 						"combination of modifier formats and rotation");
 				igt_subtest_f("%s-%dbpp-rotate-%d", modifiers[i].name,
-					      formats[j].bpp, rotations[k].angle) {
-					/* No tiling support in XE. */
-					igt_skip_on(is_xe_device(data.drm_fd) &&
-						    data.modifier != DRM_FORMAT_MOD_LINEAR);
-
+					      formats[j].bpp, rotations[k].angle)
 					test_scanout(&data);
-				}
 			}
 
 			igt_fixture
@@ -1205,10 +1188,6 @@ igt_main
 						igt_require(intel_display_ver(intel_get_drm_devid(data.drm_fd)) >= 5);
 						data.max_hw_fb_width = min(data.hw_stride / (formats[j].bpp >> 3), data.max_fb_width);
 
-						/* No tiling support in XE. */
-						igt_skip_on(is_xe_device(data.drm_fd) &&
-							    modifiers[i].modifier != DRM_FORMAT_MOD_LINEAR);
-
 						test_scanout(&data);
 					}
 
diff --git a/tests/intel-ci/xe.blocklist.txt b/tests/intel-ci/xe.blocklist.txt
index cc6a68c73..dc6984c44 100644
--- a/tests/intel-ci/xe.blocklist.txt
+++ b/tests/intel-ci/xe.blocklist.txt
@@ -66,7 +66,6 @@ igt@kms_psr@.*_mmap_(cpu|gtt)
 igt@kms_legacy_colorkey@basic
 igt@kms_legacy_colorkey@invalid-plane
 igt@kms_flip_scaled_crc@flip-(32|64)bpp-(4|x|y|yf|tileccs)tile-.*
-igt@kms_big_fb@(4|x|y|yf)-tiled-.*
 igt@kms_flip@2x-flip-vs-fences
 igt@kms_flip@flip-vs-fences(-interruptible)
 igt@kms_addfb_basic@clobberred-modifier
-- 
2.40.0

  parent reply	other threads:[~2023-08-16 16:40 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-16 16:31 [igt-dev] [i-g-t V4 00/20] Add XE suppor for display tests Bhanuprakash Modem
2023-08-16 16:31 ` [igt-dev] [i-g-t V4 01/20] lib: Add tiling support for XE Bhanuprakash Modem
2023-08-23 13:54   ` [igt-dev] [i-g-t,V4,01/20] " Joshi, Kunal1
2023-08-16 16:31 ` [igt-dev] [i-g-t V4 02/20] tests/kms_cursor_edge_walk: Fix intel specific checks Bhanuprakash Modem
2023-08-16 16:31 ` [igt-dev] [i-g-t V4 03/20] tests/kms_getfb: Extended ccs tests to support XE Bhanuprakash Modem
2023-08-17  8:29   ` Kamil Konieczny
2023-08-16 16:31 ` [igt-dev] [i-g-t V4 04/20] tests/kms_addfb_basic: Add tiling support for XE Bhanuprakash Modem
2023-08-23 13:51   ` [igt-dev] [i-g-t, V4, " Joshi, Kunal1
2023-08-16 16:31 ` [igt-dev] [i-g-t V4 05/20] tests/kms_plane: " Bhanuprakash Modem
2023-08-16 16:31 ` [igt-dev] [i-g-t V4 06/20] tests/kms_plane_lowres: " Bhanuprakash Modem
2023-08-18  8:27   ` [igt-dev] [i-g-t, V4, " Joshi, Kunal1
2023-08-16 16:31 ` [igt-dev] [i-g-t V4 07/20] tests/kms_plane_scaling: " Bhanuprakash Modem
2023-08-18  8:29   ` [igt-dev] [i-g-t, V4, " Joshi, Kunal1
2023-08-16 16:31 ` [igt-dev] [i-g-t V4 08/20] tests/kms_rotation_crc: " Bhanuprakash Modem
2023-08-18  8:32   ` [igt-dev] [i-g-t, V4, " Joshi, Kunal1
2023-08-16 16:31 ` Bhanuprakash Modem [this message]
2023-08-18  8:33   ` [igt-dev] [i-g-t, V4, 09/20] tests/i915/kms_big_fb: " Joshi, Kunal1
2023-08-16 16:31 ` [igt-dev] [i-g-t V4 10/20] tests/i915/kms_draw_crc: " Bhanuprakash Modem
2023-08-18  8:38   ` [igt-dev] [i-g-t, V4, " Joshi, Kunal1
2023-08-16 16:31 ` [igt-dev] [i-g-t V4 11/20] tests/i915/kms_flip_scaled_crc: " Bhanuprakash Modem
2023-08-18  8:40   ` [igt-dev] [i-g-t, V4, " Joshi, Kunal1
2023-08-16 16:31 ` [igt-dev] [i-g-t V4 12/20] tests/i915/kms_flip_tiling: " Bhanuprakash Modem
2023-08-18  8:41   ` [igt-dev] [i-g-t, V4, " Joshi, Kunal1
2023-08-16 16:31 ` [igt-dev] [i-g-t V4 13/20] tests/i915/kms_ccs: Add XE support Bhanuprakash Modem
2023-08-16 16:32 ` [igt-dev] [i-g-t V4 14/20] tests/i915/kms_fb_coherancy: " Bhanuprakash Modem
2023-08-23 16:12   ` Kamil Konieczny
2023-08-16 16:32 ` [igt-dev] [i-g-t V4 15/20] tests/i915/kms_fbcon_fbt: " Bhanuprakash Modem
2023-08-18  8:43   ` [igt-dev] [i-g-t, V4, " Joshi, Kunal1
2023-08-16 16:32 ` [igt-dev] [i-g-t V4 16/20] tests/kms_async_flips: " Bhanuprakash Modem
2023-08-16 16:32 ` [igt-dev] [i-g-t V4 17/20] tests/kms_prime: " Bhanuprakash Modem
2023-08-16 16:32 ` [igt-dev] [i-g-t V4 18/20] tests/intel-ci: Update Xe ffb testlist & blocklist for kms_frontbuffer_tracking Bhanuprakash Modem
2023-08-16 16:32 ` [igt-dev] [i-g-t V4 19/20] tests/intel-ci: Drop tiling tests from xe blocklist Bhanuprakash Modem
2023-08-16 16:32 ` [igt-dev] [i-g-t V4 20/20] HAX: Run tiling tests in XE fast-feedback Bhanuprakash Modem
2023-08-16 19:05 ` [igt-dev] ✓ Fi.CI.BAT: success for Add XE suppor for display tests (rev5) Patchwork
2023-08-16 20:12 ` [igt-dev] ○ CI.xeBAT: info " Patchwork
2023-08-17  3:28 ` [igt-dev] ✓ Fi.CI.IGT: success " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230816163206.402705-10-bhanuprakash.modem@intel.com \
    --to=bhanuprakash.modem@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox