Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Jouni Högander" <jouni.hogander@intel.com>
To: igt-dev@lists.freedesktop.org
Subject: [igt-dev] [PATCH i-g-t] tests/i915: Take into account fbc_status "stolen memory not initialised"
Date: Fri, 18 Aug 2023 11:08:27 +0300	[thread overview]
Message-ID: <20230818080827.1889393-1-jouni.hogander@intel.com> (raw)

Earlier non initialized memory caused fbc_status debugfs interface not
being created at all. This was considered as "Unsupported chipset" by
certain igt testcases. Now fbc_status is informing "stolen memory not
initialised". Consider this again as "Unsupported chipset"

Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/9131
Signed-off-by: Jouni Högander <jouni.hogander@intel.com>
---
 tests/i915/kms_fbcon_fbt.c            | 3 ++-
 tests/i915/kms_frontbuffer_tracking.c | 3 ++-
 2 files changed, 4 insertions(+), 2 deletions(-)

diff --git a/tests/i915/kms_fbcon_fbt.c b/tests/i915/kms_fbcon_fbt.c
index e65cbda93..2cb0ffdb4 100644
--- a/tests/i915/kms_fbcon_fbt.c
+++ b/tests/i915/kms_fbcon_fbt.c
@@ -103,7 +103,8 @@ static bool fbc_supported_on_chipset(int device, int debugfs_fd)
 	if (ret < 0)
 		return false;
 
-	return !strstr(buf, "FBC unsupported on this chipset\n");
+	return !strstr(buf, "FBC unsupported on this chipset\n") &&
+		!strstr(buf, "stolen memory not initialised\n");
 }
 
 static bool connector_can_fbc(drmModeConnectorPtr connector)
diff --git a/tests/i915/kms_frontbuffer_tracking.c b/tests/i915/kms_frontbuffer_tracking.c
index 3e8f15bb0..136426204 100644
--- a/tests/i915/kms_frontbuffer_tracking.c
+++ b/tests/i915/kms_frontbuffer_tracking.c
@@ -1444,7 +1444,8 @@ static bool fbc_supported_on_chipset(void)
 	if (*buf == '\0')
 		return false;
 
-	return !strstr(buf, "FBC unsupported on this chipset\n");
+	return !strstr(buf, "FBC unsupported on this chipset\n") &&
+		!strstr(buf, "stolen memory not initialised\n");
 }
 
 static void setup_fbc(void)
-- 
2.34.1

             reply	other threads:[~2023-08-18  8:09 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-18  8:08 Jouni Högander [this message]
2023-08-18  9:02 ` [igt-dev] ○ CI.xeBAT: info for tests/i915: Take into account fbc_status "stolen memory not initialised" Patchwork
2023-08-18  9:14 ` [igt-dev] ✓ Fi.CI.BAT: success " Patchwork
2023-08-19 12:13 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
2023-08-21 11:46   ` Hogander, Jouni
2023-08-21 10:06 ` [igt-dev] [PATCH i-g-t] " Juha-Pekka Heikkila
2023-08-21 11:52   ` Hogander, Jouni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230818080827.1889393-1-jouni.hogander@intel.com \
    --to=jouni.hogander@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox