Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
To: igt-dev@lists.freedesktop.org
Cc: Kunal Joshi <kunal1.joshi@intel.com>
Subject: [igt-dev] [i-g-t 04/16] tests/kms_addfb_basic: Add tiling support for XE
Date: Thu, 24 Aug 2023 11:11:11 +0530	[thread overview]
Message-ID: <20230824054123.820518-5-bhanuprakash.modem@intel.com> (raw)
In-Reply-To: <20230824054123.820518-1-bhanuprakash.modem@intel.com>

Remove the tiling restrictions in Xe specific tests

V2: - Update Xe fast-feedback testlist & blocklist
V3: - New patch for blocklist & BAT testlist changes

Fixes: 8c3b02be3 (tests/kms_addfb_basic: Add XE support)
Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
Reviewed-by: Kunal Joshi <kunal1.joshi@intel.com>
---
 tests/kms_addfb_basic.c | 17 ++++++++++++-----
 1 file changed, 12 insertions(+), 5 deletions(-)

diff --git a/tests/kms_addfb_basic.c b/tests/kms_addfb_basic.c
index f415300b6..f6c27a3d3 100644
--- a/tests/kms_addfb_basic.c
+++ b/tests/kms_addfb_basic.c
@@ -444,7 +444,7 @@ static void tiling_tests(int fd)
 
 	igt_subtest_group {
 		igt_fixture {
-			igt_require_i915(fd);
+			igt_require_intel(fd);
 			tiled_x_bo = igt_create_bo_with_dimensions(fd, 1024, 1024,
 				DRM_FORMAT_XRGB8888, I915_FORMAT_MOD_X_TILED,
 				1024*4, NULL, NULL, NULL);
@@ -463,7 +463,8 @@ static void tiling_tests(int fd)
 		f.pitches[0] = 1024*4;
 		igt_describe("Check if addfb2 and rmfb call works for basic x-tiling test");
 		igt_subtest("basic-x-tiled-legacy") {
-			igt_require(gem_available_fences(fd) > 0);
+			if (is_i915_device(fd))
+				igt_require(gem_available_fences(fd) > 0);
 			f.handles[0] = tiled_x_bo;
 
 			do_ioctl(fd, DRM_IOCTL_MODE_ADDFB2, &f);
@@ -473,6 +474,7 @@ static void tiling_tests(int fd)
 
 		igt_describe("Check if addfb2 call works for x and y tiling");
 		igt_subtest("framebuffer-vs-set-tiling") {
+			igt_require_i915(fd);
 			igt_require(gem_available_fences(fd) > 0);
 			f.handles[0] = gem_bo;
 
@@ -487,6 +489,7 @@ static void tiling_tests(int fd)
 		igt_describe("Test that addfb2 call fails correctly for pitches mismatch");
 			f.pitches[0] = 512*4;
 		igt_subtest("tile-pitch-mismatch") {
+			igt_require_i915(fd);
 			igt_require(gem_available_fences(fd) > 0);
 			f.handles[0] = tiled_x_bo;
 
@@ -496,8 +499,12 @@ static void tiling_tests(int fd)
 		igt_describe("Test that addfb2 call fails correctly for basic y-tiling test");
 		f.pitches[0] = 1024*4;
 		igt_subtest("basic-y-tiled-legacy") {
-			igt_require(!gem_has_lmem(fd));
-			igt_require(gem_available_fences(fd) > 0);
+			if (is_i915_device(fd)) {
+				igt_require(!gem_has_lmem(fd));
+				igt_require(gem_available_fences(fd) > 0);
+			} else {
+				igt_require(!xe_has_vram(fd));
+			}
 			f.handles[0] = tiled_y_bo;
 
 			do_ioctl_err(fd, DRM_IOCTL_MODE_ADDFB2, &f, EINVAL);
@@ -1118,7 +1125,7 @@ igt_main
 		size_tests(fd);
 
 		igt_fixture
-			igt_require_i915(fd);
+			igt_require_intel(fd);
 
 		addfb25_ytile(fd);
 
-- 
2.40.0

  parent reply	other threads:[~2023-08-24  5:49 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-24  5:41 [igt-dev] [i-g-t 00/16] Add tiling support for display tests Bhanuprakash Modem
2023-08-24  5:41 ` [igt-dev] [i-g-t 01/16] lib: Add tiling support for XE Bhanuprakash Modem
2023-08-24  5:41 ` [igt-dev] [i-g-t 02/16] tests/kms_cursor_edge_walk: Fix intel specific checks Bhanuprakash Modem
2023-08-24  5:41 ` [igt-dev] [i-g-t 03/16] tests/kms_getfb: Extended ccs tests to support XE Bhanuprakash Modem
2023-08-24  5:41 ` Bhanuprakash Modem [this message]
2023-08-24  5:41 ` [igt-dev] [i-g-t 05/16] tests/kms_plane: Add tiling support for XE Bhanuprakash Modem
2023-08-24  5:41 ` [igt-dev] [i-g-t 06/16] tests/kms_plane_lowres: " Bhanuprakash Modem
2023-08-24  5:41 ` [igt-dev] [i-g-t 07/16] tests/kms_plane_scaling: " Bhanuprakash Modem
2023-08-24  5:41 ` [igt-dev] [i-g-t 08/16] tests/kms_rotation_crc: " Bhanuprakash Modem
2023-08-24  5:41 ` [igt-dev] [i-g-t 09/16] tests/i915/kms_big_fb: " Bhanuprakash Modem
2023-08-24  5:41 ` [igt-dev] [i-g-t 10/16] tests/i915/kms_draw_crc: " Bhanuprakash Modem
2023-08-24  5:41 ` [igt-dev] [i-g-t 11/16] tests/i915/kms_flip_scaled_crc: " Bhanuprakash Modem
2023-08-24  5:41 ` [igt-dev] [i-g-t 12/16] tests/i915/kms_flip_tiling: " Bhanuprakash Modem
2023-08-24  5:41 ` [igt-dev] [i-g-t 13/16] tests/intel-ci: Drop tiling tests from xe blocklist Bhanuprakash Modem
2023-08-24  5:41 ` [igt-dev] [i-g-t 14/16] tests/intel-ci: Update Xe BAT & blocklist for kms FBT Bhanuprakash Modem
2023-08-24  5:41 ` [igt-dev] [i-g-t 15/16] tests/intel-ci: Add tiling tests to XE BAT Bhanuprakash Modem
2023-08-24  5:41 ` [igt-dev] [i-g-t 16/16] HAX: Run tiling tests in XE fast-feedback Bhanuprakash Modem
2023-08-24  6:03 ` [igt-dev] ✗ GitLab.Pipeline: warning for Add tiling support for display tests Patchwork
2023-08-24  6:22 ` [igt-dev] ✗ CI.xeBAT: failure " Patchwork
2023-08-24  6:30 ` [igt-dev] ✓ Fi.CI.BAT: success " Patchwork
2023-08-24 14:15 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230824054123.820518-5-bhanuprakash.modem@intel.com \
    --to=bhanuprakash.modem@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=kunal1.joshi@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox