From: Aurabindo Pillai <aurabindo.pillai@amd.com>
To: <igt-dev@lists.freedesktop.org>
Cc: hersenxs.wu@amd.com
Subject: [igt-dev] [PATCH 1/3] tests/amdgpu/amd_mall: Add crc check
Date: Thu, 24 Aug 2023 12:15:02 -0400 [thread overview]
Message-ID: <20230824161504.154365-1-aurabindo.pillai@amd.com> (raw)
In addition to checking whether display scanout from MALL cache is
triggered, double check that the same pattern is being displayed. This
can detect any corruption due to incorrect MALL size calculations
Signed-off-by: Aurabindo Pillai <aurabindo.pillai@amd.com>
---
tests/amdgpu/amd_mall.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/tests/amdgpu/amd_mall.c b/tests/amdgpu/amd_mall.c
index c50d046ee..6016d5e8c 100644
--- a/tests/amdgpu/amd_mall.c
+++ b/tests/amdgpu/amd_mall.c
@@ -117,6 +117,7 @@ static void test_mall_ss(data_t *data)
igt_fb_t rfb;
int exec_ret;
struct line_check line = {0};
+ igt_crc_t test_crc, ref_crc;
test_init(data);
@@ -124,6 +125,7 @@ static void test_mall_ss(data_t *data)
igt_plane_set_fb(data->primary, &rfb);
igt_display_commit_atomic(display, DRM_MODE_ATOMIC_ALLOW_MODESET, NULL);
+ igt_pipe_crc_collect_crc(data->pipe_crc, &ref_crc);
sleep(MALL_SETTLE_DELAY);
igt_system_cmd(exec_ret, "umr -O bits -r *.*.HUBP0_HUBP_MALL_STATUS | grep MALL_IN_USE");
@@ -135,6 +137,10 @@ static void test_mall_ss(data_t *data)
igt_assert_eq(line.found, 1);
+ igt_pipe_crc_collect_crc(data->pipe_crc, &test_crc);
+
+ igt_assert_crc_equal(&ref_crc, &test_crc);
+
igt_remove_fb(data->fd, &rfb);
test_fini(data);
}
--
2.41.0
next reply other threads:[~2023-08-24 16:15 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-24 16:15 Aurabindo Pillai [this message]
2023-08-24 16:15 ` [igt-dev] [PATCH 2/3] tests/amdgpu/amd_mall: remove UMR dependency Aurabindo Pillai
2023-08-25 3:49 ` Alex Hung
2023-08-25 13:51 ` Aurabindo Pillai
2023-08-24 16:15 ` [igt-dev] [PATCH 3/3] lib/amdgpu: checkpatch.pl fixes Aurabindo Pillai
2023-08-24 17:41 ` [igt-dev] ✗ Fi.CI.BUILD: failure for series starting with [1/3] tests/amdgpu/amd_mall: Add crc check Patchwork
2023-08-24 17:45 ` [igt-dev] ✗ GitLab.Pipeline: warning " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230824161504.154365-1-aurabindo.pillai@amd.com \
--to=aurabindo.pillai@amd.com \
--cc=hersenxs.wu@amd.com \
--cc=igt-dev@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox