From: "Thasleem, Mohammed" <mohammed.thasleem@intel.com>
To: igt-dev@lists.freedesktop.org
Subject: [igt-dev] [PATCH i-g-t] tests/i915/i915_pm_dc: Fix dc9-dpms test on MTL
Date: Fri, 25 Aug 2023 02:37:18 +0530 [thread overview]
Message-ID: <20230824210718.7235-1-mohammed.thasleem@intel.com> (raw)
In-Reply-To: <20230814095654.872-1-mohammed.thasleem@intel.com>
From: "Mohammed Thasleem" <mohammed.thasleem@intel.com>
DC5 counter on MTL is not expected to get reset in DC9 state.
Add condition to check runtime_suspended_time value to validate
DC9 dpms test.
Signed-off-by: Mohammed Thasleem <mohammed.thasleem@intel.com>
---
tests/i915/i915_pm_dc.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/tests/i915/i915_pm_dc.c b/tests/i915/i915_pm_dc.c
index 90fe847fc..13ae31583 100644
--- a/tests/i915/i915_pm_dc.c
+++ b/tests/i915/i915_pm_dc.c
@@ -88,7 +88,7 @@
#define KMS_HELPER "/sys/module/drm_kms_helper/parameters/"
#define PACKAGE_CSTATE_PATH "pmc_core/package_cstate_show"
#define KMS_POLL_DISABLE 0
-#define DC9_RESETS_DC_COUNTERS(devid) (!(IS_DG1(devid) || IS_DG2(devid)))
+#define DC9_RESETS_DC_COUNTERS(devid) (!(IS_DG1(devid) || IS_DG2(devid) || IS_METEORLAKE(devid)))
IGT_TEST_DESCRIPTION("Tests to validate display power DC states.");
@@ -514,7 +514,7 @@ static bool dc9_wait_entry(data_t *data, int dc_target, int prev_dc, int prev_rp
* Runtime suspended residency should increment once DC9 is achieved;
* this condition is valid for all platforms.
* However, resetting of dc5/dc6 counter to check if display engine was in DC9;
- * this condition at present can be skipped for dg1 and dg2 platforms.
+ * this condition at present can be skipped for dg1, dg2 and MTL platforms.
*/
return igt_wait((read_runtime_suspended_time(data->drm_fd) > prev_rpm) &&
(!DC9_RESETS_DC_COUNTERS(data->devid) ||
--
2.34.1
next prev parent reply other threads:[~2023-08-24 15:37 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-14 9:56 [igt-dev] [PATCH i-g-t] tests/i915/i915_pm_dc: Check runtime suspend for DC9 test Thasleem, Mohammed
2023-08-14 10:52 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2023-08-14 11:12 ` [igt-dev] ○ CI.xeBAT: info " Patchwork
2023-08-14 13:19 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
2023-08-14 16:32 ` [igt-dev] [PATCH i-g-t] " Kamil Konieczny
2023-08-24 17:15 ` [igt-dev] ✗ GitLab.Pipeline: warning for tests/i915/i915_pm_dc: Check runtime suspend for DC9 test (rev2) Patchwork
2023-08-24 17:45 ` [igt-dev] ✓ Fi.CI.BAT: success " Patchwork
2023-08-24 17:52 ` [igt-dev] ✓ CI.xeBAT: " Patchwork
2023-08-24 21:07 ` Thasleem, Mohammed [this message]
2023-08-24 18:05 ` [igt-dev] [PATCH i-g-t] tests/i915/i915_pm_dc: Fix dc9-dpms test on MTL Kamil Konieczny
2023-08-25 5:35 ` [igt-dev] ✓ Fi.CI.IGT: success for tests/i915/i915_pm_dc: Check runtime suspend for DC9 test (rev2) Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230824210718.7235-1-mohammed.thasleem@intel.com \
--to=mohammed.thasleem@intel.com \
--cc=igt-dev@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox