Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Karthik B S <karthik.b.s@intel.com>
To: igt-dev@lists.freedesktop.org
Subject: [igt-dev] [PATCH i-g-t 2/2] tests/i915/kms_big_joiner: Make use of big joiner helpers
Date: Fri, 25 Aug 2023 09:02:43 +0530	[thread overview]
Message-ID: <20230825033243.1690-3-karthik.b.s@intel.com> (raw)
In-Reply-To: <20230825033243.1690-1-karthik.b.s@intel.com>

Replace the hardcoded constraints in the test with the generic big joiner
helpers already present in lib. This ensures that all big joiner
constraints are accounted for.

Signed-off-by: Karthik B S <karthik.b.s@intel.com>
---
 tests/i915/kms_big_joiner.c | 15 ++++++++-------
 1 file changed, 8 insertions(+), 7 deletions(-)

diff --git a/tests/i915/kms_big_joiner.c b/tests/i915/kms_big_joiner.c
index d438b2211..1d32c8a12 100644
--- a/tests/i915/kms_big_joiner.c
+++ b/tests/i915/kms_big_joiner.c
@@ -31,8 +31,6 @@
  */
 #include "igt.h"
 
-#define MAX_HDISPLAY_PER_PIPE 5120
-
 IGT_TEST_DESCRIPTION("Test big joiner");
 
 typedef struct {
@@ -217,7 +215,7 @@ igt_main
 						 sort_drm_modes_by_res_dsc);
 
 			mode = &output->config.connector->modes[0];
-			if (mode->hdisplay > MAX_HDISPLAY_PER_PIPE) {
+			if (igt_bigjoiner_possible(mode, igt_get_max_dotclock(data.drm_fd))) {
 				data.big_joiner_output[count++] = output;
 
 				width = max(width, mode->hdisplay);
@@ -226,6 +224,8 @@ igt_main
 			valid_output++;
 		}
 
+		igt_require_f(count > 0, "No output with big joiner requirement found\n");
+
 		data.n_pipes = 0;
 		for_each_pipe(&data.display, i) {
 			data.n_pipes++;
@@ -233,8 +233,6 @@ igt_main
 			j++;
 		}
 
-		igt_require_f(count > 0, "No output with 5k+ mode found\n");
-
 		igt_create_pattern_fb(data.drm_fd, width, height, DRM_FORMAT_XRGB8888,
 				      DRM_FORMAT_MOD_LINEAR, &data.fb);
 	}
@@ -243,8 +241,11 @@ igt_main
 	igt_subtest_with_dynamic("basic") {
 		for (i = 0; i < data.n_pipes - 1; i++) {
 			data.pipe1 = pipe_seq[i];
-			igt_dynamic_f("pipe-%s", kmstest_pipe_name(pipe_seq[i]))
-				test_basic_modeset(&data);
+			igt_output_set_pipe(data.big_joiner_output[0], data.pipe1);
+			if (i915_pipe_output_combo_valid(&data.display)) {
+				igt_dynamic_f("pipe-%s", kmstest_pipe_name(pipe_seq[i]))
+					test_basic_modeset(&data);
+			}
 		}
 	}
 
-- 
2.39.1

  parent reply	other threads:[~2023-08-25  3:32 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-25  3:32 [igt-dev] [PATCH i-g-t 0/2] tests/i915/kms_big_joiner: Test Cleanup Karthik B S
2023-08-25  3:32 ` [igt-dev] [PATCH i-g-t 1/2] " Karthik B S
2023-08-25  3:32 ` Karthik B S [this message]
2023-08-25  5:06 ` [igt-dev] ✗ CI.xeBAT: failure for " Patchwork
2023-08-25  5:14 ` [igt-dev] ✓ Fi.CI.BAT: success " Patchwork
2023-08-25 16:34 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230825033243.1690-3-karthik.b.s@intel.com \
    --to=karthik.b.s@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox