From: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
To: igt-dev@lists.freedesktop.org
Subject: [igt-dev] [i-g-t 1/4] tests/kms_async_flips: Add XE support
Date: Fri, 25 Aug 2023 13:41:50 +0530 [thread overview]
Message-ID: <20230825081153.883708-2-bhanuprakash.modem@intel.com> (raw)
In-Reply-To: <20230825081153.883708-1-bhanuprakash.modem@intel.com>
Add XE driver support for kms tests.
V2: - Update XE blocklist
V3: - New patch for blocklist changes
Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
Reviewed-by: Karthik B S <karthik.b.s@intel.com>
---
tests/kms_async_flips.c | 12 +++---------
1 file changed, 3 insertions(+), 9 deletions(-)
diff --git a/tests/kms_async_flips.c b/tests/kms_async_flips.c
index 2a317a9ef..45c38c590 100644
--- a/tests/kms_async_flips.c
+++ b/tests/kms_async_flips.c
@@ -254,7 +254,7 @@ static void test_async_flip(data_t *data)
* in order to change the watermark levels as per the optimization. Hence the
* subsequent async flips will actually do the asynchronous flips.
*/
- if (is_i915_device(data->drm_fd)) {
+ if (is_intel_device(data->drm_fd)) {
uint32_t devid = intel_get_drm_devid(data->drm_fd);
if (IS_GEN9(devid) || IS_GEN10(devid) || AT_LEAST_GEN(devid, 12)) {
@@ -663,13 +663,7 @@ igt_main
int i;
igt_fixture {
- /*
- * FIXME: As of now, Async flips won't work with linear buffers
- * on Intel hardware, hence don't run tests on XE device as XE
- * won't support tiling.
- * Once Kernel changes got landed, please update this logic.
- */
- data.drm_fd = drm_open_driver_master(DRIVER_ANY & ~DRIVER_XE);
+ data.drm_fd = drm_open_driver_master(DRIVER_ANY);
kmstest_set_vt_graphics_mode();
igt_display_require(&data.display, data.drm_fd);
igt_display_require_output(&data.display);
@@ -717,7 +711,7 @@ igt_main
igt_describe("Negative case to verify if changes in fb are rejected from kernel as expected");
igt_subtest_with_dynamic("invalid-async-flip") {
/* TODO: support more vendors */
- igt_require(is_i915_device(data.drm_fd));
+ igt_require(is_intel_device(data.drm_fd));
igt_require(igt_display_has_format_mod(&data.display, DRM_FORMAT_XRGB8888,
I915_FORMAT_MOD_Y_TILED));
--
2.40.0
next prev parent reply other threads:[~2023-08-25 8:19 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-25 8:11 [igt-dev] [i-g-t 0/4] Add XE support for Async flip tests Bhanuprakash Modem
2023-08-25 8:11 ` Bhanuprakash Modem [this message]
2023-08-25 8:11 ` [igt-dev] [i-g-t 2/4] tests/i915/kms_big_fb: Fix testplan documentation Bhanuprakash Modem
2023-08-31 8:37 ` Sharma, Swati2
2023-08-25 8:11 ` [igt-dev] [i-g-t 3/4] tests/intel-ci: Drop async flip tests from xe blocklist Bhanuprakash Modem
2023-08-31 8:38 ` Sharma, Swati2
2023-08-25 8:11 ` [igt-dev] [i-g-t 4/4] HAX: Add Async flips to XE BAT Bhanuprakash Modem
2023-08-28 5:33 ` [igt-dev] [i-g-t V2 " Bhanuprakash Modem
2023-08-25 10:18 ` [igt-dev] ✗ GitLab.Pipeline: warning for Add XE support for Async flip tests Patchwork
2023-08-25 10:38 ` [igt-dev] ✗ CI.xeBAT: failure " Patchwork
2023-08-25 10:46 ` [igt-dev] ✓ Fi.CI.BAT: success " Patchwork
2023-08-25 22:57 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
2023-08-28 17:22 ` [igt-dev] ✗ GitLab.Pipeline: warning for Add XE support for Async flip tests (rev2) Patchwork
2023-08-28 17:50 ` [igt-dev] ✗ CI.xeBAT: failure " Patchwork
2023-08-28 17:55 ` [igt-dev] ✓ Fi.CI.BAT: success " Patchwork
2023-08-28 20:05 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230825081153.883708-2-bhanuprakash.modem@intel.com \
--to=bhanuprakash.modem@intel.com \
--cc=igt-dev@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox