From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.24]) by gabe.freedesktop.org (Postfix) with ESMTPS id 443F610E073 for ; Thu, 31 Aug 2023 12:30:45 +0000 (UTC) Date: Thu, 31 Aug 2023 14:30:40 +0200 From: Mauro Carvalho Chehab To: Katarzyna Dec Message-ID: <20230831143040.11f82c2b@maurocar-mobl2> In-Reply-To: <20230831113936.4075130-1-katarzyna.dec@intel.com> References: <20230831113936.4075130-1-katarzyna.dec@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [igt-dev] [PATCH i-g-t 0/2] IGT XE documentation cleanup List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: igt-dev@lists.freedesktop.org, Gandi Ramadevi Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" List-ID: On Thu, 31 Aug 2023 11:39:34 +0000 Katarzyna Dec wrote: > Let's add missing documentation fileds that are causing warnings. > Some tests documentation needed changes to have more accurate naming. > Let's mark Negative and Stress tests. > Adding missing 'Run type' and 'Test category' for remaining test. Kasia, Besides the changes, could you please also change the sub-category field and/or Functionalities for xe_mmap.c? Right now, both are using "mmap" bucket. This is valid for the documentation itself, but it causes confusion when analyzing the results later on, as there will be two buckets with the same name but different meanings. Perhaps we could use Sub-category == "VMA". What do you think? Another issue I noticed in this series is that we have "Blitter" with the first letter in uppercase. Perhaps there are more cases like that. Please let's use lowercase on such buckets, as this is less prone to errors (IMO). Regards, Mauro