From: Marcin Bernatowicz <marcin.bernatowicz@linux.intel.com>
To: igt-dev@lists.freedesktop.org
Subject: [igt-dev] [PATCH i-g-t v3 3/3] tests/xe_spin_batch: spin-fixed-duration
Date: Tue, 5 Sep 2023 15:02:25 +0000 [thread overview]
Message-ID: <20230905150225.2029554-4-marcin.bernatowicz@linux.intel.com> (raw)
In-Reply-To: <20230905150225.2029554-1-marcin.bernatowicz@linux.intel.com>
Basic test for xe_spin with fixed duration.
v2: Added assert for expected spinner duration. (Zbyszek)
A median of 5x100ms spins duration is computed, which should
satisfy CI runs, although better accuracy is achieved with
disabled logging (echo 0 > /sys/module/drm/parameters/debug).
Signed-off-by: Marcin Bernatowicz <marcin.bernatowicz@linux.intel.com>
---
tests/intel/xe_spin_batch.c | 72 +++++++++++++++++++++++++++++++++++++
1 file changed, 72 insertions(+)
diff --git a/tests/intel/xe_spin_batch.c b/tests/intel/xe_spin_batch.c
index 26f9daf36..6dcd89558 100644
--- a/tests/intel/xe_spin_batch.c
+++ b/tests/intel/xe_spin_batch.c
@@ -1,8 +1,10 @@
#include "igt.h"
+#include "igt_syncobj.h"
#include "lib/intel_reg.h"
#include "xe_drm.h"
#include "xe/xe_ioctl.h"
#include "xe/xe_query.h"
+#include "xe/xe_spin.h"
/**
* TEST: Tests for spin batch submissons.
@@ -138,6 +140,73 @@ static void spin_all(int fd, int gt, int class)
xe_vm_destroy(fd, vm);
}
+/**
+ * SUBTEST: spin-fixed-duration
+ * Description: Basic test which validates the functionality of xe_spin with fixed duration.
+ * Run type: FULL
+ */
+static void xe_spin_fixed_duration(int fd)
+{
+ uint64_t ahnd;
+ uint32_t vm;
+ unsigned int exec_queue;
+ uint32_t bo;
+ size_t bo_size;
+ struct xe_spin *spin;
+ uint64_t spin_addr;
+ struct drm_xe_sync sync = {
+ .handle = syncobj_create(fd, 0),
+ .flags = DRM_XE_SYNC_SYNCOBJ | DRM_XE_SYNC_SIGNAL,
+ };
+ struct drm_xe_exec exec = {
+ .num_batch_buffer = 1,
+ .num_syncs = 1,
+ .syncs = to_user_pointer(&sync),
+ };
+ struct timespec tv;
+ const uint64_t duration_ns = NSEC_PER_SEC / 10; /* 100ms */
+ double elapsed_ms;
+ int i;
+ igt_stats_t stats;
+
+ vm = xe_vm_create(fd, 0, 0);
+ exec_queue = xe_exec_queue_create_class(fd, vm, DRM_XE_ENGINE_CLASS_COPY);
+ ahnd = intel_allocator_open(fd, 0, INTEL_ALLOCATOR_RELOC);
+ bo_size = ALIGN(sizeof(*spin) + xe_cs_prefetch_size(fd), xe_get_default_alignment(fd));
+ bo = xe_bo_create(fd, 0, vm, bo_size);
+ spin = xe_bo_map(fd, bo, bo_size);
+ spin_addr = intel_allocator_alloc_with_strategy(ahnd, bo, bo_size, 0, ALLOC_STRATEGY_LOW_TO_HIGH);
+ xe_vm_bind_sync(fd, vm, bo, 0, spin_addr, bo_size);
+ xe_spin_init_opts(spin, .addr = spin_addr,
+ .preempt = true,
+ .ctx_ticks = duration_to_ctx_ticks(fd, 0, duration_ns));
+ exec.address = spin_addr;
+ exec.exec_queue_id = exec_queue;
+
+#define NSAMPLES 5
+ igt_stats_init_with_size(&stats, NSAMPLES);
+ for (i = 0; i < NSAMPLES; ++i) {
+ igt_gettime(&tv);
+ xe_exec(fd, &exec);
+ xe_spin_wait_started(spin);
+ igt_assert(syncobj_wait(fd, &sync.handle, 1, INT64_MAX, 0, NULL));
+ igt_stats_push_float(&stats, igt_nsec_elapsed(&tv) * 1e-6);
+ syncobj_reset(fd, &sync.handle, 1);
+ igt_debug("i=%d %.2fms\n", i, stats.values_f[i]);
+ }
+ elapsed_ms = igt_stats_get_median(&stats);
+ igt_info("%.0fms spin took %.2fms (median)\n", duration_ns * 1e-6, elapsed_ms);
+ igt_assert(elapsed_ms < duration_ns * 1.5e-6 && elapsed_ms > duration_ns * 0.5e-6);
+
+ xe_vm_unbind_sync(fd, vm, 0, spin_addr, bo_size);
+ syncobj_destroy(fd, sync.handle);
+ gem_munmap(spin, bo_size);
+ gem_close(fd, bo);
+ xe_exec_queue_destroy(fd, exec_queue);
+ xe_vm_destroy(fd, vm);
+ put_ahnd(ahnd);
+}
+
igt_main
{
struct drm_xe_engine_class_instance *hwe;
@@ -163,6 +232,9 @@ igt_main
spin_all(fd, gt, class);
}
+ igt_subtest("spin-fixed-duration")
+ xe_spin_fixed_duration(fd);
+
igt_fixture
drm_close_driver(fd);
}
--
2.30.2
next prev parent reply other threads:[~2023-09-05 15:36 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-05 15:02 [igt-dev] [PATCH i-g-t v3 0/3] lib/xe_spin: introduced fixed duration xe_spin Marcin Bernatowicz
2023-09-05 15:02 ` [igt-dev] [PATCH i-g-t v3 1/3] lib/xe_spin: xe_spin_opts for xe_spin initialization Marcin Bernatowicz
2023-09-08 8:52 ` Zbigniew Kempczyński
2023-09-05 15:02 ` [igt-dev] [PATCH i-g-t v3 2/3] lib/xe_spin: fixed duration xe_spin capability Marcin Bernatowicz
2023-09-08 10:19 ` Zbigniew Kempczyński
2023-09-08 12:14 ` Kamil Konieczny
2023-09-08 13:22 ` Bernatowicz, Marcin
2023-09-05 15:02 ` Marcin Bernatowicz [this message]
2023-09-08 10:24 ` [igt-dev] [PATCH i-g-t v3 3/3] tests/xe_spin_batch: spin-fixed-duration Zbigniew Kempczyński
2023-09-08 13:19 ` Bernatowicz, Marcin
2023-09-05 18:58 ` [igt-dev] ✓ Fi.CI.BAT: success for lib/xe_spin: introduced fixed duration xe_spin (rev2) Patchwork
2023-09-05 21:21 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
2023-09-06 6:43 ` Bernatowicz, Marcin
-- strict thread matches above, loose matches on Subject: below --
2023-08-18 10:21 [igt-dev] [PATCH i-g-t v2 0/2] lib/xe_spin: introduced fixed duration xe_spin Marcin Bernatowicz
2023-09-05 14:23 ` [igt-dev] [PATCH i-g-t v3 0/3] " Marcin Bernatowicz
2023-09-05 14:23 ` [igt-dev] [PATCH i-g-t v3 3/3] tests/xe_spin_batch: spin-fixed-duration Marcin Bernatowicz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230905150225.2029554-4-marcin.bernatowicz@linux.intel.com \
--to=marcin.bernatowicz@linux.intel.com \
--cc=igt-dev@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox