Re: [igt-dev] [PATCH i-g-t v3 6/7] scripts/test_list.py: move "FULL" testlist to config file

[Mauro Carvalho Chehab <mauro.chehab@linux.intel.com>]

On Thu, 7 Sep 2023 15:09:16 +0200
Kamil Konieczny <kamil.konieczny@linux.intel.com> wrote:

> Hi Mauro,
> On 2023-09-07 at 12:17:37 +0200, Mauro Carvalho Chehab wrote:
> > From: Mauro Carvalho Chehab <mchehab@kernel.org>
> > 
> > Don't assume that the default testlist is "FULL". Instead, read
> > it from the configuration file.
> > 
> > Signed-off-by: Mauro Carvalho Chehab <mchehab@kernel.org>
> > ---
> >  scripts/test_list.py             | 6 ++++--
> >  tests/intel/kms_test_config.json | 1 +
> >  tests/intel/xe_test_config.json  | 1 +
> >  3 files changed, 6 insertions(+), 2 deletions(-)
> > 
> > diff --git a/scripts/test_list.py b/scripts/test_list.py
> > index c1518a904baf..bd03fcfc7efd 100644
> > --- a/scripts/test_list.py
> > +++ b/scripts/test_list.py
> > @@ -484,6 +484,8 @@ class TestList:
> >              if "testlist" not in self.props[field]["_properties_"]:
> >                  continue
> >  
> > +            default_value = self.props[field]["_properties_"].get("default-testlist")
> > +
> >              testname = subtest_dict["_summary_"]
> >  
> >              value = subtest_dict.get(field)
> > @@ -510,8 +512,8 @@ class TestList:
> >                                  set_full_if_empty = False
> >                              values.discard(deleted_names)
> >  
> > -            if set_full_if_empty and not values:
> > -                values = set(["FULL"])
> > +            if default_value and set_full_if_empty and not values:
> > +                values = set([default_value])  
> 
> What if someone forget to add default? imho here this should be:
> 
>                if set_full_if_empty and not values:
>                    if default_value:
>                        values = set([default_value])
>                    else
>                        values = set(["FULL"])

No, the intent here is to let values be empty if there is no default.

I mean, when this is used for "Run type", a default testlist called
"FULL" makes sense, but if this is used for some other field, the
default may be to leave the field empty.

Regards,
Mauro