Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Mauro Carvalho Chehab <mauro.chehab@linux.intel.com>
To: igt-dev@lists.freedesktop.org
Subject: [igt-dev] [PATCH i-g-t] scripts/test_list.py: check key before expanding fields
Date: Tue, 12 Sep 2023 11:50:29 +0200	[thread overview]
Message-ID: <20230912095029.84964-1-mauro.chehab@linux.intel.com> (raw)

From: Mauro Carvalho Chehab <mchehab@kernel.org>

The logic used by doc_to_xls.py expands a field that may or may
not exist, depending on the test set.

Check it to avoig errors like:

  File "/home/mchehab/devel/upstream/igt-gpu-tools/scripts/test_list.py", line 819, in get_spreadsheet
    for field in sorted(list(expand_field_name[item]), key=str.lower):
                             ~~~~~~~~~~~~~~~~~^^^^^^
  KeyError: 'GPU excluded platform'

Signed-off-by: Mauro Carvalho Chehab <mchehab@kernel.org>
---
 scripts/test_list.py | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/scripts/test_list.py b/scripts/test_list.py
index 74abdc5ebe65..fdc3c1998d23 100644
--- a/scripts/test_list.py
+++ b/scripts/test_list.py
@@ -816,6 +816,9 @@ class TestList:
         for item in sorted(expand_fields.keys(), key=str.lower):
             prefix = expand_fields[item]
 
+            if item not in expand_field_name:
+                continue
+
             for field in sorted(list(expand_field_name[item]), key=str.lower):
                 row = 0
                 sheet[row].append(prefix + field)
-- 
2.41.0

             reply	other threads:[~2023-09-12  9:50 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-12  9:50 Mauro Carvalho Chehab [this message]
2023-09-12 13:31 ` [igt-dev] ✗ Fi.CI.BAT: failure for scripts/test_list.py: check key before expanding fields Patchwork
2023-09-12 13:48 ` [igt-dev] [PATCH i-g-t] " Kamil Konieczny
2023-09-12 13:54 ` [igt-dev] ✓ CI.xeBAT: success for " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230912095029.84964-1-mauro.chehab@linux.intel.com \
    --to=mauro.chehab@linux.intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox