From: Nirmoy Das <nirmoy.das@intel.com>
To: igt-dev@lists.freedesktop.org
Cc: andi.shyti@intel.com
Subject: [igt-dev] [PATCH igt-dii-client 3/3] tests/intel/gem_ctx_schedule: Skip some test on MTL
Date: Tue, 12 Sep 2023 14:46:13 +0200 [thread overview]
Message-ID: <20230912124613.27850-4-nirmoy.das@intel.com> (raw)
In-Reply-To: <20230912124613.27850-1-nirmoy.das@intel.com>
We do GGTT update on MTL using bcs engine, blocking that would
will fail the test so skip such subtests on bcs engine for MTL.
Signed-off-by: Nirmoy Das <nirmoy.das@intel.com>
---
tests/intel/gem_exec_schedule.c | 39 ++++++++++++++++++++++-----------
1 file changed, 26 insertions(+), 13 deletions(-)
diff --git a/tests/intel/gem_exec_schedule.c b/tests/intel/gem_exec_schedule.c
index c94988d368..288503c707 100644
--- a/tests/intel/gem_exec_schedule.c
+++ b/tests/intel/gem_exec_schedule.c
@@ -3503,21 +3503,27 @@ igt_main
const struct intel_execution_engine2 *e;
test_each_engine_store("fifo", fd, ctx, e)
- fifo(fd, ctx, e->flags);
+ if (!(gem_has_ggtt_bind(fd) && e->class == I915_ENGINE_CLASS_COPY))
+ fifo(fd, ctx, e->flags);
test_each_engine_store("implicit-read-write", fd, ctx, e)
- implicit_rw(fd, ctx, e->flags, READ_WRITE);
+ if (!(gem_has_ggtt_bind(fd) && e->class == I915_ENGINE_CLASS_COPY))
+ implicit_rw(fd, ctx, e->flags, READ_WRITE);
test_each_engine_store("implicit-write-read", fd, ctx, e)
- implicit_rw(fd, ctx, e->flags, WRITE_READ);
+ if (!(gem_has_ggtt_bind(fd) && e->class == I915_ENGINE_CLASS_COPY))
+ implicit_rw(fd, ctx, e->flags, WRITE_READ);
test_each_engine_store("implicit-boths", fd, ctx, e)
- implicit_rw(fd, ctx, e->flags, READ_WRITE | WRITE_READ);
+ if (!(gem_has_ggtt_bind(fd) && e->class == I915_ENGINE_CLASS_COPY))
+ implicit_rw(fd, ctx, e->flags, READ_WRITE | WRITE_READ);
test_each_engine_store("independent", fd, ctx, e)
- independent(fd, ctx, e->flags, 0);
+ if (!(gem_has_ggtt_bind(fd) && e->class == I915_ENGINE_CLASS_COPY))
+ independent(fd, ctx, e->flags, 0);
test_each_engine_store("u-independent", fd, ctx, e)
- independent(fd, ctx, e->flags, IGT_SPIN_USERPTR);
+ if (!(gem_has_ggtt_bind(fd) && e->class == I915_ENGINE_CLASS_COPY))
+ independent(fd, ctx, e->flags, IGT_SPIN_USERPTR);
}
igt_subtest_group {
@@ -3613,13 +3619,16 @@ igt_main
smoketest(fd, &ctx->cfg, ALL_ENGINES, 30);
test_each_engine_store("in-order", fd, ctx, e)
- reorder(fd, &ctx->cfg, e->flags, EQUAL);
+ if (!(gem_has_ggtt_bind(fd) && e->class == I915_ENGINE_CLASS_COPY))
+ reorder(fd, &ctx->cfg, e->flags, EQUAL);
test_each_engine_store("out-order", fd, ctx, e)
- reorder(fd, &ctx->cfg, e->flags, 0);
+ if (!(gem_has_ggtt_bind(fd) && e->class == I915_ENGINE_CLASS_COPY))
+ reorder(fd, &ctx->cfg, e->flags, 0);
test_each_engine_store("promotion", fd, ctx, e)
- promotion(fd, &ctx->cfg, e->flags);
+ if (!(gem_has_ggtt_bind(fd) && e->class == I915_ENGINE_CLASS_COPY))
+ promotion(fd, &ctx->cfg, e->flags);
igt_subtest_group {
igt_fixture {
@@ -3686,7 +3695,8 @@ igt_main
}
test_each_engine_store("noreorder", fd, ctx, e)
- noreorder(fd, &ctx->cfg, e->flags, 0, 0);
+ if (!(gem_has_ggtt_bind(fd) && e->class == I915_ENGINE_CLASS_COPY))
+ noreorder(fd, &ctx->cfg, e->flags, 0, 0);
test_each_engine_store("noreorder-priority", fd, ctx, e) {
igt_require(gem_scheduler_enabled(fd));
@@ -3695,7 +3705,8 @@ igt_main
test_each_engine_store("noreorder-corked", fd, ctx, e) {
igt_require(gem_scheduler_enabled(fd));
- noreorder(fd, &ctx->cfg, e->flags, MAX_PRIO, CORKED);
+ if (!(gem_has_ggtt_bind(fd) && e->class == I915_ENGINE_CLASS_COPY))
+ noreorder(fd, &ctx->cfg, e->flags, MAX_PRIO, CORKED);
}
test_each_engine_store("deep", fd, ctx, e)
@@ -3736,10 +3747,12 @@ igt_main
test_pi_userfault(fd, &ctx->cfg, e->flags);
test_each_engine("pi-distinct-iova", fd, ctx, e)
- test_pi_iova(fd, &ctx->cfg, e->flags, 0);
+ if (!(gem_has_ggtt_bind(fd) && e->class == I915_ENGINE_CLASS_COPY))
+ test_pi_iova(fd, &ctx->cfg, e->flags, 0);
test_each_engine("pi-shared-iova", fd, ctx, e)
- test_pi_iova(fd, &ctx->cfg, e->flags, SHARED);
+ if (!(gem_has_ggtt_bind(fd) && e->class == I915_ENGINE_CLASS_COPY))
+ test_pi_iova(fd, &ctx->cfg, e->flags, SHARED);
}
igt_subtest_group {
--
2.41.0
next prev parent reply other threads:[~2023-09-12 12:46 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-12 12:46 [igt-dev] [PATCH igt-dii-client 0/3] Ignore some tests on MTL which Nirmoy Das
2023-09-12 12:46 ` [igt-dev] [PATCH igt-dii-client 1/3] lib/igt_gt: Add a method to detect ggtt bind Nirmoy Das
2023-09-12 12:46 ` [igt-dev] [PATCH igt-dii-client 2/3] tests/intel/gem_ctx_shared: Skip some test on MTL Nirmoy Das
2023-09-12 12:46 ` Nirmoy Das [this message]
2023-09-12 15:18 ` [igt-dev] ✓ Fi.CI.BAT: success for Ignore some tests on MTL which Patchwork
2023-09-12 16:45 ` [igt-dev] ✓ CI.xeBAT: " Patchwork
2023-09-12 16:50 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230912124613.27850-4-nirmoy.das@intel.com \
--to=nirmoy.das@intel.com \
--cc=andi.shyti@intel.com \
--cc=igt-dev@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox