Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Swati Sharma <swati2.sharma@intel.com>
To: igt-dev@lists.freedesktop.org
Subject: [igt-dev] [v9 4/4] tests/intel/kms_dsc: add test to validate fractional bpp with input bpc
Date: Tue, 12 Sep 2023 21:52:19 +0530	[thread overview]
Message-ID: <20230912162219.1316473-5-swati2.sharma@intel.com> (raw)
In-Reply-To: <20230912162219.1316473-1-swati2.sharma@intel.com>

New subtest is added to validate fractional bpp with different
input bpc.

v2: -rebase
v3: -rebase

Signed-off-by: Swati Sharma <swati2.sharma@intel.com>
Reviewed-by: Ankit Nautiyal <ankit.k.nautiyal@intel.com>
---
 tests/intel/kms_dsc.c | 31 +++++++++++--------------------
 1 file changed, 11 insertions(+), 20 deletions(-)

diff --git a/tests/intel/kms_dsc.c b/tests/intel/kms_dsc.c
index 43c1dba76..86c609f61 100644
--- a/tests/intel/kms_dsc.c
+++ b/tests/intel/kms_dsc.c
@@ -56,6 +56,7 @@
  * @with-output-formats:          DSC and output format
  * @with-output-formats-with-bpc: DSC and output format with certain input BPC for the connector
  * @fractional-bpp:               DSC and fractional bpp with default parameters
+ * @fractional-bpp-with-bpc:      DSC and fractional bpp with certain input BPC for the connector
  */
 
 IGT_TEST_DESCRIPTION("Test to validate display stream compression");
@@ -69,26 +70,6 @@ IGT_TEST_DESCRIPTION("Test to validate display stream compression");
 #define TEST_DSC_OUTPUT_FORMAT	(1<<2)
 #define TEST_DSC_FRACTIONAL_BPP (1<<3)
 
-/*
- * Starting from gen11, intel driver supports DSC1.1. For validating
- * DSC, the first step is to verify if the sink supports DSC.
- * If the sink does support DSC, we will validate different
- * scenarios by forcing dsc. Outline of the tests is as follows:
- * (i) basic modeset (ii) input bpc (iii) pixel formats
- * (iv) output formats (v) fractional bpp
- * In the basic subtest, we perform modeset with default parameters.
- * Input bpc and pixel formats subtests, we perform modeset
- * with different input bpc (12/10/8) and pixel formats (YUV/RGB),
- * respectively. From MTL+, we can verify DSC YCBCR420 output format.
- * The tests are executed with the RGB444 output format by default.
- * However, in the output-format subtest, we verify different
- * output formats (RGB/YCBCR444/YCBCR420). Also, test is added to
- * validate output formats with different input bpc (12/10/8).
- * Lastly, fractional bpp is tested with default parameters.
- * In this, driver will ignore integer compressed bpp value and
- * will do modeset with fractional bpp only.
- */
-
 typedef struct {
 	int drm_fd;
 	uint32_t devid;
@@ -432,6 +413,16 @@ igt_main_args("l", NULL, help_str, opt_handler, &data)
 				 DEFAULT_BPC, DRM_FORMAT_XRGB8888,
 				 DSC_FORMAT_RGB);
 
+	igt_describe("Tests fractional compressed bpp functionality if supported "
+		     "by a connector by forcing fractional_bpp on all connectors that support it "
+		     "with certain input BPC for the connector.");
+	igt_subtest_with_dynamic("dsc-fractional-bpp-with-bpc") {
+		for (int j = 0; j < ARRAY_SIZE(bpc_list); j++)
+			test_dsc(&data, TEST_DSC_FRACTIONAL_BPP | TEST_DSC_BPC,
+				 bpc_list[j], DRM_FORMAT_XRGB8888,
+				 DSC_FORMAT_RGB);
+	}
+
 	igt_fixture {
 		igt_display_fini(&data.display);
 		drm_close_driver(data.drm_fd);
-- 
2.25.1

  parent reply	other threads:[~2023-09-12 16:24 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-12 16:22 [igt-dev] [v9 0/4] DSC Fractional BPP Val Support Swati Sharma
2023-09-12 16:22 ` [igt-dev] [v9 1/4] lib/dsc: fix documentation style Swati Sharma
2023-09-13 11:26   ` Modem, Bhanuprakash
2023-09-12 16:22 ` [igt-dev] [v9 2/4] lib/dsc: add helpers for vdsc fractional bpp debugfs entry Swati Sharma
2023-09-12 16:22 ` [igt-dev] [v9 3/4] tests/intel/kms_dsc: enable validation for vdsc fractional bpp Swati Sharma
2023-09-12 16:22 ` Swati Sharma [this message]
2023-09-12 17:10 ` [igt-dev] ✗ Fi.CI.BAT: failure for DSC Fractional BPP Val Support (rev11) Patchwork
2023-09-12 17:50 ` [igt-dev] ✓ CI.xeBAT: success " Patchwork
2023-09-13 11:08 ` [igt-dev] ✓ Fi.CI.BAT: " Patchwork
2023-09-13 12:30 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230912162219.1316473-5-swati2.sharma@intel.com \
    --to=swati2.sharma@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox