From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Fri, 15 Sep 2023 12:36:26 +0200 From: Mauro Carvalho Chehab To: Janusz Krzysztofik Message-ID: <20230915123626.2b46d1e6@maurocar-mobl2> In-Reply-To: <20230908123233.137134-21-janusz.krzysztofik@linux.intel.com> References: <20230908123233.137134-19-janusz.krzysztofik@linux.intel.com> <20230908123233.137134-21-janusz.krzysztofik@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [igt-dev] [PATCH i-g-t v2 02/17] lib/kunit: Stop loading kunit module explicitly List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: igt-dev@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, Isabella Basso , intel-xe@lists.freedesktop.org Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" List-ID: On Fri, 8 Sep 2023 14:32:36 +0200 Janusz Krzysztofik wrote: > Since kmod functions we use for module loading can process module > dependencies, there is no need to load the "kunit" module explicitly > before loading a kunit test module. For the same reason we already don't > unload the "kunit" module explicitly on cleanup. Drop the unnecessary > operation. > > Signed-off-by: Janusz Krzysztofik LGTM. Acked-by: Mauro Carvalho Chehab > --- > lib/igt_kmod.c | 6 ------ > 1 file changed, 6 deletions(-) > > diff --git a/lib/igt_kmod.c b/lib/igt_kmod.c > index 97667a896f..faf31afabc 100644 > --- a/lib/igt_kmod.c > +++ b/lib/igt_kmod.c > @@ -789,12 +789,6 @@ static void __igt_kunit(const char *module_name, const char *opts) > goto unload; > } > > - /* The KUnit module is required for running any KUnit tests */ > - ret = igt_kmod_load("kunit", NULL); > - if (ret) { > - skip = ret; > - goto unload; > - } > ret = kmod_module_new_from_name(kmod_ctx(), "kunit", &kunit_kmod); > if (ret) { > igt_warn("Unable to load KUnit\n");