Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Nirmoy Das <nirmoy.das@intel.com>
To: igt-dev@lists.freedesktop.org
Cc: andi.shyti@intel.com, oak.zeng@intel.com,
	Nirmoy Das <nirmoy.das@intel.com>
Subject: [igt-dev] [PATCH i-g-t 1/4] lib/igt_gt: Add gem_engine_can_block_ggtt_binder
Date: Mon, 18 Sep 2023 18:47:44 +0200	[thread overview]
Message-ID: <20230918164747.30171-2-nirmoy.das@intel.com> (raw)
In-Reply-To: <20230918164747.30171-1-nirmoy.das@intel.com>

On MTL GGTT updates happens through MI_UPDATE_GGTT command.
Add a method to detect if a engine can block ggtt binder.

Signed-off-by: Nirmoy Das <nirmoy.das@intel.com>
Reviewed-by: Kamil Konieczny <kamil.konieczny@linux.intel.com>
---
 lib/igt_gt.c | 15 +++++++++++++++
 lib/igt_gt.h |  2 ++
 2 files changed, 17 insertions(+)

diff --git a/lib/igt_gt.c b/lib/igt_gt.c
index a24a566c7..aa5e75b07 100644
--- a/lib/igt_gt.c
+++ b/lib/igt_gt.c
@@ -659,3 +659,18 @@ int gem_execbuf_flags_to_engine_class(unsigned int flags)
 		igt_assert(0);
 	}
 }
+
+/**
+ * gem_engine_can_block_ggtt_binder:
+ * @fd: open i915 drm file descriptor
+ * @engine: engine to be assessed
+ *
+ * Detect if the platform needs blitter based GGTT
+ * updates.
+ */
+bool gem_engine_can_block_ggtt_binder(int fd,
+		const struct intel_execution_engine2 *engine)
+{
+	return IS_METEORLAKE(intel_get_drm_devid(fd)) &&
+		engine->class == I915_ENGINE_CLASS_COPY;
+}
diff --git a/lib/igt_gt.h b/lib/igt_gt.h
index 3d10349e4..d0c5510b1 100644
--- a/lib/igt_gt.h
+++ b/lib/igt_gt.h
@@ -83,5 +83,7 @@ extern const struct intel_execution_engine2 {
 } intel_execution_engines2[];
 
 int gem_execbuf_flags_to_engine_class(unsigned int flags);
+bool gem_engine_can_block_ggtt_binder(int fd,
+		const struct intel_execution_engine2 *engine);
 
 #endif /* IGT_GT_H */
-- 
2.41.0

  reply	other threads:[~2023-09-18 16:48 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-18 16:47 [igt-dev] [PATCH i-g-t 0/4] Ignore some tests on MTL which Nirmoy Das
2023-09-18 16:47 ` Nirmoy Das [this message]
2023-09-18 16:47 ` [igt-dev] [PATCH i-g-t 2/4] tests/intel/gem_ctx_shared: Skip some test on MTL Nirmoy Das
2023-09-18 16:47 ` [igt-dev] [PATCH i-g-t 3/4] tests/intel/gem_ctx_schedule: " Nirmoy Das
2023-09-18 17:00   ` Nirmoy Das
2023-09-19 10:20     ` Kamil Konieczny
2023-09-19 14:17       ` Nirmoy Das
2023-09-20  7:54         ` Kamil Konieczny
2023-09-18 16:47 ` [igt-dev] [PATCH i-g-t 4/4] tests/intel/gem_spin_batch: " Nirmoy Das
2023-09-20  7:51   ` Kamil Konieczny
2023-09-18 21:40 ` [igt-dev] ✓ Fi.CI.BAT: success for Ignore some tests on MTL which (rev4) Patchwork
2023-09-18 22:44 ` [igt-dev] ✓ CI.xeBAT: " Patchwork
2023-09-20  0:17 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
2023-09-22 10:29   ` Nirmoy Das
2023-09-20  8:57 ` [igt-dev] [PATCH i-g-t 0/4] Ignore some tests on MTL which Andi Shyti
2023-09-22 11:25 ` [igt-dev] ✗ Fi.CI.BAT: failure for Ignore some tests on MTL which (rev5) Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230918164747.30171-2-nirmoy.das@intel.com \
    --to=nirmoy.das@intel.com \
    --cc=andi.shyti@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=oak.zeng@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox