From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: From: Rodrigo Vivi To: , Date: Tue, 19 Sep 2023 10:19:50 -0400 Message-ID: <20230919142000.91363-8-rodrigo.vivi@intel.com> In-Reply-To: <20230919142000.91363-1-rodrigo.vivi@intel.com> References: <20230919142000.91363-1-rodrigo.vivi@intel.com> Content-Transfer-Encoding: 8bit Content-Type: text/plain MIME-Version: 1.0 Subject: [igt-dev] [PATCH i-g-t 07/16] xe: Update uAPI and remove XE_EXEC_QUEUE_SET_PROPERTY_COMPUTE_MODE List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Rodrigo Vivi Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" List-ID: From: Matthew Brost XE_EXEC_QUEUE_SET_PROPERTY_COMPUTE_MODE has been removed from uAPI, remove all references in Xe tests. Align with commits ("drm/xe: Remove XE_EXEC_QUEUE_SET_PROPERTY_COMPUTE_MODE from uAPI") and ("drm/xe: Deprecate XE_EXEC_QUEUE_SET_PROPERTY_COMPUTE_MODE implementation") Signed-off-by: Matthew Brost Reviewed-by: Niranjana Vishwanathapura Signed-off-by: Francois Dugast Signed-off-by: Rodrigo Vivi [Rodrigo updated header with built version from make header_install] [Rodrigo added the commit subjects of the kernel uapi changes] --- include/drm-uapi/xe_drm.h | 21 +++++++-------------- tests/intel/xe_evict.c | 14 +++----------- tests/intel/xe_exec_balancer.c | 8 +------- tests/intel/xe_exec_compute_mode.c | 20 ++------------------ tests/intel/xe_exec_reset.c | 10 ++-------- tests/intel/xe_exec_threads.c | 13 ++----------- tests/intel/xe_noexec_ping_pong.c | 10 +--------- 7 files changed, 18 insertions(+), 78 deletions(-) diff --git a/include/drm-uapi/xe_drm.h b/include/drm-uapi/xe_drm.h index 1d869f5e8..a9060bcf8 100644 --- a/include/drm-uapi/xe_drm.h +++ b/include/drm-uapi/xe_drm.h @@ -784,21 +784,14 @@ struct drm_xe_exec_queue_set_property { /** @exec_queue_id: Exec queue ID */ __u32 exec_queue_id; -#define XE_EXEC_QUEUE_SET_PROPERTY_PRIORITY 0 +#define XE_EXEC_QUEUE_SET_PROPERTY_PRIORITY 0 #define XE_EXEC_QUEUE_SET_PROPERTY_TIMESLICE 1 #define XE_EXEC_QUEUE_SET_PROPERTY_PREEMPTION_TIMEOUT 2 - /* - * Long running or ULLS engine mode. DMA fences not allowed in this - * mode. Must match the value of DRM_XE_VM_CREATE_COMPUTE_MODE, serves - * as a sanity check the UMD knows what it is doing. Can only be set at - * engine create time. - */ -#define XE_EXEC_QUEUE_SET_PROPERTY_COMPUTE_MODE 3 -#define XE_EXEC_QUEUE_SET_PROPERTY_PERSISTENCE 4 -#define XE_EXEC_QUEUE_SET_PROPERTY_JOB_TIMEOUT 5 -#define XE_EXEC_QUEUE_SET_PROPERTY_ACC_TRIGGER 6 -#define XE_EXEC_QUEUE_SET_PROPERTY_ACC_NOTIFY 7 -#define XE_EXEC_QUEUE_SET_PROPERTY_ACC_GRANULARITY 8 +#define XE_EXEC_QUEUE_SET_PROPERTY_PERSISTENCE 3 +#define XE_EXEC_QUEUE_SET_PROPERTY_JOB_TIMEOUT 4 +#define XE_EXEC_QUEUE_SET_PROPERTY_ACC_TRIGGER 5 +#define XE_EXEC_QUEUE_SET_PROPERTY_ACC_NOTIFY 6 +#define XE_EXEC_QUEUE_SET_PROPERTY_ACC_GRANULARITY 7 /** @property: property to set */ __u32 property; @@ -1092,7 +1085,7 @@ struct drm_xe_vm_madvise { }; /** - * XE PMU event config IDs + * DOC: XE PMU event config IDs * * Check 'man perf_event_open' to use these ID's in 'struct perf_event_attr' * as part of perf_event_open syscall to read a particular event. diff --git a/tests/intel/xe_evict.c b/tests/intel/xe_evict.c index 5b64e56b4..5d8981f8d 100644 --- a/tests/intel/xe_evict.c +++ b/tests/intel/xe_evict.c @@ -252,19 +252,11 @@ test_evict_cm(int fd, struct drm_xe_engine_class_instance *eci, } for (i = 0; i < n_exec_queues; i++) { - struct drm_xe_ext_exec_queue_set_property ext = { - .base.next_extension = 0, - .base.name = XE_EXEC_QUEUE_EXTENSION_SET_PROPERTY, - .property = XE_EXEC_QUEUE_SET_PROPERTY_COMPUTE_MODE, - .value = 1, - }; - if (flags & MULTI_VM) - exec_queues[i] = xe_exec_queue_create(fd, i & 1 ? vm2 : vm, eci, - to_user_pointer(&ext)); + exec_queues[i] = xe_exec_queue_create(fd, i & 1 ? vm2 : + vm, eci, 0); else - exec_queues[i] = xe_exec_queue_create(fd, vm, eci, - to_user_pointer(&ext)); + exec_queues[i] = xe_exec_queue_create(fd, vm, eci, 0); } for (i = 0; i < n_execs; i++) { diff --git a/tests/intel/xe_exec_balancer.c b/tests/intel/xe_exec_balancer.c index a4a438db7..f4f5440f4 100644 --- a/tests/intel/xe_exec_balancer.c +++ b/tests/intel/xe_exec_balancer.c @@ -458,18 +458,12 @@ test_cm(int fd, int gt, int class, int n_exec_queues, int n_execs, memset(data, 0, bo_size); for (i = 0; i < n_exec_queues; i++) { - struct drm_xe_ext_exec_queue_set_property ext = { - .base.next_extension = 0, - .base.name = XE_EXEC_QUEUE_EXTENSION_SET_PROPERTY, - .property = XE_EXEC_QUEUE_SET_PROPERTY_COMPUTE_MODE, - .value = 1, - }; struct drm_xe_exec_queue_create create = { .vm_id = vm, .width = flags & PARALLEL ? num_placements : 1, .num_placements = flags & PARALLEL ? 1 : num_placements, .instances = to_user_pointer(eci), - .extensions = to_user_pointer(&ext), + .extensions = 0, }; igt_assert_eq(igt_ioctl(fd, DRM_IOCTL_XE_EXEC_QUEUE_CREATE, diff --git a/tests/intel/xe_exec_compute_mode.c b/tests/intel/xe_exec_compute_mode.c index 6d1084727..02e7ef201 100644 --- a/tests/intel/xe_exec_compute_mode.c +++ b/tests/intel/xe_exec_compute_mode.c @@ -120,15 +120,7 @@ test_exec(int fd, struct drm_xe_engine_class_instance *eci, xe_get_default_alignment(fd)); for (i = 0; (flags & EXEC_QUEUE_EARLY) && i < n_exec_queues; i++) { - struct drm_xe_ext_exec_queue_set_property ext = { - .base.next_extension = 0, - .base.name = XE_EXEC_QUEUE_EXTENSION_SET_PROPERTY, - .property = XE_EXEC_QUEUE_SET_PROPERTY_COMPUTE_MODE, - .value = 1, - }; - - exec_queues[i] = xe_exec_queue_create(fd, vm, eci, - to_user_pointer(&ext)); + exec_queues[i] = xe_exec_queue_create(fd, vm, eci, 0); if (flags & BIND_EXECQUEUE) bind_exec_queues[i] = xe_bind_exec_queue_create(fd, vm, 0); @@ -156,15 +148,7 @@ test_exec(int fd, struct drm_xe_engine_class_instance *eci, memset(data, 0, bo_size); for (i = 0; !(flags & EXEC_QUEUE_EARLY) && i < n_exec_queues; i++) { - struct drm_xe_ext_exec_queue_set_property ext = { - .base.next_extension = 0, - .base.name = XE_EXEC_QUEUE_EXTENSION_SET_PROPERTY, - .property = XE_EXEC_QUEUE_SET_PROPERTY_COMPUTE_MODE, - .value = 1, - }; - - exec_queues[i] = xe_exec_queue_create(fd, vm, eci, - to_user_pointer(&ext)); + exec_queues[i] = xe_exec_queue_create(fd, vm, eci, 0); if (flags & BIND_EXECQUEUE) bind_exec_queues[i] = xe_bind_exec_queue_create(fd, vm, 0); diff --git a/tests/intel/xe_exec_reset.c b/tests/intel/xe_exec_reset.c index 6e3f0aa4b..68e17cc98 100644 --- a/tests/intel/xe_exec_reset.c +++ b/tests/intel/xe_exec_reset.c @@ -540,14 +540,8 @@ test_compute_mode(int fd, struct drm_xe_engine_class_instance *eci, memset(data, 0, bo_size); for (i = 0; i < n_exec_queues; i++) { - struct drm_xe_ext_exec_queue_set_property compute = { - .base.next_extension = 0, - .base.name = XE_EXEC_QUEUE_EXTENSION_SET_PROPERTY, - .property = XE_EXEC_QUEUE_SET_PROPERTY_COMPUTE_MODE, - .value = 1, - }; struct drm_xe_ext_exec_queue_set_property preempt_timeout = { - .base.next_extension = to_user_pointer(&compute), + .base.next_extension = 0, .base.name = XE_EXEC_QUEUE_EXTENSION_SET_PROPERTY, .property = XE_EXEC_QUEUE_SET_PROPERTY_PREEMPTION_TIMEOUT, .value = 1000, @@ -557,7 +551,7 @@ test_compute_mode(int fd, struct drm_xe_engine_class_instance *eci, if (flags & EXEC_QUEUE_RESET) ext = to_user_pointer(&preempt_timeout); else - ext = to_user_pointer(&compute); + ext = 0; exec_queues[i] = xe_exec_queue_create(fd, vm, eci, ext); }; diff --git a/tests/intel/xe_exec_threads.c b/tests/intel/xe_exec_threads.c index d19708f80..306d8113d 100644 --- a/tests/intel/xe_exec_threads.c +++ b/tests/intel/xe_exec_threads.c @@ -313,17 +313,8 @@ test_compute_mode(int fd, uint32_t vm, uint64_t addr, uint64_t userptr, } memset(data, 0, bo_size); - for (i = 0; i < n_exec_queues; i++) { - struct drm_xe_ext_exec_queue_set_property ext = { - .base.next_extension = 0, - .base.name = XE_EXEC_QUEUE_EXTENSION_SET_PROPERTY, - .property = XE_EXEC_QUEUE_SET_PROPERTY_COMPUTE_MODE, - .value = 1, - }; - - exec_queues[i] = xe_exec_queue_create(fd, vm, eci, - to_user_pointer(&ext)); - }; + for (i = 0; i < n_exec_queues; i++) + exec_queues[i] = xe_exec_queue_create(fd, vm, eci, 0); pthread_barrier_wait(&barrier); diff --git a/tests/intel/xe_noexec_ping_pong.c b/tests/intel/xe_noexec_ping_pong.c index 3f486adf9..88b22ed11 100644 --- a/tests/intel/xe_noexec_ping_pong.c +++ b/tests/intel/xe_noexec_ping_pong.c @@ -64,13 +64,6 @@ static void test_ping_pong(int fd, struct drm_xe_engine_class_instance *eci) * stats. */ for (i = 0; i < NUM_VMS; ++i) { - struct drm_xe_ext_exec_queue_set_property ext = { - .base.next_extension = 0, - .base.name = XE_EXEC_QUEUE_EXTENSION_SET_PROPERTY, - .property = XE_EXEC_QUEUE_SET_PROPERTY_COMPUTE_MODE, - .value = 1, - }; - vm[i] = xe_vm_create(fd, DRM_XE_VM_CREATE_COMPUTE_MODE, 0); for (j = 0; j < NUM_BOS; ++j) { igt_debug("Creating bo size %lu for vm %u\n", @@ -82,8 +75,7 @@ static void test_ping_pong(int fd, struct drm_xe_engine_class_instance *eci) xe_vm_bind(fd, vm[i], bo[i][j], 0, 0x40000 + j*bo_size, bo_size, NULL, 0); } - exec_queues[i] = xe_exec_queue_create(fd, vm[i], eci, - to_user_pointer(&ext)); + exec_queues[i] = xe_exec_queue_create(fd, vm[i], eci, 0); } igt_info("Now sleeping for %ds.\n", SECONDS_TO_WAIT); -- 2.41.0