Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Nemesa Garg <nemesa.garg@intel.com>
To: igt-dev@lists.freedesktop.org
Cc: Nemesa Garg <nemesa.garg@intel.com>
Subject: [igt-dev] [PATCH i-g-t 1/2] tests/kms_rmfb: Add check for xe driver
Date: Tue, 26 Sep 2023 18:02:23 +0530	[thread overview]
Message-ID: <20230926123224.514543-2-nemesa.garg@intel.com> (raw)
In-Reply-To: <20230926123224.514543-1-nemesa.garg@intel.com>

As the xe check is missing the value of open_count
variable is not incrementing and because of this
during drm_close_driver operation based on open_count
value mutex is acquired and there is a callback to
lastclose function.

Closes: https://gitlab.freedesktop.org/drm/xe/kernel/-/issues/294
Signed-off-by: Nemesa Garg <nemesa.garg@intel.com>
---
 lib/drmtest.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/drmtest.c b/lib/drmtest.c
index e1da66c87..99b655680 100644
--- a/lib/drmtest.c
+++ b/lib/drmtest.c
@@ -649,7 +649,7 @@ int drm_open_driver(int chipset)
 	 * starting a test and we install an exit handler to wait until
 	 * idle before quitting.
 	 */
-	if (is_i915_device(fd)) {
+	if (is_i915_device(fd) || is_xe_device(fd)) {
 		if (__sync_fetch_and_add(&open_count, 1) == 0) {
 			__cancel_work_at_exit(fd);
 			at_exit_drm_fd = drm_reopen_driver(fd);
-- 
2.25.1

  reply	other threads:[~2023-09-26 12:35 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-26 12:32 [igt-dev] [PATCH i-g-t 0/2] tests/kms_rmfb: Add check for xe driver Nemesa Garg
2023-09-26 12:32 ` Nemesa Garg [this message]
2023-10-04 17:12   ` [igt-dev] [PATCH i-g-t 1/2] " Zbigniew Kempczyński
2023-09-26 12:32 ` [igt-dev] [PATCH i-g-t 2/2] HAX: Add rmfb test to ffb Nemesa Garg
2023-09-26 14:30 ` [igt-dev] ✗ Fi.CI.BAT: failure for tests/kms_rmfb: Add check for xe driver (rev2) Patchwork
2023-09-26 14:50 ` [igt-dev] ✓ CI.xeBAT: success " Patchwork
2023-09-27 10:04 ` [igt-dev] ✓ Fi.CI.BAT: " Patchwork
2023-09-27 18:58 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230926123224.514543-2-nemesa.garg@intel.com \
    --to=nemesa.garg@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox