From: Rob Clark <robdclark@gmail.com>
To: igt-dev@lists.freedesktop.org
Cc: Rob Clark <robdclark@chromium.org>,
Helen Koike <helen.koike@collabora.com>,
Emma Anholt <emma@anholt.net>
Subject: [igt-dev] [PATCH 1/3] lib/drmtest: Use module table for chipset_to_str()
Date: Tue, 26 Sep 2023 11:47:45 -0700 [thread overview]
Message-ID: <20230926184748.199187-1-robdclark@gmail.com> (raw)
From: Rob Clark <robdclark@chromium.org>
Use the existing table, so there is one fewer place to update to add
support for a new driver.
Signed-off-by: Rob Clark <robdclark@chromium.org>
---
lib/drmtest.c | 29 +++++------------------------
1 file changed, 5 insertions(+), 24 deletions(-)
diff --git a/lib/drmtest.c b/lib/drmtest.c
index e1da66c877e9..2cfa8a899d53 100644
--- a/lib/drmtest.c
+++ b/lib/drmtest.c
@@ -601,30 +601,11 @@ static void cancel_work_at_exit_render(int sig)
static const char *chipset_to_str(int chipset)
{
- switch (chipset) {
- case DRIVER_INTEL:
- return "intel";
- case DRIVER_V3D:
- return "v3d";
- case DRIVER_VC4:
- return "vc4";
- case DRIVER_VGEM:
- return "vgem";
- case DRIVER_AMDGPU:
- return "amdgpu";
- case DRIVER_PANFROST:
- return "panfrost";
- case DRIVER_MSM:
- return "msm";
- case DRIVER_XE:
- return "xe";
- case DRIVER_VMWGFX:
- return "vmwgfx";
- case DRIVER_ANY:
- return "any";
- default:
- return "other";
- }
+ for (const struct module *m = modules; m->module; m++)
+ if (m->bit == chipset)
+ return m->module;
+
+ return (chipset == DRIVER_ANY) ? "any" : "other";
}
/**
--
2.41.0
next reply other threads:[~2023-09-26 18:47 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-26 18:47 Rob Clark [this message]
2023-09-26 18:47 ` [igt-dev] [PATCH 2/3] lib/drmtest: Add drm_find_chipset() Rob Clark
2023-09-27 14:20 ` Zbigniew Kempczyński
2023-09-27 17:41 ` Rob Clark
2023-09-27 16:21 ` Kamil Konieczny
2023-09-26 18:47 ` [igt-dev] [PATCH v3 3/3] core_getversion: Test for desired device Rob Clark
2023-09-27 14:26 ` Zbigniew Kempczyński
2023-09-27 17:42 ` Rob Clark
2023-09-27 16:42 ` Kamil Konieczny
2023-09-27 17:46 ` Rob Clark
2023-09-27 22:24 ` Helen Koike
2023-09-27 22:30 ` Rob Clark
2023-09-28 7:41 ` Kamil Konieczny
2023-09-26 19:39 ` [igt-dev] ✗ CI.xeBAT: failure for series starting with [1/3] lib/drmtest: Use module table for chipset_to_str() Patchwork
2023-09-26 19:46 ` [igt-dev] ✓ Fi.CI.BAT: success " Patchwork
2023-09-27 7:43 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
2023-09-27 14:01 ` [igt-dev] [PATCH 1/3] " Zbigniew Kempczyński
2023-09-27 16:09 ` Kamil Konieczny
2023-09-27 17:32 ` Rob Clark
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230926184748.199187-1-robdclark@gmail.com \
--to=robdclark@gmail.com \
--cc=emma@anholt.net \
--cc=helen.koike@collabora.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=robdclark@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox