Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Jeevan B <jeevan.b@intel.com>
To: igt-dev@lists.freedesktop.org
Subject: [igt-dev] [PATCH] tests/kms_setmode: Update test description
Date: Wed, 27 Sep 2023 14:21:44 +0530	[thread overview]
Message-ID: <20230927085144.1548543-1-jeevan.b@intel.com> (raw)

Update test description for 'basic-clone-single-crtc' and
'basic-clone-single-crtc' tests, as these tests are skipped if
a valid scenario is not found, which can cause confusion during
bug analysis.

Signed-off-by: Jeevan B <jeevan.b@intel.com>
Reviewed-by: Swati Sharma <swati2.sharma@intel.com>
---
 tests/kms_setmode.c | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)

diff --git a/tests/kms_setmode.c b/tests/kms_setmode.c
index 32a6fb690..3caf90447 100644
--- a/tests/kms_setmode.c
+++ b/tests/kms_setmode.c
@@ -46,8 +46,8 @@
  * Test category: functionality test
  *
  * SUBTEST: basic-clone-single-crtc
- * Description: Tests the mode by cloning the single crtc by iterating through all
- *              valid crtc/connector combinations
+ * Description: This test allows the use of a single CRTC for two connectors, such as VGA/HDMI,
+ *		VGA/DP, and HDMI/HDMI, which are the possible combinations.
  * Driver requirement: i915, xe
  * Functionality: kms_core
  * Mega feature: General Display Features
@@ -62,8 +62,8 @@
  * Test category: functionality test
  *
  * SUBTEST: invalid-clone-exclusive-crtc
- * Description: Tests the mode by cloning the exclusive crtc by iterating through
- *              all invalid crtc/connector combinations
+ * Description: This test is allowed when a connector uses a CRTC that is not compatible with the
+ *		connector, for instance, DP/HDMI can be used on certain pipes on old platforms.
  * Driver requirement: i915, xe
  * Functionality: kms_core
  * Mega feature: General Display Features
@@ -979,6 +979,7 @@ const char *help_str =
 	"  -t <test id>\tRun only the test with this id\n"
 	"  -e \t\tExtend to run on all pipes. (By default tests will run on two pipes only)\n";
 
+
 igt_main_args("det:", NULL, help_str, opt_handler, NULL)
 {
 	const struct {
-- 
2.25.1

             reply	other threads:[~2023-09-27  8:46 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-27  8:51 Jeevan B [this message]
2023-09-27  9:31 ` [igt-dev] ✗ Fi.CI.BAT: failure for tests/kms_setmode: Update test description Patchwork
2023-09-27 10:06 ` [igt-dev] ✓ CI.xeBAT: success " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230927085144.1548543-1-jeevan.b@intel.com \
    --to=jeevan.b@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox