Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com>
To: igt-dev@lists.freedesktop.org
Subject: [igt-dev] [PATCH i-g-t] lib/igt_fb: on Xe driver take into account adlp with no extended block copy
Date: Wed,  4 Oct 2023 16:47:22 +0300	[thread overview]
Message-ID: <20231004134722.319334-1-juhapekka.heikkila@gmail.com> (raw)

With Xe add check to not use extended block copy if it is not available.

Signed-off-by: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com>
---
 lib/igt_fb.c | 20 +++++++++++---------
 1 file changed, 11 insertions(+), 9 deletions(-)

diff --git a/lib/igt_fb.c b/lib/igt_fb.c
index f0c0681ab..54a66eb6a 100644
--- a/lib/igt_fb.c
+++ b/lib/igt_fb.c
@@ -2920,17 +2920,19 @@ static void blitcopy(const struct igt_fb *dst_fb,
 			blt_set_copy_object(&blt.src, src);
 			blt_set_copy_object(&blt.dst, dst);
 
-			blt_set_object_ext(&ext.src,
-					   blt_compression_format(&blt, src_fb),
-					   src_fb->width, src_fb->height,
-					   SURFACE_TYPE_2D);
+			if (blt_uses_extended_block_copy(src_fb->fd)) {
+				blt_set_object_ext(&ext.src,
+						blt_compression_format(&blt, src_fb),
+						src_fb->width, src_fb->height,
+						SURFACE_TYPE_2D);
 
-			blt_set_object_ext(&ext.dst,
-					   blt_compression_format(&blt, dst_fb),
-					   dst_fb->width, dst_fb->height,
-					   SURFACE_TYPE_2D);
+				blt_set_object_ext(&ext.dst,
+						blt_compression_format(&blt, dst_fb),
+						dst_fb->width, dst_fb->height,
+						SURFACE_TYPE_2D);
 
-			pext = &ext;
+				pext = &ext;
+			}
 
 			blt_set_batch(&blt.bb, xe_bb, bb_size, mem_region);
 
-- 
2.34.1

             reply	other threads:[~2023-10-04 13:47 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-04 13:47 Juha-Pekka Heikkila [this message]
2023-10-04 16:41 ` [igt-dev] [PATCH i-g-t] lib/igt_fb: on Xe driver take into account adlp with no extended block copy Maarten Lankhorst
2023-10-05  8:39   ` Juha-Pekka Heikkila
2023-10-05 11:18     ` Zbigniew Kempczyński
2023-10-05 12:32       ` Juha-Pekka Heikkila
2023-10-04 17:24 ` Zbigniew Kempczyński
2023-10-04 18:06 ` [igt-dev] ✓ CI.xeBAT: success for " Patchwork
2023-10-04 18:07 ` [igt-dev] ✓ Fi.CI.BAT: " Patchwork
2023-10-05  4:01 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
2023-10-05 11:10 ` [igt-dev] [PATCH i-g-t] " Kamil Konieczny
2023-10-05 12:35   ` Juha-Pekka Heikkila

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231004134722.319334-1-juhapekka.heikkila@gmail.com \
    --to=juhapekka.heikkila@gmail.com \
    --cc=igt-dev@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox