From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.88]) by gabe.freedesktop.org (Postfix) with ESMTPS id 034F110E89A for ; Wed, 11 Oct 2023 14:19:16 +0000 (UTC) From: Francois Dugast To: igt-dev@lists.freedesktop.org Date: Wed, 11 Oct 2023 14:18:37 +0000 Message-Id: <20231011141841.7-17-francois.dugast@intel.com> In-Reply-To: <20231011141841.7-1-francois.dugast@intel.com> References: <20231011141841.7-1-francois.dugast@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Subject: [igt-dev] [RFC v1 16/20] xe_query: Add missing include. List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Rodrigo Vivi Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" List-ID: From: Rodrigo Vivi When trying to use xe_for_each_mem_region from a caller that is not importing the igt_aux.h, the following build issue will occur: ../lib/xe/xe_query.h:76:38: error: implicit declaration of function ‘igt_fls’ [-Werror=implicit-function-declaration] 76 | for (uint64_t __i = 0; __i < igt_fls(__memreg); __i++) \ So, to avoid a dependency chain, let's include from the file that is using the helper. Signed-off-by: Rodrigo Vivi --- lib/xe/xe_query.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/lib/xe/xe_query.h b/lib/xe/xe_query.h index 8557bb4c5..dcdfa52c2 100644 --- a/lib/xe/xe_query.h +++ b/lib/xe/xe_query.h @@ -11,6 +11,8 @@ #include #include + +#include "igt_aux.h" #include "igt_list.h" #define SZ_4K 0x1000 -- 2.34.1