Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Francois Dugast <francois.dugast@intel.com>
To: igt-dev@lists.freedesktop.org
Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
Subject: [igt-dev] [RFC v1 19/20] drm-uapi/xe: Align with GuC version type update
Date: Wed, 11 Oct 2023 14:18:40 +0000	[thread overview]
Message-ID: <20231011141841.7-20-francois.dugast@intel.com> (raw)
In-Reply-To: <20231011141841.7-1-francois.dugast@intel.com>

From: Rodrigo Vivi <rodrigo.vivi@intel.com>

Align with kernel commit ("drm/xe/uapi: Be more specific around GuC Version Type")

Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
---
 include/drm-uapi/xe_drm.h | 16 ++++++++++++++--
 1 file changed, 14 insertions(+), 2 deletions(-)

diff --git a/include/drm-uapi/xe_drm.h b/include/drm-uapi/xe_drm.h
index 6e29a6776..ce1a1cc2e 100644
--- a/include/drm-uapi/xe_drm.h
+++ b/include/drm-uapi/xe_drm.h
@@ -468,11 +468,23 @@ struct drm_xe_query_topology_mask {
  *
  * Given a uc_type this will return the major, minor, patch and branch version
  * of the micro-controller firmware.
+ *
+ * The @uc_type can be:
+ *  - %DRM_XE_QUERY_UC_TYPE_GUC_SUBMISSION - This is the GuC Submission Version,
+ * a.k.a 'VF version'. It is not the actual GuC blob version. A running GuC can
+ * support multiple VF APIs with different Submission Versions. This version is
+ * negotiated by the VF KMD with GuC during VF initialization. In most of the
+ * current available GuC blobs, this is a 1-1 relationship where the Submission
+ * version could be inferred from the running version and vice-versa. However,
+ * the submission version is the most useful information for the user space
+ * perspective and needs.
+ *  - %DRM_XE_QUERY_TYPE_HUC - The actual HuC blob that is currently running
+ * in the platform. It returns 0 when HuC is not currently loaded.
  */
 struct drm_xe_query_uc_fw_version {
 	/** @uc_type: The micro-controller type to query firmware version */
-#define DRM_XE_QUERY_UC_TYPE_GUC	0
-#define DRM_XE_QUERY_UC_TYPE_HUC	1
+#define DRM_XE_QUERY_UC_TYPE_GUC_SUBMISSION	0
+#define DRM_XE_QUERY_UC_TYPE_HUC		1
 	__u16 uc_type;
 
 	/** @pad: MBZ */
-- 
2.34.1

  parent reply	other threads:[~2023-10-11 14:19 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-11 14:18 [igt-dev] [RFC v1 00/20] uAPI Alignment - take 2 Francois Dugast
2023-10-11 14:18 ` [igt-dev] [RFC v1 01/20] drm-uapi/xe: Add documentation for query Francois Dugast
2023-10-11 14:18 ` [igt-dev] [RFC v1 02/20] drm-uapi/xe: Extend drm_xe_vm_bind_op Francois Dugast
2023-10-11 14:18 ` [igt-dev] [RFC v1 03/20] drm-uapi/xe: Add uAPI to query micro-controler firmware version Francois Dugast
2023-10-11 14:18 ` [igt-dev] [RFC v1 04/20] drm-uapi/xe: Document DRM_XE_DEVICE_QUERY_HWCONFIG Francois Dugast
2023-10-11 14:18 ` [igt-dev] [RFC v1 05/20] drm-uapi/xe: Extend uAPI to query HuC micro-controler firmware version Francois Dugast
2023-10-11 14:18 ` [igt-dev] [RFC v1 06/20] drm-uapi/xe: Remove useless query config num_params Francois Dugast
2023-10-11 14:18 ` [igt-dev] [RFC v1 07/20] drm-uapi/xe: Add missing DRM_ prefix in uAPI constants Francois Dugast
2023-10-11 14:18 ` [igt-dev] [RFC v1 08/20] drm-uapi/xe: Add _FLAG to uAPI constants usable for flags Francois Dugast
2023-10-11 14:18 ` [igt-dev] [RFC v1 09/20] drm-uapi/xe: Make constant comments visible in kernel doc Francois Dugast
2023-10-11 14:18 ` [igt-dev] [RFC v1 10/20] fixup! tests/intel/xe_query: Add a test for querying engine cycles Francois Dugast
2023-10-11 14:18 ` [igt-dev] [RFC v1 11/20] drm-uapi/xe: Remove GT_TYPE_REMOTE Francois Dugast
2023-10-12 18:36   ` Kamil Konieczny
2023-10-11 14:18 ` [igt-dev] [RFC v1 12/20] drm-uapi/xe: Kill VM_MADVISE IOCTL and the atomic tests Francois Dugast
2023-10-11 14:18 ` [igt-dev] [RFC v1 13/20] drm/xe_query: Remove backward compatibility of vram_visible_size Francois Dugast
2023-10-12 18:39   ` Kamil Konieczny
2023-10-11 14:18 ` [igt-dev] [RFC v1 14/20] xe_ioctl: Converge bo_create to the most used version Francois Dugast
2023-10-11 14:18 ` [igt-dev] [RFC v1 15/20] xe_ioctl: Rename *xe_bo_create_flags to simply xe_bo_create Francois Dugast
2023-10-11 14:18 ` [igt-dev] [RFC v1 16/20] xe_query: Add missing include Francois Dugast
2023-10-12 18:44   ` Kamil Konieczny
2023-10-11 14:18 ` [igt-dev] [RFC v1 17/20] xe_query: Kill visible_vram_if_possible Francois Dugast
2023-10-12 18:46   ` Kamil Konieczny
2023-10-11 14:18 ` [igt-dev] [RFC v1 18/20] drm-uapi/xe: Separate bo_create placement from flags Francois Dugast
2023-10-11 14:18 ` Francois Dugast [this message]
2023-10-11 14:18 ` [igt-dev] [RFC v1 20/20] drm-uapi/xe: Remove unused inaccessible memory region Francois Dugast
2023-10-12  0:20 ` [igt-dev] ✗ Fi.CI.BUILD: failure for uAPI Alignment - take 2 Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231011141841.7-20-francois.dugast@intel.com \
    --to=francois.dugast@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=rodrigo.vivi@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox