Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Matthew Auld <matthew.auld@intel.com>
To: igt-dev@lists.freedesktop.org
Subject: [igt-dev] [PATCH i-g-t v2 03/12] lib/igt_draw: mark buffers as SCANOUT
Date: Wed, 11 Oct 2023 16:09:44 +0100	[thread overview]
Message-ID: <20231011150953.284936-4-matthew.auld@intel.com> (raw)
In-Reply-To: <20231011150953.284936-1-matthew.auld@intel.com>

Display buffers likely will want WC, instead of the default WB on the
CPU side, given that display engine is incoherent with CPU caches.

Signed-off-by: Matthew Auld <matthew.auld@intel.com>
Cc: José Roberto de Souza <jose.souza@intel.com>
Cc: Pallavi Mishra <pallavi.mishra@intel.com>
Reviewed-by: Pallavi Mishra <pallavi.mishra@intel.com>
---
 lib/igt_draw.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/lib/igt_draw.c b/lib/igt_draw.c
index 9a7664a37..1cf9d87c9 100644
--- a/lib/igt_draw.c
+++ b/lib/igt_draw.c
@@ -797,7 +797,8 @@ static void draw_rect_render(int fd, struct cmd_data *cmd_data,
 	else
 		tmp.handle = xe_bo_create_flags(fd, 0,
 						ALIGN(tmp.size, xe_get_default_alignment(fd)),
-						visible_vram_if_possible(fd, 0));
+						visible_vram_if_possible(fd, 0) |
+						XE_GEM_CREATE_FLAG_SCANOUT);
 
 	tmp.stride = rect->w * pixel_size;
 	tmp.bpp = buf->bpp;
-- 
2.41.0

  parent reply	other threads:[~2023-10-11 15:12 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-11 15:09 [igt-dev] [PATCH i-g-t v2 00/12] PAT and cache coherency support Matthew Auld
2023-10-11 15:09 ` [igt-dev] [PATCH i-g-t v2 01/12] drm-uapi/xe_drm: sync to get pat and coherency bits Matthew Auld
2023-10-11 15:09 ` [igt-dev] [PATCH i-g-t v2 02/12] lib/igt_fb: mark buffers as SCANOUT Matthew Auld
2023-10-11 15:09 ` Matthew Auld [this message]
2023-10-11 15:09 ` [igt-dev] [PATCH i-g-t v2 04/12] lib/xe: support cpu_caching and coh_mod for gem_create Matthew Auld
2023-10-11 15:09 ` [igt-dev] [PATCH i-g-t v2 05/12] tests/xe/mmap: add some tests for cpu_caching and coh_mode Matthew Auld
2023-10-11 15:09 ` [igt-dev] [PATCH i-g-t v2 06/12] lib/intel_pat: add helpers for common pat_index modes Matthew Auld
2023-10-11 15:09 ` [igt-dev] [PATCH i-g-t v2 07/12] lib/allocator: add get_offset_pat_index() helper Matthew Auld
2023-10-13  7:44   ` Zbigniew Kempczyński
2023-10-11 15:09 ` [igt-dev] [PATCH i-g-t v2 08/12] lib/intel_blt: support pat_index Matthew Auld
2023-10-13  7:48   ` Zbigniew Kempczyński
2023-10-11 15:09 ` [igt-dev] [PATCH i-g-t v2 09/12] lib/intel_buf: " Matthew Auld
2023-10-13  8:07   ` Zbigniew Kempczyński
2023-10-11 15:09 ` [igt-dev] [PATCH i-g-t v2 10/12] lib/xe_ioctl: update vm_bind to account for pat_index Matthew Auld
2023-10-11 15:09 ` [igt-dev] [PATCH i-g-t v2 11/12] tests/xe: add some vm_bind pat_index tests Matthew Auld
2023-10-11 15:09 ` [igt-dev] [PATCH i-g-t v2 12/12] tests/intel-ci/xe: add pat and caching related tests Matthew Auld
2023-10-12  1:38 ` [igt-dev] ✓ Fi.CI.BAT: success for PAT and cache coherency support (rev2) Patchwork
2023-10-12  2:19 ` [igt-dev] ✗ CI.xeBAT: failure " Patchwork
2023-10-12 18:40 ` [igt-dev] ✗ Fi.CI.IGT: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231011150953.284936-4-matthew.auld@intel.com \
    --to=matthew.auld@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox