From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.115]) by gabe.freedesktop.org (Postfix) with ESMTPS id B287810E420 for ; Thu, 12 Oct 2023 07:01:41 +0000 (UTC) From: =?UTF-8?q?Zbigniew=20Kempczy=C5=84ski?= To: igt-dev@lists.freedesktop.org Date: Thu, 12 Oct 2023 09:01:33 +0200 Message-Id: <20231012070133.31106-1-zbigniew.kempczynski@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Subject: [igt-dev] [PATCH i-g-t] tests/xe_create: Remove create-invalid-size subtest List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?UTF-8?q?Thomas=20Hellstr=C3=B6m?= Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" List-ID: Test exercises kernel returns EINVAL on bo create ioctl with unaligned size what was never merged and according to discussion with Thomas will never be. Lets remove this test as it is incorrect in this case. Signed-off-by: Zbigniew Kempczyński Cc: Thomas Hellström Cc: Maarten Lankhorst --- tests/intel/xe_create.c | 52 ----------------------------------------- 1 file changed, 52 deletions(-) diff --git a/tests/intel/xe_create.c b/tests/intel/xe_create.c index 8d845e5c86..541fc2b335 100644 --- a/tests/intel/xe_create.c +++ b/tests/intel/xe_create.c @@ -39,54 +39,6 @@ static int __create_bo(int fd, uint32_t vm, uint64_t size, uint32_t flags, return ret; } -/** - * SUBTEST: create-invalid-size - * Functionality: ioctl - * Test category: negative test - * Description: Verifies xe bo create returns expected error code on invalid - * buffer sizes. - */ -static void create_invalid_size(int fd) -{ - struct drm_xe_query_mem_region *memregion; - uint64_t memreg = all_memory_regions(fd), region; - uint32_t vm; - uint32_t handle; - int ret; - - vm = xe_vm_create(fd, DRM_XE_VM_CREATE_ASYNC_BIND_OPS, 0); - - xe_for_each_mem_region(fd, memreg, region) { - memregion = xe_mem_region(fd, region); - - /* first try, use half of possible min page size */ - ret = __create_bo(fd, vm, memregion->min_page_size >> 1, - region, &handle); - if (!ret) { - gem_close(fd, handle); - xe_vm_destroy(fd, vm); - } - igt_assert_eq(ret, -EINVAL); - - /* - * second try, add page size to min page size if it is - * bigger than page size. - */ - if (memregion->min_page_size > PAGE_SIZE) { - ret = __create_bo(fd, vm, - memregion->min_page_size + PAGE_SIZE, - region, &handle); - if (!ret) { - gem_close(fd, handle); - xe_vm_destroy(fd, vm); - } - igt_assert_eq(ret, -EINVAL); - } - } - - xe_vm_destroy(fd, vm); -} - enum exec_queue_destroy { NOLEAK, LEAK @@ -214,10 +166,6 @@ igt_main igt_fixture xe = drm_open_driver(DRIVER_XE); - igt_subtest("create-invalid-size") { - create_invalid_size(xe); - } - igt_subtest("create-execqueues-noleak") create_execqueues(xe, NOLEAK); -- 2.34.1