From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM02-DM3-obe.outbound.protection.outlook.com (mail-dm3nam02on2073.outbound.protection.outlook.com [40.107.95.73]) by gabe.freedesktop.org (Postfix) with ESMTPS id D91B610E181 for ; Mon, 16 Oct 2023 20:58:17 +0000 (UTC) From: Hersen Wu To: , , , , , , , Date: Mon, 16 Oct 2023 16:58:04 -0400 Message-ID: <20231016205805.86100-1-hersenxs.wu@amd.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain Subject: [igt-dev] [PATCH 1/2] [i-g-t] tests/kms_cursor_crc: Fix cursor crop on AMD gpu List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Hersen Wu , markyacoub@google.com Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" List-ID: Remove extra line when create cursor fb for AMD gpu. AMD gpu does not support cursor buffer crop. AMD driver fails validation with fb size not equal to cursor size. Signed-off-by: Hersen Wu Reviewed-by: Juha-Pekka Heikkila --- tests/kms_cursor_crc.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/tests/kms_cursor_crc.c b/tests/kms_cursor_crc.c index 76c01f557..ba29ff65d 100644 --- a/tests/kms_cursor_crc.c +++ b/tests/kms_cursor_crc.c @@ -560,14 +560,18 @@ static void create_cursor_fb(data_t *data, int cur_w, int cur_h) { cairo_t *cr; uint32_t fb_id; + int cur_h_extra_line = 1; + /* Cropping is not supported for cursor plane by AMD */ + if (is_amdgpu_device(data->drm_fd)) + cur_h_extra_line = 0; /* * Make the FB slightly taller and leave the extra * line opaque white, so that we can see that the * hardware won't scan beyond what it should (esp. * with non-square cursors). */ - fb_id = igt_create_color_fb(data->drm_fd, cur_w, cur_h + 1, + fb_id = igt_create_color_fb(data->drm_fd, cur_w, cur_h + cur_h_extra_line, DRM_FORMAT_ARGB8888, DRM_FORMAT_MOD_LINEAR, 1.0, 1.0, 1.0, -- 2.25.1