From: Marcin Bernatowicz <marcin.bernatowicz@linux.intel.com>
To: igt-dev@lists.freedesktop.org
Subject: [igt-dev] [PATCH i-g-t] lib/intel_blt.c: ensure uint64_t result of multiplication
Date: Tue, 17 Oct 2023 14:36:54 +0000 [thread overview]
Message-ID: <20231017143654.617723-1-marcin.bernatowicz@linux.intel.com> (raw)
Additionally check for overflow.
This should allow to exercise large buffers
ex. xe_exercise_blt -W 16384 -H 16384
Signed-off-by: Marcin Bernatowicz <marcin.bernatowicz@linux.intel.com>
---
lib/intel_blt.c | 8 +++++++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/lib/intel_blt.c b/lib/intel_blt.c
index a76c7a404..f46c85e91 100644
--- a/lib/intel_blt.c
+++ b/lib/intel_blt.c
@@ -1607,12 +1607,18 @@ blt_create_object(const struct blt_copy_data *blt, uint32_t region,
bool create_mapping)
{
struct blt_copy_object *obj;
- uint64_t size = width * height * bpp / 8;
uint32_t stride = tiling == T_LINEAR ? width * 4 : width;
uint32_t handle;
+ uint64_t size;
igt_assert_f(blt->driver, "Driver isn't set, have you called blt_copy_init()?\n");
+ igt_assert_f((UINT64_MAX / 8) >= width &&
+ (UINT64_MAX / width) >= height &&
+ (UINT64_MAX / (width * height)) >= bpp, "Overflow detected!\n");
+
+ size = (uint64_t)width * height * bpp / 8;
+
obj = calloc(1, sizeof(*obj));
obj->size = size;
--
2.42.0
next reply other threads:[~2023-10-17 15:10 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-17 14:36 Marcin Bernatowicz [this message]
2023-10-17 15:59 ` [igt-dev] ✗ CI.xeBAT: failure for lib/intel_blt.c: ensure uint64_t result of multiplication Patchwork
2023-10-17 16:00 ` [igt-dev] ✗ Fi.CI.BAT: " Patchwork
2023-10-18 9:08 ` [igt-dev] [PATCH i-g-t] " Karolina Stolarek
2023-10-19 14:41 ` Bernatowicz, Marcin
2023-10-20 6:58 ` Karolina Stolarek
2023-10-18 15:28 ` Kamil Konieczny
2023-10-19 15:23 ` Bernatowicz, Marcin
2023-10-19 15:27 ` Kamil Konieczny
2023-10-19 15:36 ` Bernatowicz, Marcin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231017143654.617723-1-marcin.bernatowicz@linux.intel.com \
--to=marcin.bernatowicz@linux.intel.com \
--cc=igt-dev@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox