From: Lee Shawn C <shawn.c.lee@intel.com>
To: igt-dev@lists.freedesktop.org
Cc: Lee Shawn C <shawn.c.lee@intel.com>
Subject: [igt-dev] [[PATCH i-g-t]] tests/kms_setmode: disable DRRS if eDP support variable refresh rate
Date: Wed, 18 Oct 2023 15:59:04 +0800 [thread overview]
Message-ID: <20231018075904.1834634-1-shawn.c.lee@intel.com> (raw)
Below is a failed case while testing kms_setmode.
CRTC[80] [Pipe A] Mode: 1920x1200@60Hz Connectors: eDP-1[236]
Expected frametime: 16659us; measured 20824.4us +- 4.799us accuracy 0.01% [0.10 scanlines]
The expected frame time is 16659us (60Hz refresh rate).
But kms_setmode report measured time was 20824.4us (48Hz) then
it failed. We found legacy DRRS mode was active at that time
then refresh rate fall into lower RR automatically to cause this problem.
Disable DRRS after crtc setmode can avoid driver switch to lower RR mode
and get pass for this test as well.
Issue: https://gitlab.freedesktop.org/drm/igt-gpu-tools/-/issues/148
Cc: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
Cc: Vidya Srinivas <vidya.srinivas@intel.com>
Signed-off-by: Lee Shawn C <shawn.c.lee@intel.com>
---
tests/kms_setmode.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/tests/kms_setmode.c b/tests/kms_setmode.c
index 5fc4421c0080..b6fe3f9c159a 100644
--- a/tests/kms_setmode.c
+++ b/tests/kms_setmode.c
@@ -31,6 +31,7 @@
#include <sys/time.h>
#include <math.h>
#include "xe/xe_query.h"
+#include "i915/intel_drrs.h"
/**
* TEST: kms setmode
* Category: Display
@@ -651,6 +652,9 @@ retry:
crtc->fb_info.fb_id, 0, 0, ids,
crtc->connector_count, &crtc->mode);
+ if (is_intel_device(drm_fd))
+ intel_drrs_disable(drm_fd, crtc->pipe_id);
+
free(ids);
if (ret < 0) {
--
2.34.1
next reply other threads:[~2023-10-18 8:05 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-18 7:59 Lee Shawn C [this message]
2023-10-18 8:59 ` [igt-dev] ✗ Fi.CI.BAT: failure for ] tests/kms_setmode: disable DRRS if eDP support variable refresh rate Patchwork
2023-10-18 9:45 ` [igt-dev] ✓ CI.xeBAT: success " Patchwork
2023-10-18 17:04 ` [igt-dev] [[PATCH i-g-t]] " Mark Yacoub
2023-10-19 9:55 ` Lee, Shawn C
2023-10-19 10:39 ` Kamil Konieczny
2023-10-19 10:53 ` Lee, Shawn C
2023-10-19 11:27 ` [igt-dev] [PATCH] " Lee Shawn C
2023-10-20 14:02 ` Juha-Pekka Heikkila
2023-10-23 5:22 ` Modem, Bhanuprakash
2023-10-23 5:59 ` Lee, Shawn C
2023-10-25 8:29 ` Modem, Bhanuprakash
2023-10-23 17:40 ` [igt-dev] ✓ Fi.CI.BAT: success for ] tests/kms_setmode: disable DRRS if eDP support variable refresh rate (rev2) Patchwork
2023-10-23 18:44 ` [igt-dev] ✓ CI.xeBAT: " Patchwork
2023-10-24 1:10 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231018075904.1834634-1-shawn.c.lee@intel.com \
--to=shawn.c.lee@intel.com \
--cc=igt-dev@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox