From: Matthew Auld <matthew.auld@intel.com>
To: igt-dev@lists.freedesktop.org
Subject: [igt-dev] [PATCH i-g-t v5 06/15] lib/intel_pat: add helpers for common pat_index modes
Date: Fri, 20 Oct 2023 10:37:52 +0100 [thread overview]
Message-ID: <20231020093801.631809-7-matthew.auld@intel.com> (raw)
In-Reply-To: <20231020093801.631809-1-matthew.auld@intel.com>
For now just add uc, wt and wb for every platform. The wb mode should
always be at least 1way coherent, if messing around with system memory.
Also make non-matching platforms throw an error rather than trying to
inherit the modes from previous platforms since they will likely be
different.
Signed-off-by: Matthew Auld <matthew.auld@intel.com>
Cc: José Roberto de Souza <jose.souza@intel.com>
Cc: Pallavi Mishra <pallavi.mishra@intel.com>
Reviewed-by: Pallavi Mishra <pallavi.mishra@intel.com>
Reviewed-by: Niranjana Vishwanathapura <niranjana.vishwanathapura@intel.com>
---
lib/intel_pat.c | 77 +++++++++++++++++++++++++++++++++++++++++++++++++
lib/intel_pat.h | 19 ++++++++++++
lib/meson.build | 1 +
3 files changed, 97 insertions(+)
create mode 100644 lib/intel_pat.c
create mode 100644 lib/intel_pat.h
diff --git a/lib/intel_pat.c b/lib/intel_pat.c
new file mode 100644
index 000000000..2b892ee52
--- /dev/null
+++ b/lib/intel_pat.c
@@ -0,0 +1,77 @@
+// SPDX-License-Identifier: MIT
+/*
+ * Copyright © 2023 Intel Corporation
+ */
+
+#include "intel_pat.h"
+
+#include "igt.h"
+
+struct intel_pat_cache {
+ uint8_t uc; /* UC + COH_NONE */
+ uint8_t wt; /* WT + COH_NONE */
+ uint8_t wb; /* WB + COH_AT_LEAST_1WAY */
+
+ uint8_t max_index;
+};
+
+static void intel_get_pat_idx(int fd, struct intel_pat_cache *pat)
+{
+ uint16_t dev_id = intel_get_drm_devid(fd);
+
+ if (intel_get_device_info(dev_id)->graphics_ver == 20) {
+ pat->uc = 3;
+ pat->wt = 15; /* Compressed + WB-transient */
+ pat->wb = 2;
+ pat->max_index = 31;
+ } else if (IS_METEORLAKE(dev_id)) {
+ pat->uc = 2;
+ pat->wt = 1;
+ pat->wb = 3;
+ pat->max_index = 3;
+ } else if (IS_PONTEVECCHIO(dev_id)) {
+ pat->uc = 0;
+ pat->wt = 2;
+ pat->wb = 3;
+ pat->max_index = 7;
+ } else if (intel_graphics_ver(dev_id) <= IP_VER(12, 60)) {
+ pat->uc = 3;
+ pat->wt = 2;
+ pat->wb = 0;
+ pat->max_index = 3;
+ } else {
+ igt_critical("Platform is missing PAT settings for uc/wt/wb\n");
+ }
+}
+
+uint8_t intel_get_max_pat_index(int fd)
+{
+ struct intel_pat_cache pat = {};
+
+ intel_get_pat_idx(fd, &pat);
+ return pat.max_index;
+}
+
+uint8_t intel_get_pat_idx_uc(int fd)
+{
+ struct intel_pat_cache pat = {};
+
+ intel_get_pat_idx(fd, &pat);
+ return pat.uc;
+}
+
+uint8_t intel_get_pat_idx_wt(int fd)
+{
+ struct intel_pat_cache pat = {};
+
+ intel_get_pat_idx(fd, &pat);
+ return pat.wt;
+}
+
+uint8_t intel_get_pat_idx_wb(int fd)
+{
+ struct intel_pat_cache pat = {};
+
+ intel_get_pat_idx(fd, &pat);
+ return pat.wb;
+}
diff --git a/lib/intel_pat.h b/lib/intel_pat.h
new file mode 100644
index 000000000..c24dbc275
--- /dev/null
+++ b/lib/intel_pat.h
@@ -0,0 +1,19 @@
+/* SPDX-License-Identifier: MIT */
+/*
+ * Copyright © 2023 Intel Corporation
+ */
+
+#ifndef INTEL_PAT_H
+#define INTEL_PAT_H
+
+#include <stdint.h>
+
+#define DEFAULT_PAT_INDEX ((uint8_t)-1) /* igt-core can pick 1way or better */
+
+uint8_t intel_get_max_pat_index(int fd);
+
+uint8_t intel_get_pat_idx_uc(int fd);
+uint8_t intel_get_pat_idx_wt(int fd);
+uint8_t intel_get_pat_idx_wb(int fd);
+
+#endif /* INTEL_PAT_H */
diff --git a/lib/meson.build b/lib/meson.build
index a7bccafc3..48466a2e9 100644
--- a/lib/meson.build
+++ b/lib/meson.build
@@ -64,6 +64,7 @@ lib_sources = [
'intel_device_info.c',
'intel_mmio.c',
'intel_mocs.c',
+ 'intel_pat.c',
'ioctl_wrappers.c',
'media_spin.c',
'media_fill.c',
--
2.41.0
next prev parent reply other threads:[~2023-10-20 9:38 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-20 9:37 [igt-dev] [PATCH i-g-t v5 00/15] PAT and cache coherency support Matthew Auld
2023-10-20 9:37 ` [igt-dev] [PATCH i-g-t v5 01/15] drm-uapi/xe_drm: sync to get pat and coherency bits Matthew Auld
2023-10-20 9:37 ` [igt-dev] [PATCH i-g-t v5 02/15] lib/igt_fb: mark buffers as SCANOUT Matthew Auld
2023-10-20 9:37 ` [igt-dev] [PATCH i-g-t v5 03/15] lib/igt_draw: " Matthew Auld
2023-10-20 9:37 ` [igt-dev] [PATCH i-g-t v5 04/15] lib/xe: support cpu_caching and coh_mod for gem_create Matthew Auld
2023-10-20 9:37 ` [igt-dev] [PATCH i-g-t v5 05/15] tests/xe/mmap: add some tests for cpu_caching and coh_mode Matthew Auld
2023-10-20 9:37 ` Matthew Auld [this message]
2023-10-20 9:37 ` [igt-dev] [PATCH i-g-t v5 07/15] lib/allocator: add get_offset_pat_index() helper Matthew Auld
2023-10-20 9:37 ` [igt-dev] [PATCH i-g-t v5 08/15] lib/intel_blt: support pat_index Matthew Auld
2023-10-20 9:37 ` [igt-dev] [PATCH i-g-t v5 09/15] lib/intel_buf: " Matthew Auld
2023-10-20 17:25 ` Niranjana Vishwanathapura
2023-10-20 9:37 ` [igt-dev] [PATCH i-g-t v5 10/15] lib/xe_ioctl: update vm_bind to account for pat_index Matthew Auld
2023-10-20 16:59 ` Niranjana Vishwanathapura
2023-10-20 9:37 ` [igt-dev] [PATCH i-g-t v5 11/15] lib/intel_allocator: treat default_alignment as the minimum Matthew Auld
2023-10-24 16:39 ` Zbigniew Kempczyński
2023-10-24 17:16 ` Matthew Auld
2023-11-02 9:53 ` Zbigniew Kempczyński
2023-10-20 9:37 ` [igt-dev] [PATCH i-g-t v5 12/15] lib/intel_blt: tidy up alignment usage Matthew Auld
2023-10-20 9:37 ` [igt-dev] [PATCH i-g-t v5 13/15] lib/intel_batchbuffer: extend to include optional alignment Matthew Auld
2023-10-24 16:42 ` Zbigniew Kempczyński
2023-10-20 9:38 ` [igt-dev] [PATCH i-g-t v5 14/15] tests/xe: add some vm_bind pat_index tests Matthew Auld
2023-10-20 18:46 ` Niranjana Vishwanathapura
2023-10-20 9:38 ` [igt-dev] [PATCH i-g-t v5 15/15] tests/intel-ci/xe: add pat and caching related tests Matthew Auld
2023-10-23 23:09 ` [igt-dev] ✓ Fi.CI.BAT: success for PAT and cache coherency support (rev5) Patchwork
2023-10-24 0:13 ` [igt-dev] ✗ CI.xeBAT: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231020093801.631809-7-matthew.auld@intel.com \
--to=matthew.auld@intel.com \
--cc=igt-dev@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox