From: Petri Latvala <adrinael@adrinael.net>
To: igt-dev@lists.freedesktop.org
Subject: [igt-dev] [PATCH 2/3] runner/runner_tests: Unit tests for binary-name-only testlist entries
Date: Fri, 20 Oct 2023 16:30:40 +0300 [thread overview]
Message-ID: <20231020133041.58257-2-adrinael@adrinael.net> (raw)
In-Reply-To: <20231020133041.58257-1-adrinael@adrinael.net>
Signed-off-by: Petri Latvala <adrinael@adrinael.net>
---
runner/runner_tests.c | 70 +++++++++++++++++++++++++++++++++++++++++++
1 file changed, 70 insertions(+)
diff --git a/runner/runner_tests.c b/runner/runner_tests.c
index a7e968f85..e6024de11 100644
--- a/runner/runner_tests.c
+++ b/runner/runner_tests.c
@@ -1810,6 +1810,76 @@ igt_main
}
}
+ igt_subtest_group {
+ const char testlisttext[] = "igt@successtest";
+ const char blocktext[] = "igt@successtest@first";
+ struct job_list *list = malloc(sizeof(*list));
+ volatile int dirfd = -1;
+ char dirname[] = "tmpdirXXXXXX";
+ volatile int listfd;
+ volatile int blockfd;
+ char listfilename[] = "tmplistXXXXXX";
+ char blockfilename[] = "tmpblockXXXXXX";
+
+ igt_fixture {
+ igt_require(mkdtemp(dirname) != NULL);
+ rmdir(dirname);
+
+ igt_require((listfd = mkstemp(listfilename)) >= 0);
+ igt_require(write(listfd, testlisttext, strlen(testlisttext)) == strlen(testlisttext));
+ igt_require((blockfd = mkstemp(blockfilename)) >= 0);
+ igt_require(write(blockfd, blocktext, strlen(blocktext)) == strlen(blocktext));
+ close(listfd);
+ close(blockfd);
+
+ init_job_list(list);
+ }
+
+ igt_subtest("only-binary-name-in-testlist") {
+ const char *argv[] = { "runner",
+ "--allow-non-root",
+ "--test-list", listfilename,
+ testdatadir,
+ dirname,
+ };
+
+ igt_assert(parse_options(ARRAY_SIZE(argv), (char**)argv, settings));
+
+ igt_assert(create_job_list(list, settings));
+ /* No multi-mode, binary has two subtests, should be normalized to have individual subtests */
+ igt_assert_eq(list->size, 2);
+ igt_assert_eq(list->entries[0].subtest_count, 1);
+ igt_assert_eq(list->entries[1].subtest_count, 1);
+ }
+
+ igt_subtest("only-binary-name-in-testlist-with-blocks") {
+ const char *argv[] = { "runner",
+ "--allow-non-root",
+ "--test-list", listfilename,
+ "-b", blockfilename,
+ testdatadir,
+ dirname,
+ };
+
+ igt_assert(parse_options(ARRAY_SIZE(argv), (char**)argv, settings));
+
+ igt_assert(create_job_list(list, settings));
+ /* No multi-mode, binary has two subtests, one of them blocked */
+ igt_assert_eq(list->size, 1);
+ igt_assert_eq(list->entries[0].subtest_count, 1);
+ igt_assert_eqstr(list->entries[0].subtests[0], "second-subtest");
+ }
+
+ igt_fixture {
+ unlink(listfilename);
+ unlink(blockfilename);
+ close(dirfd);
+ clear_directory(dirname);
+ free_job_list(list);
+ free(list);
+ }
+ }
+
igt_subtest_group {
struct job_list *list = malloc(sizeof(*list));
volatile int dirfd = -1;
--
2.39.2
next prev parent reply other threads:[~2023-10-20 13:30 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-20 13:30 [igt-dev] [PATCH 1/3] runner: Normalize testlist entries that don't list subtests Petri Latvala
2023-10-20 13:30 ` Petri Latvala [this message]
2023-10-24 13:57 ` [igt-dev] [PATCH 2/3] runner/runner_tests: Unit tests for binary-name-only testlist entries Mauro Carvalho Chehab
2023-10-24 16:53 ` Kamil Konieczny
2023-10-20 13:30 ` [igt-dev] [PATCH 3/3] runner/runner_tests: Fix name of no-subtests in unit tests Petri Latvala
2023-10-24 13:58 ` Mauro Carvalho Chehab
2023-10-24 1:01 ` [igt-dev] ✓ Fi.CI.BAT: success for series starting with [1/3] runner: Normalize testlist entries that don't list subtests Patchwork
2023-10-24 1:56 ` [igt-dev] ✓ CI.xeBAT: " Patchwork
2023-10-24 13:51 ` [igt-dev] [PATCH 1/3] " Mauro Carvalho Chehab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231020133041.58257-2-adrinael@adrinael.net \
--to=adrinael@adrinael.net \
--cc=igt-dev@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox