From: Lee Shawn C <shawn.c.lee@intel.com>
To: igt-dev@lists.freedesktop.org
Cc: Lee Shawn C <shawn.c.lee@intel.com>
Subject: [igt-dev] [i-g-t] tests/kms_flip: disable DRRS if eDP support variable refresh rate
Date: Sun, 22 Oct 2023 22:09:59 +0800 [thread overview]
Message-ID: <20231022140959.1874333-1-shawn.c.lee@intel.com> (raw)
Just like https://gitlab.freedesktop.org/drm/igt-gpu-tools/-/issues/148.
kms_flip used the same way to calculate frametime. It may have chance
to encounter this issue and get unexpected frame time due to DUT at
low RR mode. So disable DRRS after crtc setmode can avoid driver switch
to lower RR mode automatically to avoid this problem.
Cc: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
Cc: Vidya Srinivas <vidya.srinivas@intel.com>
Cc: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com>
Cc: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
Cc: Kamil Konieczny <kamil.konieczny@linux.intel.com>
Signed-off-by: Lee Shawn C <shawn.c.lee@intel.com>
---
tests/kms_flip.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/tests/kms_flip.c b/tests/kms_flip.c
index 2c60cdf6db64..fc7cee0501c4 100755
--- a/tests/kms_flip.c
+++ b/tests/kms_flip.c
@@ -30,6 +30,7 @@
#include "config.h"
#include "igt.h"
+#include "i915/intel_drrs.h"
#include <cairo.h>
#include <errno.h>
@@ -911,6 +912,9 @@ static int set_mode(struct test_output *o, uint32_t fb, int x, int y)
conn, count, mode);
if (ret)
return ret;
+
+ if (is_intel_device(drm_fd))
+ intel_drrs_disable(drm_fd, o->pipe);
}
return 0;
--
2.34.1
next reply other threads:[~2023-10-22 14:16 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-22 14:09 Lee Shawn C [this message]
2023-10-25 8:29 ` [igt-dev] [i-g-t] tests/kms_flip: disable DRRS if eDP support variable refresh rate Modem, Bhanuprakash
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231022140959.1874333-1-shawn.c.lee@intel.com \
--to=shawn.c.lee@intel.com \
--cc=igt-dev@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox