From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qk1-x735.google.com (mail-qk1-x735.google.com [IPv6:2607:f8b0:4864:20::735]) by gabe.freedesktop.org (Postfix) with ESMTPS id B4B1910E257 for ; Mon, 23 Oct 2023 20:59:16 +0000 (UTC) Received: by mail-qk1-x735.google.com with SMTP id af79cd13be357-778925998cbso252724785a.0 for ; Mon, 23 Oct 2023 13:59:16 -0700 (PDT) From: Sean Paul To: igt-dev@lists.freedesktop.org Date: Mon, 23 Oct 2023 20:56:32 +0000 Message-ID: <20231023205910.3556533-3-sean@poorly.run> In-Reply-To: <20231023205910.3556533-1-sean@poorly.run> References: <20231023205910.3556533-1-sean@poorly.run> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [igt-dev] [PATCH v2 2/8] tests/kms_vrr: Move vtest_ns into data_t List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Sean Paul Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" List-ID: From: Sean Paul vtest_ns is derived from data->range which is fixed. Move it into data_t and generate it once in prepare_test(). Cc: Mark Yacoub Reviewed-by: Bhanuprakash Modem Signed-off-by: Sean Paul --- tests/kms_vrr.c | 34 ++++++++++++++-------------------- 1 file changed, 14 insertions(+), 20 deletions(-) diff --git a/tests/kms_vrr.c b/tests/kms_vrr.c index 4eeae4747..36f5b100d 100644 --- a/tests/kms_vrr.c +++ b/tests/kms_vrr.c @@ -96,20 +96,21 @@ typedef struct range { unsigned int max; } range_t; +typedef struct vtest_ns { + uint64_t min; + uint64_t mid; + uint64_t max; +} vtest_ns_t; + typedef struct data { igt_display_t display; int drm_fd; igt_plane_t *primary; igt_fb_t fb[2]; range_t range; + vtest_ns_t vtest_ns; } data_t; -typedef struct vtest_ns { - uint64_t min; - uint64_t mid; - uint64_t max; -} vtest_ns_t; - typedef void (*test_t)(data_t*, enum pipe, igt_output_t*, uint32_t); /* Converts a timespec structure to nanoseconds. */ @@ -210,18 +211,6 @@ get_vrr_range(data_t *data, igt_output_t *output) return range; } -/* Returns vrr test frequency for min, mid & max range. */ -static vtest_ns_t get_test_rate_ns(range_t range) -{ - vtest_ns_t vtest_ns; - - vtest_ns.min = rate_from_refresh(range.min); - vtest_ns.mid = rate_from_refresh(((range.max + range.min) / 2)); - vtest_ns.max = rate_from_refresh(range.max); - - return vtest_ns; -} - /* Returns true if driver supports VRR. */ static bool has_vrr(igt_output_t *output) { @@ -255,6 +244,11 @@ static void prepare_test(data_t *data, igt_output_t *output, enum pipe pipe) /* Capture VRR range */ data->range = get_vrr_range(data, output); + data->vtest_ns.min = rate_from_refresh(data->range.min); + data->vtest_ns.mid = rate_from_refresh( + (data->range.min + data->range.max) / 2); + data->vtest_ns.max = rate_from_refresh(data->range.max); + /* Override mode with max vrefresh. * - vrr_min range should be less than the override mode vrefresh. * - Limit the vrr_max range with the override mode vrefresh. @@ -329,7 +323,7 @@ flip_and_measure(data_t *data, igt_output_t *output, enum pipe pipe, uint64_t start_ns, last_event_ns, target_ns; uint32_t total_flip = 0, total_pass = 0; bool front = false; - vtest_ns_t vtest_ns = get_test_rate_ns(data->range); + vtest_ns_t vtest_ns = data->vtest_ns; /* Align with the flip completion event to speed up convergence. */ do_flip(data, &data->fb[0]); @@ -406,7 +400,7 @@ test_basic(data_t *data, enum pipe pipe, igt_output_t *output, uint32_t flags) prepare_test(data, output, pipe); range = data->range; - vtest_ns = get_test_rate_ns(range); + vtest_ns = data->vtest_ns; rate = vtest_ns.mid; igt_info("VRR Test execution on %s, PIPE_%s with VRR range: (%u-%u) Hz\n", -- Sean Paul, Software Engineer, Google / Chromium OS