From: Mauro Carvalho Chehab <mauro.chehab@linux.intel.com>
To: igt-dev@lists.freedesktop.org
Subject: [igt-dev] [PATCH i-g-t 1/7] runner: Normalize testlist entries that don't list subtests
Date: Tue, 24 Oct 2023 16:11:04 +0200 [thread overview]
Message-ID: <20231024141855.160633-2-mauro.chehab@linux.intel.com> (raw)
In-Reply-To: <20231024141855.160633-1-mauro.chehab@linux.intel.com>
From: Petri Latvala <adrinael@adrinael.net>
As the syntax for "all subtests" and "test that doesn't have subtests"
is the same, check the subtest listing when building the execution
plan. Doing that makes it possible to still have "all subtests" in
testlists (albeit not originally designed to support that) and enables
blocklisting particular subtests.
Signed-off-by: Petri Latvala <adrinael@adrinael.net>
Reviewed-by: Mauro Carvalho Chehab <mchehab@kernel.org>
Cc: Arkadiusz Hiler <arek@hiler.eu>
Cc: Kamil Konieczny <kamil.konieczny@linux.intel.com>
Cc: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com>
Cc: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
Cc: Ashutosh Dixit <ashutosh.dixit@intel.com>
Closes: https://gitlab.freedesktop.org/drm/igt-gpu-tools/-/issues/149
---
runner/job_list.c | 22 +++++++++++++++++++++-
1 file changed, 21 insertions(+), 1 deletion(-)
diff --git a/runner/job_list.c b/runner/job_list.c
index e6ea836310fd..27cbb10bce56 100644
--- a/runner/job_list.c
+++ b/runner/job_list.c
@@ -230,8 +230,28 @@ static bool job_list_from_test_list(struct job_list *job_list,
continue;
if (sscanf(line, "igt@%ms", &binary) == 1) {
- if ((delim = strchr(binary, '@')) != NULL)
+ if ((delim = strchr(binary, '@')) != NULL) {
*delim++ = '\0';
+ } else {
+ /*
+ * No subtests specified. Check
+ * whether the user means "all
+ * subtests" or if the test doesn't
+ * have any.
+ */
+ if (entry.binary) {
+ /* First flush the entry we're building for multiple-mode */
+ add_job_list_entry(job_list, entry.binary, entry.subtests, entry.subtest_count);
+ memset(&entry, 0, sizeof(entry));
+ any = true;
+ }
+
+ add_subtests(job_list, settings, binary,
+ &settings->include_regexes,
+ &settings->exclude_regexes);
+ any = true;
+ continue;
+ }
if (!settings->multiple_mode) {
char **subtests = NULL;
--
2.41.0
next prev parent reply other threads:[~2023-10-24 14:19 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-24 14:11 [igt-dev] [PATCH i-g-t 0/7] better sync test_list.py with igt_runner Mauro Carvalho Chehab
2023-10-24 14:11 ` Mauro Carvalho Chehab [this message]
2023-10-24 14:11 ` [igt-dev] [PATCH i-g-t 2/7] runner/runner_tests: Unit tests for binary-name-only testlist entries Mauro Carvalho Chehab
2023-10-24 14:11 ` [igt-dev] [PATCH i-g-t 3/7] runner/runner_tests: Fix name of no-subtests in unit tests Mauro Carvalho Chehab
2023-10-24 14:11 ` [igt-dev] [PATCH i-g-t 4/7] igt_runner: don't require root for dry_run Mauro Carvalho Chehab
2023-10-25 7:53 ` Kamil Konieczny
2023-10-24 14:11 ` [igt-dev] [PATCH i-g-t 5/7] scripts/test_list.py: better handle list of tests Mauro Carvalho Chehab
2023-10-25 7:54 ` Kamil Konieczny
2023-10-24 14:11 ` [igt-dev] [PATCH i-g-t 6/7] runner/job_list: use case-insensitive regular expressions Mauro Carvalho Chehab
2023-10-25 7:56 ` Kamil Konieczny
2023-10-24 14:11 ` [igt-dev] [PATCH i-g-t 7/7] runner/runner_tests: change a regex to match case-insensitive Mauro Carvalho Chehab
2023-10-25 9:56 ` Kamil Konieczny
2023-10-30 9:56 ` Mauro Carvalho Chehab
2023-10-24 15:45 ` [igt-dev] ✓ Fi.CI.BAT: success for better sync test_list.py with igt_runner Patchwork
2023-10-24 15:46 ` [igt-dev] ✗ GitLab.Pipeline: warning " Patchwork
2023-10-25 4:17 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231024141855.160633-2-mauro.chehab@linux.intel.com \
--to=mauro.chehab@linux.intel.com \
--cc=igt-dev@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox