From: Matthew Auld <matthew.auld@intel.com>
To: igt-dev@lists.freedesktop.org
Subject: [igt-dev] [PATCH i-g-t v6 02/15] lib/igt_fb: mark buffers as SCANOUT
Date: Thu, 2 Nov 2023 17:46:47 +0000 [thread overview]
Message-ID: <20231102174700.298135-3-matthew.auld@intel.com> (raw)
In-Reply-To: <20231102174700.298135-1-matthew.auld@intel.com>
Display buffers likely will want WC, instead of the default WB on the
CPU side, given that display engine is incoherent with CPU caches.
Signed-off-by: Matthew Auld <matthew.auld@intel.com>
Cc: José Roberto de Souza <jose.souza@intel.com>
Cc: Pallavi Mishra <pallavi.mishra@intel.com>
Reviewed-by: Pallavi Mishra <pallavi.mishra@intel.com>
---
lib/igt_fb.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/lib/igt_fb.c b/lib/igt_fb.c
index e531a041e..ad0148339 100644
--- a/lib/igt_fb.c
+++ b/lib/igt_fb.c
@@ -1206,7 +1206,8 @@ static int create_bo_for_fb(struct igt_fb *fb, bool prefer_sysmem)
igt_assert(err == 0 || err == -EOPNOTSUPP);
} else if (is_xe_device(fd)) {
fb->gem_handle = xe_bo_create_flags(fd, 0, fb->size,
- visible_vram_if_possible(fd, 0));
+ visible_vram_if_possible(fd, 0) |
+ XE_GEM_CREATE_FLAG_SCANOUT);
} else if (is_vc4_device(fd)) {
fb->gem_handle = igt_vc4_create_bo(fd, fb->size);
--
2.41.0
next prev parent reply other threads:[~2023-11-02 17:47 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-02 17:46 [igt-dev] [PATCH i-g-t v6 00/15] PAT and cache coherency support Matthew Auld
2023-11-02 17:46 ` [igt-dev] [PATCH i-g-t v6 01/15] drm-uapi/xe_drm: sync to get pat and coherency bits Matthew Auld
2023-11-02 17:46 ` Matthew Auld [this message]
2023-11-02 17:46 ` [igt-dev] [PATCH i-g-t v6 03/15] lib/igt_draw: mark buffers as SCANOUT Matthew Auld
2023-11-02 17:46 ` [igt-dev] [PATCH i-g-t v6 04/15] lib/xe: support cpu_caching and coh_mod for gem_create Matthew Auld
2023-11-02 17:46 ` [igt-dev] [PATCH i-g-t v6 05/15] tests/xe/mmap: add some tests for cpu_caching and coh_mode Matthew Auld
2023-11-02 17:46 ` [igt-dev] [PATCH i-g-t v6 06/15] lib/intel_pat: add helpers for common pat_index modes Matthew Auld
2023-11-02 17:46 ` [igt-dev] [PATCH i-g-t v6 07/15] lib/allocator: add get_offset_pat_index() helper Matthew Auld
2023-11-02 17:46 ` [igt-dev] [PATCH i-g-t v6 08/15] lib/intel_blt: support pat_index Matthew Auld
2023-11-02 17:46 ` [igt-dev] [PATCH i-g-t v6 09/15] lib/intel_buf: " Matthew Auld
2023-11-02 17:46 ` [igt-dev] [PATCH i-g-t v6 10/15] lib/xe_ioctl: update vm_bind to account for pat_index Matthew Auld
2023-11-02 17:46 ` [igt-dev] [PATCH i-g-t v6 11/15] lib/intel_allocator: treat default_alignment as the minimum Matthew Auld
2023-11-02 17:46 ` [igt-dev] [PATCH i-g-t v6 12/15] lib/intel_blt: tidy up alignment usage Matthew Auld
2023-11-02 17:46 ` [igt-dev] [PATCH i-g-t v6 13/15] lib/intel_batchbuffer: extend to include optional alignment Matthew Auld
2023-11-02 17:46 ` [igt-dev] [PATCH i-g-t v6 14/15] tests/xe: add some vm_bind pat_index tests Matthew Auld
2023-11-02 17:47 ` [igt-dev] [PATCH i-g-t v6 15/15] tests/intel-ci/xe: add pat and caching related tests Matthew Auld
2023-11-02 19:02 ` [igt-dev] ✓ Fi.CI.BAT: success for PAT and cache coherency support (rev6) Patchwork
2023-11-02 19:24 ` [igt-dev] ✗ CI.xeBAT: failure " Patchwork
2023-11-03 16:28 ` [igt-dev] ✗ Fi.CI.IGT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231102174700.298135-3-matthew.auld@intel.com \
--to=matthew.auld@intel.com \
--cc=igt-dev@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox