From: Matthew Auld <matthew.auld@intel.com>
To: igt-dev@lists.freedesktop.org
Subject: [igt-dev] [PATCH i-g-t v7 11/15] lib/intel_allocator: treat default_alignment as the minimum
Date: Fri, 3 Nov 2023 16:02:33 +0000 [thread overview]
Message-ID: <20231103160237.405122-12-matthew.auld@intel.com> (raw)
In-Reply-To: <20231103160237.405122-1-matthew.auld@intel.com>
If something overrides the default alignment, we should only apply the
alignment if it is larger than the default_alignment.
v2 (Niranjana):
- Simplify slightly
Signed-off-by: Matthew Auld <matthew.auld@intel.com>
Cc: Zbigniew Kempczyński <zbigniew.kempczynski@intel.com>
Cc: José Roberto de Souza <jose.souza@intel.com>
Cc: Pallavi Mishra <pallavi.mishra@intel.com>
Reviewed-by: Niranjana Vishwanathapura <niranjana.vishwanathapura@intel.com>
Reviewed-by: Zbigniew Kempczyński <zbigniew.kempczynski@intel.com>
---
lib/intel_allocator.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/lib/intel_allocator.c b/lib/intel_allocator.c
index e5b9457b8..96ffe40d5 100644
--- a/lib/intel_allocator.c
+++ b/lib/intel_allocator.c
@@ -584,8 +584,8 @@ static int handle_request(struct alloc_req *req, struct alloc_resp *resp)
break;
case REQ_ALLOC:
- if (!req->alloc.alignment)
- req->alloc.alignment = ial->default_alignment;
+ req->alloc.alignment = max(ial->default_alignment,
+ req->alloc.alignment);
resp->response_type = RESP_ALLOC;
resp->alloc.offset = ial->alloc(ial,
--
2.41.0
next prev parent reply other threads:[~2023-11-03 16:03 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-03 16:02 [igt-dev] [PATCH i-g-t v7 00/15] PAT and cache coherency support Matthew Auld
2023-11-03 16:02 ` [igt-dev] [PATCH i-g-t v7 01/15] drm-uapi/xe_drm: sync to get pat and coherency bits Matthew Auld
2023-11-03 16:02 ` [igt-dev] [PATCH i-g-t v7 02/15] lib/igt_fb: mark buffers as SCANOUT Matthew Auld
2023-11-03 16:02 ` [igt-dev] [PATCH i-g-t v7 03/15] lib/igt_draw: " Matthew Auld
2023-11-03 16:02 ` [igt-dev] [PATCH i-g-t v7 04/15] lib/xe: support explicit cpu_caching gem_create Matthew Auld
2023-11-03 16:02 ` [igt-dev] [PATCH i-g-t v7 05/15] tests/xe/mmap: add some tests for explicit cpu_caching Matthew Auld
2023-11-03 16:02 ` [igt-dev] [PATCH i-g-t v7 06/15] lib/intel_pat: add helpers for common pat_index modes Matthew Auld
2023-11-03 16:02 ` [igt-dev] [PATCH i-g-t v7 07/15] lib/allocator: add get_offset_pat_index() helper Matthew Auld
2023-11-03 16:02 ` [igt-dev] [PATCH i-g-t v7 08/15] lib/intel_blt: support pat_index Matthew Auld
2023-11-03 16:02 ` [igt-dev] [PATCH i-g-t v7 09/15] lib/intel_buf: " Matthew Auld
2023-11-03 16:02 ` [igt-dev] [PATCH i-g-t v7 10/15] lib/xe_ioctl: update vm_bind to account for pat_index Matthew Auld
2023-11-03 16:02 ` Matthew Auld [this message]
2023-11-03 16:02 ` [igt-dev] [PATCH i-g-t v7 12/15] lib/intel_blt: tidy up alignment usage Matthew Auld
2023-11-03 16:02 ` [igt-dev] [PATCH i-g-t v7 13/15] lib/intel_batchbuffer: extend to include optional alignment Matthew Auld
2023-11-03 16:02 ` [igt-dev] [PATCH i-g-t v7 14/15] tests/xe: add some vm_bind pat_index tests Matthew Auld
2023-11-03 16:02 ` [igt-dev] [PATCH i-g-t v7 15/15] tests/intel-ci/xe: add pat and caching related tests Matthew Auld
2023-11-03 17:42 ` [igt-dev] ✓ Fi.CI.BAT: success for PAT and cache coherency support (rev7) Patchwork
2023-11-03 18:18 ` [igt-dev] ✗ CI.xeBAT: failure " Patchwork
2023-11-04 11:37 ` [igt-dev] ✗ Fi.CI.IGT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231103160237.405122-12-matthew.auld@intel.com \
--to=matthew.auld@intel.com \
--cc=igt-dev@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox