Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Matthew Auld <matthew.auld@intel.com>
To: igt-dev@lists.freedesktop.org
Subject: [igt-dev] [PATCH i-g-t v8 05/15] tests/xe/mmap: add some tests for explicit cpu_caching
Date: Tue,  7 Nov 2023 11:48:06 +0000	[thread overview]
Message-ID: <20231107114816.190793-6-matthew.auld@intel.com> (raw)
In-Reply-To: <20231107114816.190793-1-matthew.auld@intel.com>

Ensure the various invalid combinations are rejected. Also ensure we can
mmap and fault anything that is valid.

v2: Rebase on coh_mode removal.

Signed-off-by: Matthew Auld <matthew.auld@intel.com>
Cc: José Roberto de Souza <jose.souza@intel.com>
Cc: Pallavi Mishra <pallavi.mishra@intel.com>
Reviewed-by: Pallavi Mishra <pallavi.mishra@intel.com>
---
 tests/intel/xe_mmap.c | 51 +++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 51 insertions(+)

diff --git a/tests/intel/xe_mmap.c b/tests/intel/xe_mmap.c
index 7e7e43c00..bd894f26f 100644
--- a/tests/intel/xe_mmap.c
+++ b/tests/intel/xe_mmap.c
@@ -199,6 +199,54 @@ static void test_small_bar(int fd)
 	gem_close(fd, bo);
 }
 
+static void assert_caching(int fd, uint64_t flags, uint16_t cpu_caching, bool fail)
+{
+	uint64_t size = xe_get_default_alignment(fd);
+	uint64_t mmo;
+	uint32_t handle;
+	uint32_t *map;
+	bool ret;
+
+	ret = __xe_bo_create_caching(fd, 0, size, flags, cpu_caching, &handle);
+	igt_assert(ret == fail);
+
+	if (fail)
+		return;
+
+	mmo = xe_bo_mmap_offset(fd, handle);
+	map = mmap(NULL, size, PROT_WRITE, MAP_SHARED, fd, mmo);
+	igt_assert(map != MAP_FAILED);
+	map[0] = 0xdeadbeaf;
+	gem_close(fd, handle);
+}
+
+/**
+ * SUBTEST: cpu-caching
+ * Description: Test explicit cpu_caching, including mmap behaviour.
+ * Test category: functionality test
+ */
+static void test_cpu_caching(int fd)
+{
+	if (vram_memory(fd, 0)) {
+		assert_caching(fd, vram_memory(fd, 0),
+			       DRM_XE_GEM_CPU_CACHING_WC, false);
+		assert_caching(fd, vram_memory(fd, 0) | system_memory(fd),
+			       DRM_XE_GEM_CPU_CACHING_WC, false);
+
+		assert_caching(fd, vram_memory(fd, 0),
+			       DRM_XE_GEM_CPU_CACHING_WB, true);
+		assert_caching(fd, vram_memory(fd, 0) | system_memory(fd),
+			       DRM_XE_GEM_CPU_CACHING_WB, true);
+	}
+
+	assert_caching(fd, system_memory(fd), DRM_XE_GEM_CPU_CACHING_WB, false);
+	assert_caching(fd, system_memory(fd), DRM_XE_GEM_CPU_CACHING_WC, false);
+
+	assert_caching(fd, system_memory(fd), -1, true);
+	assert_caching(fd, system_memory(fd), 0, true);
+	assert_caching(fd, system_memory(fd), DRM_XE_GEM_CPU_CACHING_WC + 1, true);
+}
+
 igt_main
 {
 	int fd;
@@ -230,6 +278,9 @@ igt_main
 		test_small_bar(fd);
 	}
 
+	igt_subtest("cpu-caching")
+		test_cpu_caching(fd);
+
 	igt_fixture
 		drm_close_driver(fd);
 }
-- 
2.41.0

  parent reply	other threads:[~2023-11-07 11:48 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-07 11:48 [igt-dev] [PATCH i-g-t v8 00/15] PAT and cache coherency support Matthew Auld
2023-11-07 11:48 ` [igt-dev] [PATCH i-g-t v8 01/15] drm-uapi/xe_drm: sync to get pat and coherency bits Matthew Auld
2023-11-07 11:48 ` [igt-dev] [PATCH i-g-t v8 02/15] lib/igt_fb: mark buffers as SCANOUT Matthew Auld
2023-11-07 11:48 ` [igt-dev] [PATCH i-g-t v8 03/15] lib/igt_draw: " Matthew Auld
2023-11-07 11:48 ` [igt-dev] [PATCH i-g-t v8 04/15] lib/xe: support explicit cpu_caching gem_create Matthew Auld
2023-11-07 11:48 ` Matthew Auld [this message]
2023-11-07 11:48 ` [igt-dev] [PATCH i-g-t v8 06/15] lib/intel_pat: add helpers for common pat_index modes Matthew Auld
2023-11-07 11:48 ` [igt-dev] [PATCH i-g-t v8 07/15] lib/allocator: add get_offset_pat_index() helper Matthew Auld
2023-11-07 11:48 ` [igt-dev] [PATCH i-g-t v8 08/15] lib/intel_blt: support pat_index Matthew Auld
2023-11-07 11:48 ` [igt-dev] [PATCH i-g-t v8 09/15] lib/intel_buf: " Matthew Auld
2023-11-07 11:48 ` [igt-dev] [PATCH i-g-t v8 10/15] lib/xe_ioctl: update vm_bind to account for pat_index Matthew Auld
2023-11-07 11:48 ` [igt-dev] [PATCH i-g-t v8 11/15] lib/intel_allocator: treat default_alignment as the minimum Matthew Auld
2023-11-07 11:48 ` [igt-dev] [PATCH i-g-t v8 12/15] lib/intel_blt: tidy up alignment usage Matthew Auld
2023-11-07 11:48 ` [igt-dev] [PATCH i-g-t v8 13/15] lib/intel_batchbuffer: extend to include optional alignment Matthew Auld
2023-11-07 11:48 ` [igt-dev] [PATCH i-g-t v8 14/15] tests/xe: add some vm_bind pat_index tests Matthew Auld
2023-11-07 11:48 ` [igt-dev] [PATCH i-g-t v8 15/15] tests/intel-ci/xe: add pat and caching related tests Matthew Auld
2023-11-07 12:55 ` [igt-dev] ✓ Fi.CI.BAT: success for PAT and cache coherency support (rev8) Patchwork
2023-11-07 13:26 ` [igt-dev] ✗ CI.xeBAT: failure " Patchwork
2023-11-08  2:19 ` [igt-dev] ✓ Fi.CI.IGT: success " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231107114816.190793-6-matthew.auld@intel.com \
    --to=matthew.auld@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox