From: Harry Wentland <harry.wentland@amd.com>
To: <igt-dev@lists.freedesktop.org>
Subject: [igt-dev] [RFC PATCH v3 10/12] lib/igt_kms: Add support for DATA colorop property
Date: Wed, 8 Nov 2023 11:39:59 -0500 [thread overview]
Message-ID: <20231108164006.106967-11-harry.wentland@amd.com> (raw)
In-Reply-To: <20231108164006.106967-1-harry.wentland@amd.com>
Signed-off-by: Harry Wentland <harry.wentland@amd.com>
---
lib/igt_kms.c | 33 +++++++++++++++++++++++++++++++++
lib/igt_kms.h | 12 ++++++++----
2 files changed, 41 insertions(+), 4 deletions(-)
diff --git a/lib/igt_kms.c b/lib/igt_kms.c
index 504ceaf04b2c..84b4a54b4828 100644
--- a/lib/igt_kms.c
+++ b/lib/igt_kms.c
@@ -689,6 +689,7 @@ const char * const igt_colorop_prop_names[IGT_NUM_COLOROP_PROPS] = {
[IGT_COLOROP_TYPE] = "TYPE",
[IGT_COLOROP_BYPASS] = "BYPASS",
[IGT_COLOROP_CURVE_1D_TYPE] = "CURVE_1D_TYPE",
+ [IGT_COLOROP_DATA] = "DATA",
[IGT_COLOROP_NEXT] = "NEXT",
};
@@ -4210,6 +4211,38 @@ igt_plane_replace_prop_blob(igt_plane_t *plane, enum igt_atomic_plane_properties
igt_plane_set_prop_changed(plane, prop);
}
+/**
+ * igt_colorop_replace_prop_blob:
+ * @plane: colorop to set property on.
+ * @prop: property for which the blob will be replaced.
+ * @ptr: Pointer to contents for the property.
+ * @length: Length of contents.
+ *
+ * This function will destroy the old property blob for the given property,
+ * and will create a new property blob with the values passed to this function.
+ *
+ * The new property blob will be committed when you call igt_display_commit(),
+ * igt_display_commit2() or igt_display_commit_atomic().
+ */
+void
+igt_colorop_replace_prop_blob(igt_colorop_t *colorop, enum igt_atomic_colorop_properties prop, const void *ptr, size_t length)
+{
+ igt_display_t *display = colorop->plane->pipe->display;
+ uint64_t *blob = &colorop->values[prop];
+ uint32_t blob_id = 0;
+
+ if (*blob != 0)
+ igt_assert(drmModeDestroyPropertyBlob(display->drm_fd,
+ *blob) == 0);
+
+ if (length > 0)
+ igt_assert(drmModeCreatePropertyBlob(display->drm_fd,
+ ptr, length, &blob_id) == 0);
+
+ *blob = blob_id;
+ igt_colorop_set_prop_changed(colorop, prop);
+}
+
/**
* igt_colorop_try_prop_enum:
* @colorop: Target colorop.
diff --git a/lib/igt_kms.h b/lib/igt_kms.h
index e121f0ca6e41..405f8850098c 100644
--- a/lib/igt_kms.h
+++ b/lib/igt_kms.h
@@ -334,6 +334,7 @@ enum igt_atomic_colorop_properties {
IGT_COLOROP_TYPE,
IGT_COLOROP_BYPASS,
IGT_COLOROP_CURVE_1D_TYPE,
+ IGT_COLOROP_DATA,
IGT_COLOROP_NEXT,
IGT_NUM_COLOROP_PROPS
};
@@ -831,12 +832,15 @@ extern void igt_plane_set_prop_enum(igt_plane_t *plane,
enum igt_atomic_plane_properties prop,
const char *val);
-
+extern void igt_plane_replace_prop_blob(igt_plane_t *plane,
+ enum igt_atomic_plane_properties prop,
+ const void *ptr, size_t length);
extern bool igt_plane_is_valid_colorop(igt_plane_t *plane, igt_colorop_t *colorop);
extern void igt_plane_set_color_pipeline(igt_plane_t *plane, igt_colorop_t *colorop);
+
/**
* igt_colorop_has_prop:
* @colorop: colorop to check.
@@ -878,9 +882,9 @@ extern void igt_colorop_set_prop_enum(igt_colorop_t *colorop,
enum igt_atomic_colorop_properties prop,
const char *val);
-extern void igt_plane_replace_prop_blob(igt_plane_t *plane,
- enum igt_atomic_plane_properties prop,
- const void *ptr, size_t length);
+extern void igt_colorop_replace_prop_blob(igt_colorop_t *colorop,
+ enum igt_atomic_colorop_properties prop,
+ const void *ptr, size_t length);
/**
* igt_output_has_prop:
--
2.42.0
next prev parent reply other threads:[~2023-11-08 16:40 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-08 16:39 [igt-dev] [RFC PATCH v3 00/12] IGT tests for the KMS Color Pipeline API Harry Wentland
2023-11-08 16:39 ` [igt-dev] [RFC PATCH v3 01/12] lib/drmtest: Add is_vkms_device() Harry Wentland
2023-11-08 16:39 ` [igt-dev] [RFC PATCH v3 02/12] lib/igt_kms: Introduce DRM_CLIENT_CAP_PLANE_COLOR_PIPELINE Harry Wentland
2023-11-08 16:39 ` [igt-dev] [RFC PATCH v3 03/12] include/drm-uapi: Add COLOROP object Harry Wentland
2023-11-08 16:39 ` [igt-dev] [RFC PATCH v3 04/12] lib/igt_kms: Introduce drm_colorop and COLOR_PIPELINE Harry Wentland
2023-11-08 16:39 ` [igt-dev] [RFC PATCH v3 05/12] tests/kms_properties: Add colorop properties test Harry Wentland
2023-11-08 16:39 ` [igt-dev] [RFC PATCH v3 06/12] igt/color: Add SW color transform functionality Harry Wentland
2023-11-08 16:39 ` [igt-dev] [RFC PATCH v3 07/12] lib/igt_fb: Add copy_fb function Harry Wentland
2023-11-08 16:39 ` [igt-dev] [RFC PATCH v3 08/12] tests/kms_colorop: Add kms_colorop tests Harry Wentland
2023-11-08 16:39 ` [igt-dev] [RFC PATCH v3 09/12] drm-uapi: Add 3x4 CTM Harry Wentland
2023-11-08 16:39 ` Harry Wentland [this message]
2023-11-08 16:40 ` [igt-dev] [RFC PATCH v3 11/12] lib/igt_color: Add support for 3x4 matrices Harry Wentland
2023-11-08 16:40 ` [igt-dev] [RFC PATCH v3 12/12] tests/kms_colorop: Add 3x4 CTM tests Harry Wentland
2023-11-08 17:56 ` [igt-dev] ✗ GitLab.Pipeline: warning for IGT tests for the KMS Color Pipeline API (rev3) Patchwork
2023-11-08 18:23 ` [igt-dev] ✗ Fi.CI.BAT: failure " Patchwork
2023-11-08 18:40 ` [igt-dev] ✓ CI.xeBAT: success " Patchwork
2024-02-09 16:32 ` [igt-dev] [RFC PATCH v3 00/12] IGT tests for the KMS Color Pipeline API Modem, Bhanuprakash
2024-02-09 16:50 ` Harry Wentland
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231108164006.106967-11-harry.wentland@amd.com \
--to=harry.wentland@amd.com \
--cc=igt-dev@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox