From: "Zbigniew Kempczyński" <zbigniew.kempczynski@intel.com>
To: igt-dev@lists.freedesktop.org
Cc: Matthew Auld <matthew.auld@intel.com>
Subject: [igt-dev] [PATCH i-g-t] tests/xe_evict_ccs: Disable compression on platforms without flatccs
Date: Thu, 9 Nov 2023 18:15:54 +0100 [thread overview]
Message-ID: <20231109171554.313952-1-zbigniew.kempczynski@intel.com> (raw)
Platforms like PVC don't use flatccs compression so on them exercise
eviction only. Rename all subtests and remove "-ccs-" part in it.
Signed-off-by: Zbigniew Kempczyński <zbigniew.kempczynski@intel.com>
Cc: Matthew Auld <matthew.auld@intel.com>
---
tests/intel-ci/xe-fast-feedback.testlist | 4 ++--
tests/intel/xe_evict_ccs.c | 17 ++++++++++++-----
2 files changed, 14 insertions(+), 7 deletions(-)
diff --git a/tests/intel-ci/xe-fast-feedback.testlist b/tests/intel-ci/xe-fast-feedback.testlist
index f11761ac85..e9ff5cb4fe 100644
--- a/tests/intel-ci/xe-fast-feedback.testlist
+++ b/tests/intel-ci/xe-fast-feedback.testlist
@@ -26,8 +26,8 @@ igt@xe_evict@evict-small-external-cm
igt@xe_evict@evict-small-multi-vm
igt@xe_evict@evict-small-multi-vm-cm
igt@xe_evict@evict-threads-small
-igt@xe_evict_ccs@evict-ccs-overcommit-simple
-igt@xe_evict_ccs@evict-ccs-overcommit-parallel-nofree-samefd
+igt@xe_evict_ccs@evict-overcommit-simple
+igt@xe_evict_ccs@evict-overcommit-parallel-nofree-samefd
igt@xe_exec_balancer@twice-virtual-basic
igt@xe_exec_balancer@no-exec-virtual-basic
igt@xe_exec_balancer@twice-cm-virtual-basic
diff --git a/tests/intel/xe_evict_ccs.c b/tests/intel/xe_evict_ccs.c
index 4f2876ecb2..8a98aae8f3 100644
--- a/tests/intel/xe_evict_ccs.c
+++ b/tests/intel/xe_evict_ccs.c
@@ -380,15 +380,15 @@ static void evict_ccs(int fd, uint32_t flags, const struct param *param)
/**
*
- * SUBTEST: evict-ccs-overcommit-simple
- * Description: FlatCCS eviction test.
+ * SUBTEST: evict-overcommit-simple
+ * Description: Eviction test - exercises FlatCCS if possible.
* Feature: flatccs
* Test category: stress test
*/
/**
*
- * SUBTEST: evict-ccs-overcommit-%s-%s-%s
- * Description: FlatCCS eviction test.
+ * SUBTEST: evict-overcommit-%s-%s-%s
+ * Description: Eviction test - exercises FlatCCS if possible.
* Feature: flatccs
* Test category: stress test
*
@@ -490,6 +490,7 @@ igt_main_args("bdDn:p:s:S:V", NULL, help_str, opt_handler, NULL)
{ },
};
uint64_t vram_size;
+ bool has_flatccs;
int fd;
igt_fixture {
@@ -497,14 +498,20 @@ igt_main_args("bdDn:p:s:S:V", NULL, help_str, opt_handler, NULL)
igt_require(xe_has_vram(fd));
vram_size = xe_visible_vram_size(fd, 0);
igt_assert(vram_size);
+ has_flatccs = HAS_FLATCCS(intel_get_drm_devid(fd));
}
igt_fixture
intel_allocator_multiprocess_start();
for (const struct ccs *s = ccs; s->name; s++) {
- igt_subtest_f("evict-ccs-overcommit-%s", s->name)
+ igt_subtest_f("evict-overcommit-%s", s->name) {
+ if (!params.disable_compression && !has_flatccs) {
+ igt_info("Device has no flatccs, disabling compression\n");
+ params.disable_compression = true;
+ }
evict_ccs(fd, s->flags, ¶ms);
+ }
}
igt_fixture {
--
2.34.1
next reply other threads:[~2023-11-09 17:16 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-09 17:15 Zbigniew Kempczyński [this message]
2023-11-09 17:35 ` [igt-dev] [PATCH i-g-t] tests/xe_evict_ccs: Disable compression on platforms without flatccs Matthew Auld
2023-11-14 6:35 ` Zbigniew Kempczyński
2023-11-09 18:39 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2023-11-09 19:38 ` [igt-dev] ✗ CI.xeBAT: failure " Patchwork
2023-11-09 22:49 ` [igt-dev] ✗ Fi.CI.IGT: " Patchwork
2023-11-14 10:09 ` Zbigniew Kempczyński
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231109171554.313952-1-zbigniew.kempczynski@intel.com \
--to=zbigniew.kempczynski@intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=matthew.auld@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox