From: Vinod Govindapillai <vinod.govindapillai@intel.com>
To: igt-dev@lists.freedesktop.org
Cc: juha-pekka.heikkila@intel.com
Subject: [igt-dev] [PATCH i-g-t v1 1/1] tests/kms_flip: add possibility to ignore long HPDs
Date: Tue, 14 Nov 2023 10:45:04 +0200 [thread overview]
Message-ID: <20231114084504.159561-2-vinod.govindapillai@intel.com> (raw)
In-Reply-To: <20231114084504.159561-1-vinod.govindapillai@intel.com>
In some CI environments, spurious long HPDs are impacting the
kms_flip test results. The provision to set ignore long HPDs was
not being used by the kms_flip tests. Call igt_display_require
for kms_flip as well which will track the usage of environment
variable IGT_KMS_IGNORE_HPD
Signed-off-by: Vinod Govindapillai <vinod.govindapillai@intel.com>
---
tests/kms_flip.c | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/tests/kms_flip.c b/tests/kms_flip.c
index fc7cee050..c32b19412 100755
--- a/tests/kms_flip.c
+++ b/tests/kms_flip.c
@@ -2116,12 +2116,13 @@ igt_main_args("e", NULL, help_str, opt_handler, NULL)
{ 0, TEST_BO_TOOBIG | TEST_NO_2X_OUTPUT, "bo-too-big" },
{ 10, TEST_FLIP | TEST_SUSPEND, "flip-vs-suspend" },
};
+ igt_display_t display;
int i;
igt_fixture {
drm_fd = drm_open_driver_master(DRIVER_ANY);
- igt_enable_connectors(drm_fd);
+ igt_display_require(&display, drm_fd);
kmstest_set_vt_graphics_mode();
igt_install_exit_handler(kms_flip_exit_handler);
@@ -2192,6 +2193,8 @@ igt_main_args("e", NULL, help_str, opt_handler, NULL)
}
igt_stop_signal_helper();
- igt_fixture
+ igt_fixture {
+ igt_display_fini(&display);
drm_close_driver(drm_fd);
+ }
}
--
2.34.1
next prev parent reply other threads:[~2023-11-14 8:45 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-14 8:45 [igt-dev] [PATCH i-g-t v1 0/1] tests/kms_flip: add provision to ignore long HPDs Vinod Govindapillai
2023-11-14 8:45 ` Vinod Govindapillai [this message]
2023-11-22 8:20 ` [igt-dev] [PATCH i-g-t v1 1/1] tests/kms_flip: add possibility " Karthik B S
2023-11-14 9:22 ` [igt-dev] ✓ CI.xeBAT: success for tests/kms_flip: add provision " Patchwork
2023-11-14 9:31 ` [igt-dev] ✓ Fi.CI.BAT: " Patchwork
2023-11-14 15:08 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
2023-11-22 12:58 ` [igt-dev] ✓ Fi.CI.IGT: success " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231114084504.159561-2-vinod.govindapillai@intel.com \
--to=vinod.govindapillai@intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=juha-pekka.heikkila@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox