From: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
To: igt-dev@lists.freedesktop.org
Subject: [igt-dev] [i-g-t V3 1/2] lib/igt_kms: Don't read max dotclock on non-display platforms
Date: Thu, 16 Nov 2023 10:21:12 +0530 [thread overview]
Message-ID: <20231116045113.1590173-1-bhanuprakash.modem@intel.com> (raw)
On non-display platforms, there is no point in checking for
max dotclock.
V2: Fix resource leak
V3: Drop unwanted 'else'
Fixes: https://gitlab.freedesktop.org/drm/intel/-/issues/9672
Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
lib/igt_kms.c | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/lib/igt_kms.c b/lib/igt_kms.c
index 89510ff22..b2208ac54 100644
--- a/lib/igt_kms.c
+++ b/lib/igt_kms.c
@@ -6055,10 +6055,18 @@ int igt_get_max_dotclock(int fd)
char buf[4096];
char *s;
int dir, res, max_dotclock = 0;
+ drmModeRes *resources;
if (!is_intel_device(fd))
return max_dotclock;
+ /* If there is no display, then no point to check for dotclock. */
+ resources = drmModeGetResources(fd);
+ if (!resources)
+ return max_dotclock;
+
+ drmModeFreeResources(resources);
+
dir = igt_debugfs_dir(fd);
igt_require(dir);
--
2.40.0
next reply other threads:[~2023-11-16 5:01 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-16 4:51 Bhanuprakash Modem [this message]
2023-11-16 4:51 ` [igt-dev] [i-g-t V3 2/2] lib/igt_kms: Read max dotclock info from i915_cdclk_info only Bhanuprakash Modem
2023-11-16 6:15 ` [igt-dev] ✓ Fi.CI.BAT: success for series starting with [i-g-t,V3,1/2] lib/igt_kms: Don't read max dotclock on non-display platforms Patchwork
2023-11-17 7:03 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
2023-11-17 11:09 ` [igt-dev] ✓ CI.xeBAT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231116045113.1590173-1-bhanuprakash.modem@intel.com \
--to=bhanuprakash.modem@intel.com \
--cc=igt-dev@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox