Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Swati Sharma <swati2.sharma@intel.com>
To: igt-dev@lists.freedesktop.org
Subject: [igt-dev] [PATCH i-g-t] tests/kms_feature_discovery: update display-1x
Date: Fri, 17 Nov 2023 21:28:02 +0530	[thread overview]
Message-ID: <20231117155802.100269-1-swati2.sharma@intel.com> (raw)

Use same logic to detect 1x display as 2x, 3x and 4x displays.

Signed-off-by: Swati Sharma <swati2.sharma@intel.com>
---
 tests/kms_feature_discovery.c | 20 ++++++--------------
 1 file changed, 6 insertions(+), 14 deletions(-)

diff --git a/tests/kms_feature_discovery.c b/tests/kms_feature_discovery.c
index 428f97ffe..9ed7ab5cd 100644
--- a/tests/kms_feature_discovery.c
+++ b/tests/kms_feature_discovery.c
@@ -29,14 +29,6 @@
  *		The subtests here should only skip or pass,
  *		anything else means we have a serious problem.
  *
- * SUBTEST: display
- * Description: Make sure that we have display support with
- * 		some outputs connected.
- * Driver requirement: i915, xe
- * Functionality: feature_discovery
- * Mega feature: General Display Features
- * Test category: functionality test
- *
  * SUBTEST: display-%dx
  * Description: Make sure that we have display support with %arg[1]
  * 		outputs connected.
@@ -73,7 +65,7 @@
  * Mega feature: General Display Features
  * Test category: functionality test
  *
- * arg[1].values: 2, 3, 4
+ * arg[1].values: 1, 2, 3, 4
  */
 
 #include "igt.h"
@@ -104,11 +96,6 @@ igt_main {
 			igt_display_require(&display, fd);
 		}
 
-		igt_describe("Make sure that we have display support with some outputs connected.");
-		igt_subtest("display") {
-			/* will skip because of the fixture */
-		}
-
 		igt_subtest_group {
 			volatile int output_count = 0;
 			igt_output_t *output;
@@ -131,6 +118,11 @@ igt_main {
 				}
 			}
 
+			igt_describe("Make sure that we have display support with some outputs connected.");
+			igt_subtest("display-1x") {
+				igt_require(output_count >= 1);
+			}
+
 			igt_describe("Make sure that we can use at least 2 outputs at the same time.");
 			igt_subtest("display-2x") {
 				igt_require(output_count >= 2);
-- 
2.25.1

             reply	other threads:[~2023-11-17 15:56 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-17 15:58 Swati Sharma [this message]
2023-11-17 16:59 ` [igt-dev] ✗ GitLab.Pipeline: warning for tests/kms_feature_discovery: update display-1x Patchwork
2023-11-17 17:34 ` [igt-dev] ✓ Fi.CI.BAT: success " Patchwork
2023-11-17 19:19 ` [igt-dev] ✗ CI.xeBAT: failure " Patchwork
2023-11-18 13:42 ` [igt-dev] ✗ Fi.CI.IGT: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231117155802.100269-1-swati2.sharma@intel.com \
    --to=swati2.sharma@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox