From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.136]) by gabe.freedesktop.org (Postfix) with ESMTPS id A4D4110E4CF for ; Tue, 28 Nov 2023 10:51:00 +0000 (UTC) Received: from linux.intel.com (maurocar-mobl2.ger.corp.intel.com [10.94.248.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by linux.intel.com (Postfix) with ESMTPS id 7A775580E3F for ; Tue, 28 Nov 2023 02:50:59 -0800 (PST) Received: from maurocar by linux.intel.com with local (Exim 4.96.2) (envelope-from ) id 1r7vg9-0006ML-2D for igt-dev@lists.freedesktop.org; Tue, 28 Nov 2023 11:50:57 +0100 From: Mauro Carvalho Chehab To: igt-dev@lists.freedesktop.org Date: Tue, 28 Nov 2023 11:48:59 +0100 Message-ID: <20231128105054.24317-5-mauro.chehab@linux.intel.com> In-Reply-To: <20231128105054.24317-1-mauro.chehab@linux.intel.com> References: <20231128105054.24317-1-mauro.chehab@linux.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [igt-dev] [PATCH i-g-t 4/5] scripts/test_list.py: fix indent at get_subtests() List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" List-ID: From: Mauro Carvalho Chehab The indent there is wrong, causing this warning: scripts/test_list.py:1041:46: W0631: Using possibly undefined loop variable 'test' (undefined-loop-variable) This issue also affects testlist generation, as tests will be missing there. Signed-off-by: Mauro Carvalho Chehab --- scripts/test_list.py | 54 ++++++++++++++++++++++---------------------- 1 file changed, 27 insertions(+), 27 deletions(-) diff --git a/scripts/test_list.py b/scripts/test_list.py index 79b48813171b..3954e883ada3 100644 --- a/scripts/test_list.py +++ b/scripts/test_list.py @@ -1038,43 +1038,43 @@ class TestList: subtest_array += self.expand_subtest(fname, test_name, test, True) - subtest_array.sort(key = lambda x : x.get('_summary_')) + subtest_array.sort(key = lambda x : x.get('_summary_')) - for subtest in subtest_array: - if self.__filter_subtest(self.doc[test], subtest, True): - continue + for subtest in subtest_array: + if self.__filter_subtest(self.doc[test], subtest, True): + continue - if sort_field: - if sort_field in subtest: - if expand: - test_list = expand.split(subtest[sort_field]) + if sort_field: + if sort_field in subtest: + if expand: + test_list = expand.split(subtest[sort_field]) - for test_elem in test_list: - if test_elem not in subtests: - subtests[test_elem] = [] - if order: - subtests[test_elem].append((subtest["_summary_"], test_list)) - else: - subtests[test_elem].append(subtest["_summary_"]) + for test_elem in test_list: + if test_elem not in subtests: + subtests[test_elem] = [] + if order: + subtests[test_elem].append((subtest["_summary_"], test_list)) + else: + subtests[test_elem].append(subtest["_summary_"]) + else: + if subtest[sort_field] not in subtests: + subtests[subtest[sort_field]] = [] + if order: + subtests[test_elem].append((subtest["_summary_"], [subtest[sort_field]])) + else: + subtests[subtest[sort_field]].append(subtest["_summary_"]) else: - if subtest[sort_field] not in subtests: - subtests[subtest[sort_field]] = [] - if order: - subtests[test_elem].append((subtest["_summary_"], [subtest[sort_field]])) - else: - subtests[subtest[sort_field]].append(subtest["_summary_"]) + if order: + subtests[test_elem].append((subtest["_summary_"], [subtest[sort_field]])) + else: + subtests[""].append(subtest["_summary_"]) + else: if order: subtests[test_elem].append((subtest["_summary_"], [subtest[sort_field]])) else: subtests[""].append(subtest["_summary_"]) - else: - if order: - subtests[test_elem].append((subtest["_summary_"], [subtest[sort_field]])) - else: - subtests[""].append(subtest["_summary_"]) - if order: for group, tests in subtests.items(): prefix_tests = [] -- 2.42.0