Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Jesse Zhang <jesse.zhang@amd.com>
To: <igt-dev@lists.freedesktop.org>
Cc: Luben Tuikov <luben.tuikov@amd.com>,
	Alex Deucher <alexander.deucher@amd.com>,
	Christian Koenig <christian.koenig@amd.com>
Subject: [igt-dev] [PATCH i-g-t] tests/amd_security: fix secure bounce test issue
Date: Mon, 4 Dec 2023 11:00:07 +0800	[thread overview]
Message-ID: <20231204030007.326044-1-jesse.zhang@amd.com> (raw)

When it copy from scr (bo) to destination (bo2),
and move bo2 from vram to gtt.
Then it need to copy from bo2(src)
to bo (destination) for verification.

Cc: Vitaly Prosyak <vitaly.prosyak@amd.com>
Cc: Luben Tuikov <luben.tuikov@amd.com>
Cc: Alex Deucher <alexander.deucher@amd.com>
Cc: Christian Koenig <christian.koenig@amd.com>
Cc: Kamil Konieczny <kamil.konieczny@linux.intel.com>

Signed-off-by: Jesse Zhang <Jesse.Zhang@amd.com>
---
 tests/amdgpu/amd_security.c | 17 ++++++++++++-----
 1 file changed, 12 insertions(+), 5 deletions(-)

diff --git a/tests/amdgpu/amd_security.c b/tests/amdgpu/amd_security.c
index d1146a7ce..7fb6df3b6 100644
--- a/tests/amdgpu/amd_security.c
+++ b/tests/amdgpu/amd_security.c
@@ -99,7 +99,7 @@ static void
 amdgpu_bo_lcopy(amdgpu_device_handle device,
 		struct amdgpu_ring_context *ring_context,
 		const struct amdgpu_ip_block_version *ip_block, uint32_t size,
-		uint32_t secure)
+		uint32_t secure, int direction)
 {
 	ring_context->pm4 = calloc(PACKET_LCOPY_SIZE, sizeof(*ring_context->pm4));
 	ring_context->secure = secure;
@@ -108,8 +108,15 @@ amdgpu_bo_lcopy(amdgpu_device_handle device,
 	ring_context->res_cnt = 2;
 	igt_assert(ring_context->pm4);
 
-	amdgpu_sdma_lcopy(ring_context->pm4, ring_context->bo_mc2,
-			ring_context->bo_mc, size, secure);
+	if (direction) {
+		/* copy from bo2 to bo */
+		amdgpu_sdma_lcopy(ring_context->pm4, ring_context->bo_mc,
+				ring_context->bo_mc2, size, secure);
+	} else {
+		/* copy from bo to bo bo2 */
+		amdgpu_sdma_lcopy(ring_context->pm4, ring_context->bo_mc2,
+				ring_context->bo_mc, size, secure);
+	}
 	amdgpu_test_exec_cs_helper(device, ip_block->type, ring_context, 0);
 	free(ring_context->pm4);
 }
@@ -222,7 +229,7 @@ amdgpu_secure_bounce(amdgpu_device_handle device_handle, int fd,
 	ring_context->resources[1] = ring_context->bo;	// Alice
 
 	amdgpu_bo_lcopy(device_handle, ring_context, ip_block, SECURE_BUFFER_SIZE,
-			secure == true ? 1 : 0);
+			secure == true ? 1 : 0, 0);
 
 	/* Verify the contents of Bob. */
 	for (pp = (__typeof__(pp))ring_context->bo2_cpu;
@@ -249,7 +256,7 @@ amdgpu_secure_bounce(amdgpu_device_handle device_handle, int fd,
 
 	/* sDMA TMZ copy from Bob to Alice. */
 	amdgpu_bo_lcopy(device_handle, ring_context, ip_block, SECURE_BUFFER_SIZE,
-			secure == true ? 1 : 0);
+			secure == true ? 1 : 0, 1);
 
 	/* Verify the contents of Alice */
 	for (pp = (__typeof__(pp))ring_context->bo_cpu;
-- 
2.25.1

             reply	other threads:[~2023-12-04  3:00 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-12-04  3:00 Jesse Zhang [this message]
2023-12-04  3:51 ` [igt-dev] ✓ CI.xeBAT: success for tests/amd_security: fix secure bounce test issue Patchwork
2023-12-04  3:53 ` [igt-dev] ✓ Fi.CI.BAT: " Patchwork
2023-12-04  5:09 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
2024-01-10  9:13 ` [PATCH i-g-t] " Zhang, Jesse(Jie)
2024-01-10 10:15   ` Christian König
2024-01-11  0:39     ` vitaly prosyak
2024-01-10 12:57 ` ✗ Fi.CI.BUILD: failure for tests/amd_security: fix secure bounce test issue (rev2) Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231204030007.326044-1-jesse.zhang@amd.com \
    --to=jesse.zhang@amd.com \
    --cc=alexander.deucher@amd.com \
    --cc=christian.koenig@amd.com \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=luben.tuikov@amd.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox