From: "Zbigniew Kempczyński" <zbigniew.kempczynski@intel.com>
To: janga.rahul.kumar@intel.com
Cc: igt-dev@lists.freedesktop.org, ramadevi.gandi@intel.com
Subject: Re: [igt-dev] [PATCH i-g-t 1/3] lib/intel_compute_square_kernels: Add xe2lpg compute sqaure kernel
Date: Mon, 4 Dec 2023 08:58:00 +0100 [thread overview]
Message-ID: <20231204075800.smdpsc7nprysd2ae@zkempczy-mobl2> (raw)
In-Reply-To: <20231201113507.3535939-2-janga.rahul.kumar@intel.com>
On Fri, Dec 01, 2023 at 05:05:05PM +0530, janga.rahul.kumar@intel.com wrote:
> From: Janga Rahul Kumar <janga.rahul.kumar@intel.com>
>
> Add xe2lpg compute sqaure kernel created using iga64.
>
> Signed-off-by: Janga Rahul Kumar <janga.rahul.kumar@intel.com>
> ---
> lib/intel_compute_square_kernels.c | 36 ++++++++++++++++++++++++++++++
> 1 file changed, 36 insertions(+)
>
> diff --git a/lib/intel_compute_square_kernels.c b/lib/intel_compute_square_kernels.c
> index 3d5b1ad47..682fdfcf6 100644
> --- a/lib/intel_compute_square_kernels.c
> +++ b/lib/intel_compute_square_kernels.c
> @@ -183,6 +183,37 @@ static const unsigned char xehpc_kernel_square_bin[] = {
> 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
> };
>
> +static const unsigned char xe2lpg_kernel_square_bin[] = {
> + 0x65, 0x00, 0x00, 0x80, 0x20, 0x82, 0x05, 0x7f, 0x04, 0x00, 0x00, 0x02,
> + 0xc0, 0xff, 0xff, 0xff, 0x40, 0x19, 0x00, 0x80, 0x20, 0x82, 0x05, 0x7f,
> + 0x04, 0x7f, 0x00, 0x02, 0x00, 0x00, 0x00, 0x00, 0x31, 0x22, 0x03, 0x80,
> + 0x00, 0x00, 0x0c, 0x05, 0x8f, 0x7f, 0x00, 0xfa, 0x03, 0x00, 0x70, 0xf6,
> + 0x01, 0x00, 0x00, 0x00, 0x00, 0x42, 0x01, 0x00, 0x00, 0x00, 0x00, 0x20,
> + 0x04, 0x00, 0x00, 0x00, 0x66, 0x09, 0x00, 0x80, 0x20, 0x82, 0x01, 0x80,
> + 0x00, 0x80, 0x00, 0x02, 0xc0, 0x04, 0x00, 0x40, 0x41, 0x22, 0x03, 0x80,
> + 0x60, 0x06, 0x01, 0x20, 0x54, 0x05, 0x00, 0x01, 0x14, 0x00, 0x00, 0x00,
> + 0x53, 0x80, 0x00, 0x80, 0x60, 0x06, 0x05, 0x02, 0x54, 0x05, 0x00, 0x06,
> + 0x14, 0x00, 0x00, 0x00, 0x52, 0x19, 0x14, 0x00, 0x60, 0x06, 0x04, 0x06,
> + 0x04, 0x02, 0x0e, 0x01, 0x04, 0x01, 0x04, 0x04, 0x70, 0x19, 0x14, 0x00,
> + 0x20, 0x02, 0x01, 0x00, 0x04, 0x06, 0x10, 0x52, 0x44, 0x05, 0x00, 0x00,
> + 0x2e, 0x00, 0x14, 0x14, 0x00, 0xc0, 0x00, 0x00, 0x98, 0x00, 0x00, 0x00,
> + 0x98, 0x00, 0x00, 0x00, 0x61, 0x00, 0x00, 0xb4, 0x14, 0x06, 0x10, 0x00,
> + 0x61, 0x00, 0x08, 0xb4, 0x16, 0x07, 0x10, 0x00, 0x69, 0x1a, 0x10, 0x00,
> + 0x70, 0x86, 0x05, 0x18, 0x04, 0x14, 0x20, 0x05, 0x02, 0x00, 0x02, 0x00,
> + 0x69, 0x1a, 0x10, 0x02, 0x70, 0x86, 0x05, 0x1a, 0x04, 0x16, 0x20, 0x05,
> + 0x02, 0x00, 0x02, 0x00, 0x40, 0x1a, 0x00, 0x38, 0x08, 0x18, 0x10, 0x05,
> + 0x40, 0x1a, 0x08, 0x38, 0x0a, 0x1a, 0x10, 0x05, 0x31, 0x23, 0x17, 0x00,
> + 0x00, 0x00, 0x14, 0x0c, 0x24, 0x08, 0x00, 0xfb, 0x00, 0x00, 0x00, 0x00,
> + 0x40, 0x00, 0x00, 0x38, 0x10, 0x18, 0x30, 0x05, 0x40, 0x00, 0x08, 0x38,
> + 0x12, 0x1a, 0x30, 0x05, 0x41, 0x83, 0x20, 0x20, 0x0e, 0x0c, 0x00, 0x0c,
> + 0x31, 0x24, 0x15, 0x00, 0x00, 0x00, 0x00, 0x00, 0x24, 0x10, 0x08, 0xfb,
> + 0x14, 0x0e, 0x00, 0x00, 0x01, 0x00, 0x00, 0x00, 0x00, 0x42, 0x01, 0x00,
> + 0x00, 0x00, 0x00, 0x20, 0x10, 0x00, 0x00, 0x00, 0x2f, 0x00, 0x14, 0x00,
> + 0x00, 0x40, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x10, 0x00, 0x00, 0x00,
> + 0x61, 0x00, 0x10, 0x28, 0x7f, 0x00, 0x10, 0x00, 0x31, 0x20, 0x02, 0x80,
> + 0x04, 0x00, 0x00, 0x00, 0x0c, 0x7f, 0x20, 0x30, 0x00, 0x00, 0x00, 0x00
> +};
> +
> const struct intel_compute_kernels intel_compute_square_kernels[] = {
> {
> .ip_ver = IP_VER(12, 0),
> @@ -204,5 +235,10 @@ const struct intel_compute_kernels intel_compute_square_kernels[] = {
> .size = sizeof(xehpc_kernel_square_bin),
> .kernel = xehpc_kernel_square_bin,
> },
> + {
> + .ip_ver = IP_VER(20, 04),
> + .size = sizeof(xe2lpg_kernel_square_bin),
> + .kernel = xe2lpg_kernel_square_bin,
> + },
> {}
> };
> --
> 2.25.1
>
LGTM:
Reviewed-by: Zbigniew Kempczyński <zbigniew.kempczynski@intel.com>
--
Zbigniew
next prev parent reply other threads:[~2023-12-04 7:58 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-01 11:35 [igt-dev] [PATCH i-g-t 0/3] Extend compute square test to Xe2 platform janga.rahul.kumar
2023-12-01 11:35 ` [igt-dev] [PATCH i-g-t 1/3] lib/intel_compute_square_kernels: Add xe2lpg compute sqaure kernel janga.rahul.kumar
2023-12-04 7:58 ` Zbigniew Kempczyński [this message]
2023-12-01 11:35 ` [igt-dev] [PATCH i-g-t 2/3] lib/intel_compute: Add XE2 compute implementation janga.rahul.kumar
2023-12-04 8:07 ` Zbigniew Kempczyński
2023-12-04 12:25 ` Kumar, Janga Rahul
2023-12-01 11:35 ` [igt-dev] [PATCH i-g-t 3/3] tests/xe_compute: Update documentation regarding test requirements janga.rahul.kumar
2023-12-04 8:09 ` Zbigniew Kempczyński
2023-12-01 13:10 ` [igt-dev] ✓ Fi.CI.BAT: success for Extend compute square test to Xe2 platform Patchwork
2023-12-01 13:20 ` [igt-dev] ✓ CI.xeBAT: " Patchwork
2023-12-03 0:07 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231204075800.smdpsc7nprysd2ae@zkempczy-mobl2 \
--to=zbigniew.kempczynski@intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=janga.rahul.kumar@intel.com \
--cc=ramadevi.gandi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox