From: janga.rahul.kumar@intel.com
To: igt-dev@lists.freedesktop.org, ramadevi.gandi@intel.com,
janga.rahul.kumar@intel.com
Subject: [igt-dev] [PATCH i-g-t v2 1/4] lib/intel_compute: Rename compute state addresses
Date: Mon, 4 Dec 2023 17:58:22 +0530 [thread overview]
Message-ID: <20231204122825.3689117-2-janga.rahul.kumar@intel.com> (raw)
In-Reply-To: <20231204122825.3689117-1-janga.rahul.kumar@intel.com>
From: Janga Rahul Kumar <janga.rahul.kumar@intel.com>
Rename platform specific state base and binding offset address variable
names to generic ones as they can be resued for most of the platforms.
Cc: Zbigniew Kempczyński <zbigniew.kempczynski@intel.com>
Signed-off-by: Janga Rahul Kumar <janga.rahul.kumar@intel.com>
---
lib/intel_compute.c | 28 ++++++++++++++--------------
1 file changed, 14 insertions(+), 14 deletions(-)
diff --git a/lib/intel_compute.c b/lib/intel_compute.c
index dd921bf46..c8dc42338 100644
--- a/lib/intel_compute.c
+++ b/lib/intel_compute.c
@@ -37,9 +37,9 @@
#define OFFSET_INDIRECT_DATA_START 0xFFFD0000
#define OFFSET_KERNEL 0xFFFE0000
-#define XEHP_ADDR_GENERAL_STATE_BASE 0x80000000UL
-#define XEHP_ADDR_INSTRUCTION_STATE_BASE 0x90000000UL
-#define XEHP_OFFSET_BINDING_TABLE 0x1000
+#define ADDR_GENERAL_STATE_BASE 0x80000000UL
+#define ADDR_INSTRUCTION_STATE_BASE 0x90000000UL
+#define OFFSET_BINDING_TABLE 0x1000
struct bo_dict_entry {
uint64_t addr;
@@ -867,7 +867,7 @@ static void xehp_compute_exec(int fd, const unsigned char *kernel,
{
#define XEHP_BO_DICT_ENTRIES 9
struct bo_dict_entry bo_dict[XEHP_BO_DICT_ENTRIES] = {
- { .addr = XEHP_ADDR_INSTRUCTION_STATE_BASE + OFFSET_KERNEL,
+ { .addr = ADDR_INSTRUCTION_STATE_BASE + OFFSET_KERNEL,
.name = "instr state base"},
{ .addr = ADDR_DYNAMIC_STATE_BASE,
.size = 0x100000,
@@ -875,16 +875,16 @@ static void xehp_compute_exec(int fd, const unsigned char *kernel,
{ .addr = ADDR_SURFACE_STATE_BASE,
.size = 0x1000,
.name = "surface state base"},
- { .addr = XEHP_ADDR_GENERAL_STATE_BASE + OFFSET_INDIRECT_DATA_START,
+ { .addr = ADDR_GENERAL_STATE_BASE + OFFSET_INDIRECT_DATA_START,
.size = 0x1000,
.name = "indirect object base"},
{ .addr = ADDR_INPUT, .size = SIZE_BUFFER_INPUT,
.name = "addr input"},
{ .addr = ADDR_OUTPUT, .size = SIZE_BUFFER_OUTPUT,
.name = "addr output" },
- { .addr = XEHP_ADDR_GENERAL_STATE_BASE, .size = 0x100000,
+ { .addr = ADDR_GENERAL_STATE_BASE, .size = 0x100000,
.name = "general state base" },
- { .addr = ADDR_SURFACE_STATE_BASE + XEHP_OFFSET_BINDING_TABLE,
+ { .addr = ADDR_SURFACE_STATE_BASE + OFFSET_BINDING_TABLE,
.size = 0x1000,
.name = "binding table" },
{ .addr = ADDR_BATCH, .size = SIZE_BATCH,
@@ -912,10 +912,10 @@ static void xehp_compute_exec(int fd, const unsigned char *kernel,
((float *)dinput)[i] = rand() / (float)RAND_MAX;
xehp_compute_exec_compute(bo_dict[8].data,
- XEHP_ADDR_GENERAL_STATE_BASE,
+ ADDR_GENERAL_STATE_BASE,
ADDR_SURFACE_STATE_BASE,
ADDR_DYNAMIC_STATE_BASE,
- XEHP_ADDR_INSTRUCTION_STATE_BASE,
+ ADDR_INSTRUCTION_STATE_BASE,
OFFSET_INDIRECT_DATA_START,
OFFSET_KERNEL);
@@ -1081,16 +1081,16 @@ static void xehpc_compute_exec(int fd, const unsigned char *kernel,
{
#define XEHPC_BO_DICT_ENTRIES 6
struct bo_dict_entry bo_dict[XEHPC_BO_DICT_ENTRIES] = {
- { .addr = XEHP_ADDR_INSTRUCTION_STATE_BASE + OFFSET_KERNEL,
+ { .addr = ADDR_INSTRUCTION_STATE_BASE + OFFSET_KERNEL,
.name = "instr state base"},
- { .addr = XEHP_ADDR_GENERAL_STATE_BASE + OFFSET_INDIRECT_DATA_START,
+ { .addr = ADDR_GENERAL_STATE_BASE + OFFSET_INDIRECT_DATA_START,
.size = 0x10000,
.name = "indirect object base"},
{ .addr = ADDR_INPUT, .size = SIZE_BUFFER_INPUT,
.name = "addr input"},
{ .addr = ADDR_OUTPUT, .size = SIZE_BUFFER_OUTPUT,
.name = "addr output" },
- { .addr = XEHP_ADDR_GENERAL_STATE_BASE, .size = 0x10000,
+ { .addr = ADDR_GENERAL_STATE_BASE, .size = 0x10000,
.name = "general state base" },
{ .addr = ADDR_BATCH, .size = SIZE_BATCH,
.name = "batch" },
@@ -1114,10 +1114,10 @@ static void xehpc_compute_exec(int fd, const unsigned char *kernel,
((float *)dinput)[i] = rand() / (float)RAND_MAX;
xehpc_compute_exec_compute(bo_dict[5].data,
- XEHP_ADDR_GENERAL_STATE_BASE,
+ ADDR_GENERAL_STATE_BASE,
ADDR_SURFACE_STATE_BASE,
ADDR_DYNAMIC_STATE_BASE,
- XEHP_ADDR_INSTRUCTION_STATE_BASE,
+ ADDR_INSTRUCTION_STATE_BASE,
OFFSET_INDIRECT_DATA_START,
OFFSET_KERNEL);
--
2.25.1
next prev parent reply other threads:[~2023-12-04 12:24 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-04 12:28 [igt-dev] [PATCH i-g-t v2 0/4] Extend compute square test to Xe2 platform janga.rahul.kumar
2023-12-04 12:28 ` janga.rahul.kumar [this message]
2023-12-04 13:50 ` [igt-dev] [PATCH i-g-t v2 1/4] lib/intel_compute: Rename compute state addresses Zbigniew Kempczyński
2023-12-04 12:28 ` [igt-dev] [PATCH i-g-t v2 2/4] lib/intel_compute_square_kernels: Add xe2lpg compute sqaure kernel janga.rahul.kumar
2023-12-04 12:28 ` [igt-dev] [PATCH i-g-t v2 3/4] lib/intel_compute: Add XE2 compute implementation janga.rahul.kumar
2023-12-04 13:51 ` Zbigniew Kempczyński
2023-12-04 12:28 ` [igt-dev] [PATCH i-g-t v2 4/4] tests/xe_compute: Update documentation regarding test requirements janga.rahul.kumar
2023-12-04 16:54 ` [igt-dev] ✗ Fi.CI.BUILD: failure for Extend compute square test to Xe2 platform (rev2) Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231204122825.3689117-2-janga.rahul.kumar@intel.com \
--to=janga.rahul.kumar@intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=ramadevi.gandi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox