From: Marcin Bernatowicz <marcin.bernatowicz@intel.com>
To: igt-dev@lists.freedesktop.org
Cc: adam.miszczak@intel.com, matthew.auld@intel.com,
jakub1.kolakowski@intel.com
Subject: [PATCH v7 i-g-t 2/2] tests/intel/xe_create: create-big-vram subtest
Date: Thu, 7 Dec 2023 13:44:18 +0100 [thread overview]
Message-ID: <20231207124418.26414-3-marcin.bernatowicz@intel.com> (raw)
In-Reply-To: <20231207124418.26414-1-marcin.bernatowicz@intel.com>
Validates the creation of significant Buffer Object (BO) within VRAM,
considering the entire available CPU-visible VRAM size.
The size of the created BO can be adjusted using command line
parameters, with '-S' representing BO size in MB,
and '-p' representing BO size as a percentage of the VRAM size.
v2: rebased, updated to uAPI changes (DRM_XE_VM_CREATE_FLAG_ASYNC_DEFAULT),
after review corrections: 1024UL -> 1024ULL,
int -> unsigned int (Kamil)
v3: provided a flag to allocate the memory within the CPU-visible
portion of VRAM (Matt)
__create_bo replaced with xe_bo_create_flags (Lukasz)
removed the percent command line parameter (Lukasz)
renamed size_MB to size_mb (Lukasz)
added helper function to query available CPU-visible VRAM size,
renamed 'xe_vram_available' to 'xe_available_vram_size' for
consistency with other function names
v4: split lib and test changes into separate patches (Lukasz, Kamil)
added prefixes to titles (Kamil)
restored percent command line parameter (Kamil)
whitespace correction (Kamil)
v5: skip the test if there is no available visible VRAM (Kamil)
split to per gt subtests
simplified bo_size assignment
v6: adjustments to uAPI changes
v7: moved create-big-vram before mulitigpu test (Kamil)
Cc: Kamil Konieczny <kamil.konieczny@linux.intel.com>
Cc: Lukasz Laguna <lukasz.laguna@intel.com>
Cc: Matthew Auld <matthew.auld@intel.com>
Reviewed-by: Kamil Konieczny <kamil.konieczny@linux.intel.com>
Signed-off-by: Marcin Bernatowicz <marcin.bernatowicz@intel.com>
---
tests/intel/xe_create.c | 88 ++++++++++++++++++++++++++++++++++++++++-
1 file changed, 86 insertions(+), 2 deletions(-)
diff --git a/tests/intel/xe_create.c b/tests/intel/xe_create.c
index bbdddc7c9..cef9db23d 100644
--- a/tests/intel/xe_create.c
+++ b/tests/intel/xe_create.c
@@ -18,6 +18,14 @@
#define PAGE_SIZE 0x1000
+static struct param {
+ unsigned int size_mb;
+ unsigned int vram_percent;
+} params = {
+ .size_mb = 0,
+ .vram_percent = 100,
+};
+
static int __create_bo(int fd, uint32_t vm, uint64_t size, uint32_t placement,
uint32_t *handlep)
{
@@ -216,7 +224,74 @@ static void create_massive_size(int fd)
}
}
-igt_main
+/**
+ * SUBTEST: create-big-vram
+ * Functionality: BO creation
+ * Test category: functionality test
+ * Description: Verifies the creation of substantial BO within VRAM,
+ * constituting all available CPU-visible VRAM.
+ */
+static void create_big_vram(int fd, int gt)
+{
+ uint64_t bo_size, size, visible_avail_size, alignment;
+ uint32_t bo_handle;
+ char *bo_ptr = NULL;
+ uint64_t vm = 0;
+
+ alignment = xe_get_default_alignment(fd);
+ vm = xe_vm_create(fd, DRM_XE_VM_CREATE_FLAG_ASYNC_DEFAULT, 0);
+
+ visible_avail_size = xe_visible_available_vram_size(fd, gt);
+ igt_require(visible_avail_size);
+
+ bo_size = params.size_mb ? params.size_mb * 1024ULL * 1024ULL
+ : ALIGN_DOWN(visible_avail_size * params.vram_percent / 100, alignment);
+ igt_require(bo_size);
+ igt_info("gt%u bo_size=%lu visible_available_vram_size=%lu\n",
+ gt, bo_size, visible_avail_size);
+
+ bo_handle = xe_bo_create(fd, vm, bo_size, vram_if_possible(fd, gt),
+ DRM_XE_GEM_CREATE_FLAG_NEEDS_VISIBLE_VRAM);
+ bo_ptr = xe_bo_map(fd, bo_handle, bo_size);
+
+ size = bo_size - 1;
+ while (size > SZ_64K) {
+ igt_assert_eq(0, READ_ONCE(bo_ptr[size]));
+ WRITE_ONCE(bo_ptr[size], 'A');
+ igt_assert_eq('A', READ_ONCE(bo_ptr[size]));
+ size >>= 1;
+ }
+ igt_assert_eq(0, bo_ptr[0]);
+
+ munmap(bo_ptr, bo_size);
+ gem_close(fd, bo_handle);
+ xe_vm_destroy(fd, vm);
+}
+
+static int opt_handler(int opt, int opt_index, void *data)
+{
+ switch (opt) {
+ case 'S':
+ params.size_mb = atoi(optarg);
+ igt_debug("Size MB: %d\n", params.size_mb);
+ break;
+ case 'p':
+ params.vram_percent = atoi(optarg);
+ igt_debug("Percent of VRAM: %d\n", params.vram_percent);
+ break;
+ default:
+ return IGT_OPT_HANDLER_ERROR;
+ }
+
+ return IGT_OPT_HANDLER_SUCCESS;
+}
+
+const char *help_str =
+ " -S\tBO size in MB\n"
+ " -p\tPercent of VRAM for BO\n"
+ ;
+
+igt_main_args("S:p:", NULL, help_str, opt_handler, NULL)
{
int xe;
@@ -237,6 +312,16 @@ igt_main
create_massive_size(xe);
}
+ igt_subtest_with_dynamic("create-big-vram") {
+ int gt;
+
+ igt_require(xe_has_vram(xe));
+
+ xe_for_each_gt(xe, gt)
+ igt_dynamic_f("gt%u", gt)
+ create_big_vram(xe, gt);
+ }
+
igt_subtest("multigpu-create-massive-size") {
int gpu_count = drm_prepare_filtered_multigpu(DRIVER_XE);
@@ -255,7 +340,6 @@ igt_main
igt_waitchildren();
}
-
igt_fixture
drm_close_driver(xe);
}
--
2.31.1
next prev parent reply other threads:[~2023-12-07 12:44 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-07 12:44 [PATCH v7 i-g-t 0/2] add create-big-vram subtest Marcin Bernatowicz
2023-12-07 12:44 ` [PATCH v7 i-g-t 1/2] lib/xe/xe_query: xe_visible_available_vram_size helper Marcin Bernatowicz
2023-12-07 12:44 ` Marcin Bernatowicz [this message]
2023-12-07 14:06 ` ✓ Fi.CI.BAT: success for add create-big-vram subtest (rev4) Patchwork
2023-12-07 14:15 ` ✓ CI.xeBAT: " Patchwork
2023-12-08 4:05 ` ✓ Fi.CI.IGT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231207124418.26414-3-marcin.bernatowicz@intel.com \
--to=marcin.bernatowicz@intel.com \
--cc=adam.miszczak@intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=jakub1.kolakowski@intel.com \
--cc=matthew.auld@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox