From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.12]) by gabe.freedesktop.org (Postfix) with ESMTPS id 41A6D10E934 for ; Thu, 7 Dec 2023 16:35:24 +0000 (UTC) From: Marcin Bernatowicz To: igt-dev@lists.freedesktop.org Subject: [PATCH i-g-t] benchmarks/gem_wsim: Fix array index issue in xe_sync object referencing Date: Thu, 7 Dec 2023 17:35:16 +0100 Message-Id: <20231207163516.8036-1-marcin.bernatowicz@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" List-ID: During the split of xe_sync types from flags introduced in commit ce4e53b0faecde8884f1d4eac81d604b6e1904b8, the array index of xe_sync objects was unnecessarily incremented in one of the lines. This caused the next line to reference the wrong xe_sync object. This patch fixes the array index issue, ensuring the correct xe_sync object is referenced. Fixes: ce4e53b0faecde8884f1d4eac81d604b6e1904b8 ("drm-uapi/xe: Split xe_sync types from flags") Signed-off-by: Marcin Bernatowicz Signed-off-by: Marcin Bernatowicz --- benchmarks/gem_wsim.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/benchmarks/gem_wsim.c b/benchmarks/gem_wsim.c index e937e1027..30673da8f 100644 --- a/benchmarks/gem_wsim.c +++ b/benchmarks/gem_wsim.c @@ -1784,7 +1784,7 @@ xe_alloc_step_batch(struct workload *wrk, struct w_step *w) i = 0; /* out fence */ w->xe.syncs[i].handle = syncobj_create(fd, 0); - w->xe.syncs[i++].type = DRM_XE_SYNC_TYPE_SYNCOBJ; + w->xe.syncs[i].type = DRM_XE_SYNC_TYPE_SYNCOBJ; w->xe.syncs[i++].flags = DRM_XE_SYNC_FLAG_SIGNAL; /* in fence(s) */ for_each_dep(dep, w->data_deps) { -- 2.31.1